wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-17 19:21:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-MinervaNeue/tests/qunit/skins.minerva.scripts/downloadPageAction.test.js

177 lines
8.1 KiB
JavaScript
Raw Normal View History

Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
( function ( M ) {
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
var VALID_UA = 'Mozilla/5.0 (Linux; Android 5.1.1; Nexus 6 Build/LYZ28E) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Mobile Safari/537.36',
VALID_SUPPORTED_NAMESPACES = [ 0 ],
Hygiene: revise lazy image loading API Update the API usage for lazily loaded images. This is still clumsy and may be further revised in future patches. Bug: T211724 Depends-On: Ic73f78825eaab561e8ed694aa6cc102ccb471f95 Change-Id: Ia708cda688e6bdb12074d85d98f7e98fdf7b0ca8
2019-01-08 20:35:28 +00:00
mobile = M.require( 'mobile.startup' ),
icons = mobile.icons,
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
Deferred = $.Deferred,
Disable download button on Chrome like browsers Add Dolphin, Opera and Maxthon to whitelist Bug: T182059 Change-Id: I39bf9d016aba189016b2ce5b42a2e95b58cb33ce
2018-02-01 18:59:18 +00:00
windowChrome = { chrome: true },
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
downloadIcon = icons.spinner(),
Disable download button on Chrome like browsers Add Dolphin, Opera and Maxthon to whitelist Bug: T182059 Change-Id: I39bf9d016aba189016b2ce5b42a2e95b58cb33ce
2018-02-01 18:59:18 +00:00
windowNotChrome = {},
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
downloadAction = require( '../../../resources/skins.minerva.scripts/downloadPageAction.js' ),
getOnClickHandler = downloadAction.test.getOnClickHandler,
isAvailable = downloadAction.test.isAvailable,
Hygiene: revise lazy image loading API Update the API usage for lazily loaded images. This is still clumsy and may be further revised in future patches. Bug: T211724 Depends-On: Ic73f78825eaab561e8ed694aa6cc102ccb471f95 Change-Id: Ia708cda688e6bdb12074d85d98f7e98fdf7b0ca8
2019-01-08 20:35:28 +00:00
browser = mobile.Browser.getSingleton(),
lazyImageLoader = mobile.lazyImages.lazyImageLoader,
Page = mobile.Page;
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
QUnit.module( 'Minerva DownloadIcon', {
build: Update linters This exposes two broken tests: * #setCount (Eastern Arabic numerals) * clicking on the product of createBanner() should trigger a custom event that were previously passing due to buggy assertions. Change-Id: If18ad1ff9363fff65d3e347c01ce4bc0669b2a0e
2018-09-11 13:13:41 +00:00
beforeEach: function () {
Hygiene: remove unused downloadPageAction argument Remove unused Skin parameter from downloadPageAction. Change-Id: I27cd85b1e4f2328d3d4fd0ece5580c4432181757
2019-04-10 20:23:58 +00:00
this.getOnClickHandler = function () {
return getOnClickHandler( icons.spinner() ).bind( downloadIcon );
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
};
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
}
} );
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
QUnit.test( '#getOnClickHandler (print after image download)', function ( assert ) {
Hygiene: remove unused downloadPageAction argument Remove unused Skin parameter from downloadPageAction. Change-Id: I27cd85b1e4f2328d3d4fd0ece5580c4432181757
2019-04-10 20:23:58 +00:00
var handler = this.getOnClickHandler(),
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
d = Deferred(),
spy = this.sandbox.stub( window, 'print' );
Hygiene: revise lazy image loading API Update the API usage for lazily loaded images. This is still clumsy and may be further revised in future patches. Bug: T211724 Depends-On: Ic73f78825eaab561e8ed694aa6cc102ccb471f95 Change-Id: Ia708cda688e6bdb12074d85d98f7e98fdf7b0ca8
2019-01-08 20:35:28 +00:00
this.sandbox.stub( lazyImageLoader, 'loadImages' ).returns( d.resolve() );
Hygiene: revise lazyImageLoader.loadImages() API There is no longer a need to pass in a jQuery dependency. Don't use the stateful skin to query image placeholders. Use the lazy image loader instead. Depends-On: I3d023b3d96bf278666abb956142e5cee12b68b1f Bug: T214658 Change-Id: I2bf42366c0e27462c32162124d07761b91d66166
2019-01-10 20:53:28 +00:00
this.sandbox.stub( lazyImageLoader, 'queryPlaceholders' ).returns( [] );
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
handler();
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
d.then( function () {
Hygiene: replace calledOnce / Twice w/ callCount Replace all test assertions for calledOnce / Twice with callCount. assert.ok( calledOnce / Twice ) only lets the dev know that a test fails. assert.strictEqual( callCount, EXPECTATION ) starts the debugging process when it fails since it provides the difference in the failure output. strictEqual() was deliberately used since it's a saner default and the codebase already favors === equivalency checks. find tests -name \*.js| xargs -rd\\n sed -ri ' s%ok\(([^,]+)calledOnce%strictEqual(\1callCount, 1%g; s%ok\(([^,]+)calledTwice%strictEqual(\1callCount, 2%g; ' Change-Id: I5c4c595c4520cecfad46d652f639a63a1c2c00b4
2018-04-24 22:00:10 +00:00
assert.strictEqual( spy.callCount, 1, 'Print occurred.' );
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
} );
return d;
} );
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
QUnit.test( '#getOnClickHandler (print via timeout)', function ( assert ) {
Hygiene: remove unused downloadPageAction argument Remove unused Skin parameter from downloadPageAction. Change-Id: I27cd85b1e4f2328d3d4fd0ece5580c4432181757
2019-04-10 20:23:58 +00:00
var handler = this.getOnClickHandler(),
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
d = Deferred(),
spy = this.sandbox.stub( window, 'print' );
Hygiene: revise lazy image loading API Update the API usage for lazily loaded images. This is still clumsy and may be further revised in future patches. Bug: T211724 Depends-On: Ic73f78825eaab561e8ed694aa6cc102ccb471f95 Change-Id: Ia708cda688e6bdb12074d85d98f7e98fdf7b0ca8
2019-01-08 20:35:28 +00:00
this.sandbox.stub( lazyImageLoader, 'loadImages' ).returns( d );
Hygiene: revise lazyImageLoader.loadImages() API There is no longer a need to pass in a jQuery dependency. Don't use the stateful skin to query image placeholders. Use the lazy image loader instead. Depends-On: I3d023b3d96bf278666abb956142e5cee12b68b1f Bug: T214658 Change-Id: I2bf42366c0e27462c32162124d07761b91d66166
2019-01-10 20:53:28 +00:00
this.sandbox.stub( lazyImageLoader, 'queryPlaceholders' ).returns( [] );
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
window.setTimeout( function () {
d.resolve();
}, 3400 );
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
handler();
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
d.then( function () {
Hygiene: replace calledOnce / Twice w/ callCount Replace all test assertions for calledOnce / Twice with callCount. assert.ok( calledOnce / Twice ) only lets the dev know that a test fails. assert.strictEqual( callCount, EXPECTATION ) starts the debugging process when it fails since it provides the difference in the failure output. strictEqual() was deliberately used since it's a saner default and the codebase already favors === equivalency checks. find tests -name \*.js| xargs -rd\\n sed -ri ' s%ok\(([^,]+)calledOnce%strictEqual(\1callCount, 1%g; s%ok\(([^,]+)calledTwice%strictEqual(\1callCount, 2%g; ' Change-Id: I5c4c595c4520cecfad46d652f639a63a1c2c00b4
2018-04-24 22:00:10 +00:00
assert.strictEqual( spy.callCount, 1,
Hygiene: revise lazy image loading API Update the API usage for lazily loaded images. This is still clumsy and may be further revised in future patches. Bug: T211724 Depends-On: Ic73f78825eaab561e8ed694aa6cc102ccb471f95 Change-Id: Ia708cda688e6bdb12074d85d98f7e98fdf7b0ca8
2019-01-08 20:35:28 +00:00
'Print was called once despite loadImages resolving after MAX_PRINT_TIMEOUT' );
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
} );
return d;
} );
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
QUnit.test( '#getOnClickHandler (multiple clicks)', function ( assert ) {
Hygiene: remove unused downloadPageAction argument Remove unused Skin parameter from downloadPageAction. Change-Id: I27cd85b1e4f2328d3d4fd0ece5580c4432181757
2019-04-10 20:23:58 +00:00
var handler = this.getOnClickHandler(),
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
d = Deferred(),
spy = this.sandbox.stub( window, 'print' );
Hygiene: revise lazy image loading API Update the API usage for lazily loaded images. This is still clumsy and may be further revised in future patches. Bug: T211724 Depends-On: Ic73f78825eaab561e8ed694aa6cc102ccb471f95 Change-Id: Ia708cda688e6bdb12074d85d98f7e98fdf7b0ca8
2019-01-08 20:35:28 +00:00
this.sandbox.stub( lazyImageLoader, 'loadImages' ).returns( d );
Hygiene: revise lazyImageLoader.loadImages() API There is no longer a need to pass in a jQuery dependency. Don't use the stateful skin to query image placeholders. Use the lazy image loader instead. Depends-On: I3d023b3d96bf278666abb956142e5cee12b68b1f Bug: T214658 Change-Id: I2bf42366c0e27462c32162124d07761b91d66166
2019-01-10 20:53:28 +00:00
this.sandbox.stub( lazyImageLoader, 'queryPlaceholders' ).returns( [] );
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
window.setTimeout( function () {
d.resolve();
}, 3400 );
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
handler();
handler();
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
d.then( function () {
Hygiene: replace calledOnce / Twice w/ callCount Replace all test assertions for calledOnce / Twice with callCount. assert.ok( calledOnce / Twice ) only lets the dev know that a test fails. assert.strictEqual( callCount, EXPECTATION ) starts the debugging process when it fails since it provides the difference in the failure output. strictEqual() was deliberately used since it's a saner default and the codebase already favors === equivalency checks. find tests -name \*.js| xargs -rd\\n sed -ri ' s%ok\(([^,]+)calledOnce%strictEqual(\1callCount, 1%g; s%ok\(([^,]+)calledTwice%strictEqual(\1callCount, 2%g; ' Change-Id: I5c4c595c4520cecfad46d652f639a63a1c2c00b4
2018-04-24 22:00:10 +00:00
assert.strictEqual( spy.callCount, 1,
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
'Print was called once despite multiple clicks' );
} );
return d;
} );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
QUnit.module( 'isAvailable()', {
build: Update linters This exposes two broken tests: * #setCount (Eastern Arabic numerals) * clicking on the product of createBanner() should trigger a custom event that were previously passing due to buggy assertions. Change-Id: If18ad1ff9363fff65d3e347c01ce4bc0669b2a0e
2018-09-11 13:13:41 +00:00
beforeEach: function () {
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
var page = new Page( {
id: 0,
title: 'Test',
isMainPage: false
} );
this.page = page;
this.isAvailable = function ( ua ) {
return isAvailable( windowChrome, page, ua,
VALID_SUPPORTED_NAMESPACES );
};
this.notChromeIsAvailable = function ( ua ) {
return isAvailable( windowNotChrome, page, ua,
VALID_SUPPORTED_NAMESPACES );
};
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
}
} );
QUnit.test( 'isAvailable() handles properly correct namespace', function ( assert ) {
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.ok( this.isAvailable( VALID_UA ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
} );
QUnit.test( 'isAvailable() handles properly not supported namespace', function ( assert ) {
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( isAvailable( windowChrome, this.page, VALID_UA, [ 9999 ] ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
} );
QUnit.test( 'isAvailable() handles properly main page', function ( assert ) {
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
var page = new Page( {
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
id: 0,
title: 'Test',
isMainPage: true
} );
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( isAvailable( windowChrome, page, VALID_UA, VALID_SUPPORTED_NAMESPACES ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
} );
QUnit.test( 'isAvailable() returns false for iOS', function ( assert ) {
this.sandbox.stub( browser, 'isIos' ).returns( true );
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.isAvailable( VALID_UA ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
} );
Disable download button on Chrome like browsers Add Dolphin, Opera and Maxthon to whitelist Bug: T182059 Change-Id: I39bf9d016aba189016b2ce5b42a2e95b58cb33ce
2018-02-01 18:59:18 +00:00
QUnit.test( 'isAvailable() uses window.chrome to filter certain chrome-like browsers', function ( assert ) {
// Dolphin
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.notChromeIsAvailable( ' Mozilla/5.0 (Linux; Android 7.0; SM-G950U1 Build/NRD90M; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/61.0.3163.98 Mobile Safari/537.36' ) );
Disable download button on Chrome like browsers Add Dolphin, Opera and Maxthon to whitelist Bug: T182059 Change-Id: I39bf9d016aba189016b2ce5b42a2e95b58cb33ce
2018-02-01 18:59:18 +00:00
// Opera
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.notChromeIsAvailable( 'Mozilla/5.0 (Linux; Android 7.0; SM-G950U1 Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.116 Mobile Safari/537.36 OPR/44.1.2246.123029' ) );
Disable download button on Chrome like browsers Add Dolphin, Opera and Maxthon to whitelist Bug: T182059 Change-Id: I39bf9d016aba189016b2ce5b42a2e95b58cb33ce
2018-02-01 18:59:18 +00:00
// Maxthon
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.notChromeIsAvailable( 'Mozilla/5.0 (Linux; Android 7.0; SM-G950U1 Build/NRD90M; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/63.0.3239.111 Mobile Safari/537.36 MxBrowser/4.5.10.1300' ) );
Disable download button on Chrome like browsers Add Dolphin, Opera and Maxthon to whitelist Bug: T182059 Change-Id: I39bf9d016aba189016b2ce5b42a2e95b58cb33ce
2018-02-01 18:59:18 +00:00
} );
build: Update linters This exposes two broken tests: * #setCount (Eastern Arabic numerals) * clicking on the product of createBanner() should trigger a custom event that were previously passing due to buggy assertions. Change-Id: If18ad1ff9363fff65d3e347c01ce4bc0669b2a0e
2018-09-11 13:13:41 +00:00
QUnit.test( 'isAvailable() handles properly browsers', function ( assert ) {
Disable download button on Chrome like browsers Add Dolphin, Opera and Maxthon to whitelist Bug: T182059 Change-Id: I39bf9d016aba189016b2ce5b42a2e95b58cb33ce
2018-02-01 18:59:18 +00:00
// IPhone 6 Safari
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.isAvailable( 'Mozilla/5.0 (iPhone; CPU iPhone OS 9_0_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13A405 Safari/601.1' ) );
Disable download button on Chrome like browsers Add Dolphin, Opera and Maxthon to whitelist Bug: T182059 Change-Id: I39bf9d016aba189016b2ce5b42a2e95b58cb33ce
2018-02-01 18:59:18 +00:00
// Nokia Lumia 930 Windows Phone 8.1
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.isAvailable( 'Mozilla/5.0 (Mobile; Windows Phone 8.1; Android 4.0; ARM; Trident/7.0; Touch; rv:11.0; IEMobile/11.0; Microsoft; Virtual) like iPhone OS 7_0_3 Mac OS X AppleWebKit/537 (KHTML, like Gecko) Mobile Safari/537' ) );
Disable download button on Chrome like browsers Add Dolphin, Opera and Maxthon to whitelist Bug: T182059 Change-Id: I39bf9d016aba189016b2ce5b42a2e95b58cb33ce
2018-02-01 18:59:18 +00:00
// Firefox @ Ubuntu
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.isAvailable( 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0' ) );
Disable download button on Chrome like browsers Add Dolphin, Opera and Maxthon to whitelist Bug: T182059 Change-Id: I39bf9d016aba189016b2ce5b42a2e95b58cb33ce
2018-02-01 18:59:18 +00:00
} );
QUnit.test( 'isAvailable() handles properly non-chrome browsers', function ( assert ) {
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
// IPhone 6 Safari
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.notChromeIsAvailable( 'Mozilla/5.0 (iPhone; CPU iPhone OS 9_0_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13A405 Safari/601.1' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
// Nokia Lumia 930 Windows Phone 8.1
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.notChromeIsAvailable( 'Mozilla/5.0 (Mobile; Windows Phone 8.1; Android 4.0; ARM; Trident/7.0; Touch; rv:11.0; IEMobile/11.0; Microsoft; Virtual) like iPhone OS 7_0_3 Mac OS X AppleWebKit/537 (KHTML, like Gecko) Mobile Safari/537' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
// Firefox @ Ubuntu
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.notChromeIsAvailable( 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
} );
QUnit.test( 'isAvailable() handles properly old devices', function ( assert ) {
// Samsung Galaxy S5, Android 4.4, Chrome 28
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.isAvailable( 'Mozilla/5.0 (Linux; Android 4.4.2; en-us; SAMSUNG SM-G900F Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Version/1.6 Chrome/28.0.1500.94 Mobile Safari/537.36' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
// Samsung Galaxyu S1, Android 4.2.2 Cyanogenmod + built in Samsung Browser
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.isAvailable( 'Mozilla/5.0 (Linux; U; Android 4.2.2; en-ca; GT-I9000 Build/JDQ39E) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30 CyanogenMod/10.1.0/galaxysmtd' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
// Samsung Galaxy S3
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.notOk( this.isAvailable( 'Mozilla/5.0 (Linux; Android 4.3; GT-I9300 Build/JSS15J) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.84 Mobile Safari/537.36' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
} );
QUnit.test( 'isAvailable() handles properly supported browsers', function ( assert ) {
// Samsung Galaxy S7, Android 6, Chrome 44
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.ok( this.isAvailable( 'Mozilla/5.0 (Linux; Android 6.0.1; SAMSUNG SM-G930F Build/MMB29K) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/4.0 Chrome/44.0.2403.133 Mobile Safari/537.36' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
// Samsung Galaxy A5, Android 7, Samsung Browser 5.2
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.ok( this.isAvailable( 'Mozilla/5.0 (Linux; Android 7.0; SAMSUNG SM-A510F Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/5.2 Chrome/51.0.2704.106 Mobile Safari/537.36' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
// Galaxy J2, Android 5, Chrome 65
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.ok( this.isAvailable( 'Mozilla/5.0 (Linux; Android 5.1.1; SM-J200G Build/LMY47X) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3320.0 Mobile Safari/537.36' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
// Desktop, Chrome 63
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.ok( this.isAvailable( 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
// Desktop, Ubuntu, Chromium 61
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.ok( this.isAvailable( 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/61.0.3163.100 Chrome/61.0.3163.100 Safari/537.36' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
// Galaxy S8, Android 8, Samsung Browser 6.2
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
assert.ok( this.isAvailable( 'Mozilla/5.0 (Linux; Android 7.0; SAMSUNG SM-G950U1 Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/6.2 Chrome/56.0.2924.87 Mobile Safari/537.36' ) );
Show Download button only on Android >= 5 & Chrome >= 41 Changes: - moved DownloadButtton checks & initialization to separate function - introduced supportedNamespaces variable for better readability - reorganized huge if(){} statement to set of smaller if's with nice comments why this configuration is not supported - introduced getAndroidVersion and getChromeVersion helper functions - added check to not allow Android < 5 or Chrome < 41 - added unit tests Bug: T182059 Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
2018-01-12 17:45:39 +00:00
} );
Load all images during print action When the print button is clicked, load all images from the page before calling window.print Add a timeout to make sure the user doesnt wait too long. Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea Bug: T180058
2017-11-15 22:37:37 +00:00
}( mw.mobileFrontend ) );
Reference in a new issue Copy permalink