This website requires JavaScript.
Explore
Help
Register
Sign In
wikimedia
/
mediawiki-skins-MinervaNeue
Watch
1
Star
0
Fork
You've already forked mediawiki-skins-MinervaNeue
0
mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced
2024-11-14 09:54:45 +00:00
Code
Issues
Packages
Projects
Releases
Wiki
Activity
5554e78102
mediawiki-skins-MinervaNeue
/
components
/
ToggleList.mustache
3 lines
92 B
Plaintext
Raw
Normal View
History
Unescape
Escape
Remove the mw-ui-icon hacks and overrides Note: this agitates T230232 again - when merging this please make sure a merge for I929090848f3e04647a97f4979ec78682623fa070 is pending. In various places we try to override the default mw-ui-icon behaviours The hacks need to be removed as part of addressing the core problem. Changes: * Wherever we use mw-ui-icon-before in PHP - wrap the label with a span so that label font-size is altered where needed - not the icon * Where a small icon is needed us isSmall parameter for the Icon component * Apply font-size to labels of mw-ui-icon-before elements * The browser tests need a slight update to access the span element inside a menu item - in the case of the logout button the label is always hidden, so we need to check the visibility of the parent element (secondary_action) Bug: T229440 Depends-On: I3f803ec4c9068b30aa93b803391aa4d65d8310ff Change-Id: I07e4ae233979636b739f1117dd7703571e0a9366
2019-08-30 17:23:55 +00:00
{{> ToggleList/ToggleList}}
Add data-mw="interface" attribute to Menu elements While dropping support of smart logout in favour of core ready.js logout, we noticed that the logout selector is a little bit too weak. Editors could make a link on a page that would work as a logout button. The easiest way to prevent this (and any other possible problems) is to add `data-mw="interface"` attribute to all generated menu entries. Change-Id: I22611b9641d82328623beb3f693bf7cddb2289ff
2021-02-10 23:35:17 +00:00
<!-- version 1.1.2 - used for partial template invalidation -->
Reference in a new issue
Copy permalink