wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-17 19:21:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-MinervaNeue/includes/Skins/footer.mustache

15 lines
526 B
Plaintext
Raw Normal View History

Simplify footer and logo generation The data already provided by SkinMustache makes the existing Minerva code redundant. * html-after-content functionality equivalent to dataAfterContent value * Rename license and last modified to have html-minerva prefixes and promote to top level data object. This allows us to distingusih Minerva values from core values. Note: previously the logo used srcset to ship a 1x logo but these were dropped during the desktop improvements work. Bug: T256083 Change-Id: I7b2cd5181eae67b345f6686e3389a76a12e3b1a1
2020-10-02 20:19:36 +00:00
{{#data-footer}}
Add `role=contentinfo` to `footer` element Mitigating an VoiceOver bug first identified in course of T66477 and clarified in T66477#6347019. Change-Id: Ie6beb6ba0848bd08a3604974dfc8dada0fd445b7
2020-07-29 22:39:42 +00:00
{{! `role` is implied in `footer` element, but added to mitigate a VoiceOver bug. }}
<footer class="mw-footer minerva-footer" role="contentinfo">
Move history link data into SkinMinerva::getTemplateData and relevant template - Remove usage/references to MinervaTemplate::getHistoryLinkHtml, html-minerva-lastmodified - Add data key for history.mustache template. - Update footer template to use new data key. Bug: T292554 Change-Id: Id5fbf61ba181a0088a25e77175b808362963c63b
2021-10-29 19:47:02 +00:00
{{#data-minerva-history-link}}
{{>history}}
{{/data-minerva-history-link}}
Simplify footer and logo generation The data already provided by SkinMustache makes the existing Minerva code redundant. * html-after-content functionality equivalent to dataAfterContent value * Rename license and last modified to have html-minerva prefixes and promote to top level data object. This allows us to distingusih Minerva values from core values. Note: previously the logo used srcset to ship a 1x logo but these were dropped during the desktop improvements work. Bug: T256083 Change-Id: I7b2cd5181eae67b345f6686e3389a76a12e3b1a1
2020-10-02 20:19:36 +00:00
<div class="post-content footer-content">
{{{html-after-content}}}
Restore logo to footer In 894364a3eb we moved the section tag for data-logos outside Logo but did not add it to the footer Bug: T295773 Change-Id: I52c07e95ac8166e9e9d11aba7cb3130cc6a2f8d7
2021-11-29 18:58:52 +00:00
{{#data-logos}}<div class="minerva-footer-logo">{{>Logo}}</div>{{/data-logos}}
Simplify footer and logo generation The data already provided by SkinMustache makes the existing Minerva code redundant. * html-after-content functionality equivalent to dataAfterContent value * Rename license and last modified to have html-minerva prefixes and promote to top level data object. This allows us to distingusih Minerva values from core values. Note: previously the logo used srcset to ship a 1x logo but these were dropped during the desktop improvements work. Bug: T256083 Change-Id: I7b2cd5181eae67b345f6686e3389a76a12e3b1a1
2020-10-02 20:19:36 +00:00
{{#data-info}}{{>footerItemList}}{{/data-info}}
{{#data-places}}{{>footerItemList}}{{/data-places}}
</div>
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
</footer>
Simplify footer and logo generation The data already provided by SkinMustache makes the existing Minerva code redundant. * html-after-content functionality equivalent to dataAfterContent value * Rename license and last modified to have html-minerva prefixes and promote to top level data object. This allows us to distingusih Minerva values from core values. Note: previously the logo used srcset to ship a 1x logo but these were dropped during the desktop improvements work. Bug: T256083 Change-Id: I7b2cd5181eae67b345f6686e3389a76a12e3b1a1
2020-10-02 20:19:36 +00:00
{{/data-footer}}
Reference in a new issue Copy permalink