mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/WikiEditor
synced 2024-11-25 00:37:23 +00:00
7721909f9f
* Code clean up in preparation for enabling linting in the future * Update code to use latest code conventions and best practices: - Make use of jQuery.Event (e.g. no need to check both e.keyCode and e.which) - jQuery: .size() -> .length - jQuery: (where appropiate) .attr() -> .prop() Setting properties like 'checked' via attr() has been deprecated in jQuery. - Whitespace - Single quotes instead of double quotes - Use literal keys in object literals instead of strings - Pass mediaWiki to closure, use mw. locally instead of "mediaWiki" global directly. - Fix indentation - Brackets around if, else and for bodies - Strict comparison to 0, null, false, true etc. - Fix missing radix parameter in parseInt - Use local $ instead of global $ - Use `foo || bar` instead of `foo ? foo : bar` - Variable scope hoisting - Double/redundant variable declarations - ['foo'] is better written in dot notation - New line at EOF - Consistency in jQuery construction: Tag name for element creation $( '<div>' ) Valid html for html parsing $( '<div foo="bar"></div>' ) - Fix regex escape warnings per JSLint/JSHint. Do escape ][, don't escape >< - .. * Add .jshintrc / .jshintignore * Updated most files, but not all. Too much at once. Change-Id: I445639b25a9688b3cdf9e5449e3d31cbcfa9c7ae |
||
|---|---|---|
| modules | ||
| tests/selenium | ||
| .gitignore | ||
| .gitreview | ||
| .jshintignore | ||
| .jshintrc | ||
| README | ||
| WikiEditor.hooks.php | ||
| WikiEditor.i18n.php | ||
| WikiEditor.php | ||
# WikiEditor provides enhancements to the MediaWiki edit page # This extension requires MediaWiki 1.17+ because it makes use of ResourceLoader. # Example LocalSettings.php additions require_once( "$IP/extensions/WikiEditor/WikiEditor.php" ); # Before configuring this extension, see WikiEditor.php and become familiar with the initial state and structure of the # $wgWikiEditorFeatures configuration variable. Essentially it's an array of arrays, keyed by feature name, each # containing global and user keys with boolean values. "global" indicates that it should be turned on for everyone # always, while user indicates that users should be allowed to turn it on or off in their user preferences. # To enable a preference by default but still allow users to disable it in preferences, use something like... $wgDefaultUserOptions['usebetatoolbar'] = 1; $wgDefaultUserOptions['usebetatoolbar-cgd'] = 1;