Commit graph

76 commits

Author SHA1 Message Date
jenkins-bot d33ec49f0c Merge "Remove ClickTracking calls" 2013-03-27 20:57:18 +00:00
Ori Livneh 61205be62a Remove ClickTracking calls
ClickTracking is deprecated; the config var gating this behavior is set
to false; the data is going to /dev/null; no one is interested in
analyzing it. I think it's dead, Jim.

Change-Id: I71ea8c174e5e38b28f128ccd380ed2a25ad50606
2013-03-27 13:41:05 -07:00
Matthew Flaschen ede8d1d8f1 Add jQuery event trigger for when the initial sections are done
* This is similar to wikiEditor-toolbar-buildSection-*, but for when
all of the initial sections are done.
* It allows other code to render after this vertical shift is done.

Change-Id: I4705d09b9ef90c1ab8dad93db3f91e70c5fd4d5b
2013-01-28 23:05:48 -05:00
Kaldari 27013f26e5 (bug 40735) Enabling editors to distinguish dashes in the WikiEditor
Right now, the Special Characters interface in WikiEditor shows all
characters in a monospace font which makes it especially difficult to
distinguish the different dash characters. The solution implemented
in this change is to add title tooltips to the following characters:
en dash, em dash, minus sign. The title tooltips are localizable and
can be added to any other characters as needed. If we eventually want
to add title tooltips to all the characters, we should come up with a
config shortcut like we're using for Hebrew vowels.

Change-Id: I7eb207acda045a868ec4c625c39bfd3d1f78ea17
2012-10-16 16:26:04 -07:00
Eranroz e63ef419f0 (bug 37484) Update removeFromToolbar to select <a> instead of <span>.
* Follows-up fbd5ef001b.

Change-Id: I95eb21ca29a2520b092d6f75ccea98f6f0d1bc32
2012-06-25 20:42:25 +02:00
Kai_Nissen_(WMDE) fbd5ef001b (bug 34847) Changing span tags of buttons to anchor tags
To allow users navigating the text markup buttons by keyboard
the span tags have been replaced by anchor tags. Also a dummy
link target has been added to make sure screen readers recognize
these tags correctly.

Change-Id: I9ec1543f3a39b57452d72067cf85b11e9351f546
2012-06-02 13:50:43 +02:00
Amir E. Aharoni 80067e8620 Making ltr default for characters.
Without this some conjoined ltr characters look weird in rtl wikis.

Change-Id: I7f38a18fd0d9728f69c63abd77b095a34cffbcb2
2012-05-20 23:27:06 +03:00
Roan Kattouw f26acc15c7 Add a configuration variable for disabling tracking clicks on the toolbar buttons 2012-02-23 22:29:37 +00:00
Roan Kattouw 9061f480db (bug 32451) Clicking on a special characters section loses the selection in IE8. Patch by Lupo 2011-11-20 15:02:20 +00:00
Derk-Jan Hartman 6325d5ea3b Harden the toolbar builder for character insertion a bit against incorrect configurations.
Will now check if character is defined and will return empty string as result instead.

Added a mw.log to catch this situation for developers.
Based on patch by User:Lupo.

Bug 31673
2011-11-14 21:55:46 +00:00
Derk-Jan Hartman 2c9bbffca7 Make sure a row is closed in the toolbar.
Patch by User:Lupo
Bug 31673
2011-11-14 21:21:15 +00:00
Roan Kattouw a1cec03598 (bug 32374) Heading dropdown disappears behind textarea after closing and re-opening the Advanced section. This seems to be caused by the collapsing animation that sets position:absolute on the section, does the fadeOut animation, then after the animation sets the position 'back' to relative. However, the position was never relative to begin with, so now the absolutely positioned header dropdown has a different closest positioned anchestor and it appears things go wrong from there and cause the bug. So instead of setting the position to relative after the animation, set it back to what it actually was before, which is static (implicitly). 2011-11-12 09:08:00 +00:00
Siebrand Mazeland cc71ec5354 * bump version to 0.3.1
* stylize.php
2011-09-13 08:56:32 +00:00
Derk-Jan Hartman e2f796c8d9 One more fix for the for in loops.
Follow up to r91347
2011-07-07 20:54:24 +00:00
Derk-Jan Hartman f83bb24864 Follow up to r91349
Missed adding quotes to two of the [rel=]
2011-07-03 22:42:28 +00:00
Derk-Jan Hartman 6f6e7d0565 Adding quotes for the [rel=] stuff, since this broke one test.
Reported in bug 29106. Patch by Michael M.
2011-07-02 09:17:01 +00:00
Derk-Jan Hartman 3cae03cef5 Correct for in loops on arrays.
Reported in bug 29106. Patch by Michael M.
2011-07-02 09:09:05 +00:00
Derk-Jan Hartman c1edd49986 Clean up some global var leaking in WikiEditor toolbar
Reported in bug 29106. Patch by Michael M.
2011-07-02 08:54:01 +00:00
Krinkle 40bb0c72b5 Extension:WikiEditor Code quality, JSHint validation and JSPERF
- Leaked globals
- Strict comparison to 0, false and ''
- Missing semicolon
- Variable name collision
- Minor improvements in caching (in a few places "var $that" cached $(this), but wasn't actually used)
- Replace calls to deprecated $j with $
- Checking undefined by strictly comparing references instead of a string comparison and typeof (speed)

(see bug 29106)
2011-06-06 23:18:13 +00:00
Roan Kattouw 63e9d0ff85 WikiEditor: (bug 27698) Toolbar height isn't updated in all code paths of addToToolbar(), causes toolbar to overlap part of the edit box if certain race conditions happen. Patch by Salvatore Ingala 2011-05-13 14:34:43 +00:00
Trevor Parscal ada78c1546 Fixed annoying bug where the index would not highlight the current page the first time you open the booklet. 2011-01-10 23:45:03 +00:00
Trevor Parscal 49eb154f2c * Fixed mistake made in r74271 where some functions were moved from core jquery.wikiEditor into jquery.wikiEditor.iframe, causing errors for textarea mode. These changes properly split the functions, allowing the iframe to override the textarea functions, and using $.client to only execute them on IE. (tested in IE7)
* Also fixed IE bug, where "delete window.myThing;" fails but "delete myThing;" succeeds.
2010-10-05 20:54:38 +00:00
Trevor Parscal cb6ff96431 Got more dialogs working again 2010-10-04 21:08:41 +00:00
Trevor Parscal 0a0f6f6e8e * Fixed the toolbar, where sprited buttons weren't receiving the correct classes.
* Changed the way dialogs toolbar buttons were being added
* Made dialog code load on the fly
2010-10-01 21:58:04 +00:00
Trevor Parscal 8be53e71af Merged in changes from r73123 2010-09-16 17:22:23 +00:00
Trevor Parscal 9d278e8dee Copied over all the resources needed to make WikiEditor stand on it's own two feet. Lots more to do as far as organizing and fleshing out the extensions's PHP bits. 2010-09-15 03:08:35 +00:00