This code started to fail when executing the FileImporter tests.
FileImporter triggers a hook that ends here.
Two suggestions:
* I think we don't need/don't want to have log entries for PHPUnit
test runs.
* In test scenarios getSkin() might return null. Since getSkinName
is also allowed to be null I believe it's fine when we log null in
such a situation.
Bug: T337270
Change-Id: I9bf946c150d99ab97b4cdf128fac87158c633331
This reverts commit 929e8463fb.
Reason for revert: we're still seeing double-logging of some events, so this is apparently still needed until we can track down what's causing that.
Change-Id: Ifc32dfc7aa2ca67169759ecd8c278f1aea2dbef8
The EditAttemptStep instrument is a candidate for migration to the
Metrics Platform [0]. The first step of the migration is to log events
both using the Event Platform (i.e. EventLogging::submit()) and using
the Metrics Platform Client (i.e. via
EventLogging::submitMetricsEvent()).
The Metrics Platform Client can mix in additional information -
so-called context attributes [1] - based on the stream configuration.
Since the majority of the default values mixed into each event in
Hooks::doEventLogging() are already known to the Metrics Platform
Client, the majority of Hooks::doMetricsPlatformLogging() is concerned
with remove those values from the event.
[0] https://wikitech.wikimedia.org/wiki/Metrics_Platform
[1] https://gerrit.wikimedia.org/g/mediawiki/libs/metrics-platform/+/aed6738b845/js/src/StreamConfig.d.ts#31
[2] https://wikitech.wikimedia.org/wiki/Metrics_Platform/Creating_a_Stream_Configuration
Bug: T309985
Change-Id: I052159884a9a8b21b3dc9ee01e2cafdbb173ca26
This reverts 843efa2f46,
no longer needed after I6028fa4a34916a6cd20161009cf5893492286c2d.
Bug: T334263
Depends-On: I6028fa4a34916a6cd20161009cf5893492286c2d
Change-Id: Ie4506d46d350fb53d6d0264763c2d55fc142997e
The corresponding client-side event logging is implemented in the
WikimediaEvents extension, so logging server-side events only doesn't
make sense.
Bug: T322602
Change-Id: I79b55adca1da0d9abfe60943dfa4f8c86ecb9626
Delete almost all code realting to the onboarding popup (blue
pulsating dot) and Beta Feature. Leave only one line to delete
any existing localStorage item that was used to remember the
dismissal of the onboarding popup.
Bug: T327515
Change-Id: I8d05e143858a2269dd6f3302dcc6cee6b0855ffd
Visiting a ?action=edit URL can, depending on user settings, result in
the MobileFrontend overlay appearing on top of WikiEditor. In these
cases, don't log anything.
Bug: T320281
Change-Id: Ib98d2cd6f2e541423e5aeebd3093bad97d6fcc4f
Add new $wgWikiEditorRealtimePreviewBeta configuration variable
to make it possible to turn off the RTP Beta Feature even when
the BetaFeatures extension is installed.
Bug: T323033
Change-Id: Ib79f4eaee9cee7404ff883f5e0685610d9dba9d9
EventLogging::logEvent() overwrides the $revId parameter when the schema
has been migrated to the Event Platform. Add a note and use a $revId of
-1 to make this consistent with other calls to EventLogging::logEvent()
for schemas that have been migrated to the Event Platform [0].
[0] https://codesearch.wmcloud.org/search/?q=%3A%3AlogEvent%5C(%20%27%5Cw%2B%27%2C%20-1
Bug: T318263
Change-Id: I5b58161a81ce1f4886f23500ee33ed74397d7107
Extensions using Phan need to be updated simultaneously with core due
to T308443.
Bug: T308718
Depends-On: Id08a220e1d6085e2b33f3f6c9d0e3935a4204659
Change-Id: I289b8cb5e74b5d87e26bfe6b779a22eaaa1071ee
For MW installations where BetaFeatures is not available, Realtime
Preview is enabled solely with the $wgWikiEditorRealtimePreview
configuration setting.
Bug: T304596
Change-Id: I880022883bf526a2aef237f4a75e790b0f9bd4e5
Store the current state (enabled/disabled) of Realtime Preview in
a new user preference `wikieditor-realtimepreview` and set it
when enabling or disabling the preview pane.
Bug: T294599
Change-Id: Id5f51c6d77ed0077906d5d5178cbfa785cc04dcf
This should fix the caching issue we're seeing on Beta
Follow-Up: Iaf49f076c5a290ab9049267b0aede1e6b13a9136
Change-Id: Ibe2fc1b48f4ccc22138f6c16d8170a74500d68e6
$wgWikiEditorRealtimeDisableDuration is introduced which allows
sysadmins to control the average time after which Realtime Preview
should be disabled. For now, this shows a simple error message that is
intentionally not localized. In a future patch, we will force the
user into a 'manual preview' workflow. See T304568 for more.
Bug: T302282
Change-Id: I2f01eef19fe81c19efedcc0073a28884f0055359
* Toolbar button to toggle a two-pane layout on and off.
* Resizable bar for the width of the two panes.
* Resizable bar for the edit box height, even when realtime preview is off.
* Only enabled when $wgWikiEditorRealtimePreview = true.
* Fires JS hooks when enabled, resized, and disabled.
Bug: T293347
Change-Id: Id09d44519249c0b7f5c33d48d524b7c92a5a9106
The static function WikiEditorHooks::editPageShowEditFormInitial is
kept for compatibility because there are usages in other extensions.
Change-Id: I7ba9f56fd3d00d575696f00f9f1c868fa7ad223b
ConfirmEdit should be added as a phan dependency, so thing like this no
longer happen in the future.
Bug: T296287
Change-Id: Ic9942b3a6d872c0d3c0e3a53d9462df6f82b06c6
This isn't strictly WikiEditor business, but other logging is done
here, and soon real-time previewing will be built in WikiEditor,
so it makes sense to keep all the logging for the different types
of preview together.
Bug: T290521
Change-Id: If42697e43c1bec95d743244d0acf96c47df8b681
Use CacheKeyHelper to get a status from SimpleCaptcha instead of it.
Bug: T275710
Depends-On: I7942ccd6b58584f436f872bf7c9deb63ab84482a
Change-Id: Id35ef3bcf30ddc0581c79cc10fa80e54d5352758
This change replaces in the HTML
<input type="hidden" name="wikieditorJavascriptSupport" id="wikieditorJavascriptSupport" value="" />
by
<input id="wikieditorJavascriptSupport" type="hidden" name="wikieditorJavascriptSupport"/>
but the behavior is still the same.
Change-Id: Icc9b9c9480be3b220148466d3f93746e14de280a
The UTF-8 normalization of getVal is not needed here.
Also explicit check for !== null instead of truthy because in PHP is
"0" != true.
Change-Id: I77a8a2c149045f677ff2a1f0e42d9ca9dccde321
The latter is deprecated, and the former is just a wrapper for
UserEditTracker::getUserEditCount().
Bug: T290521
Change-Id: Id3f2b9a007fe299d74d5957cbd3e31b11adb2790
EditAttemptStep and VisualEditorFeatureUse have this one very annoying
inconsistency.
Bug: T281409
Depends-On: I96e07e10943d330efcf47e0a2989ea3b73bae428
Change-Id: I3bddd3096625466fc5b6c88b64a570a389b87a05
Adds a hidden field to the edit page form, with JS that will set its
value. Server-side then checks for that value and logs whether it was
correctly set.
Bug: T263505
Change-Id: I8be06385aa6d97e5536cfc252d34297e1c000a32
Support the `url-new` mechanism so we can distinguish between
new/existing sections in direct navigation.
Bug: T272544
Change-Id: I2c431592035c7ccedbbe612bc97f63141fc4dab7
Depends-On: I3cee7a3a4c4b646692dce4a1180c4ba18a61f4bc
If someone is enrolled the DT a/b test, we want to know about their
editing here as well.
Bug: T273096
Change-Id: If2bb04011c8ca54e8c7ffd073e21bec45e92460c
In some languages, image options like 'alt' or 'thumb' can have
multiple synonyms. They were only handled for English (and were
hard-coded).
Change-Id: Ib03932d3d85a5540bea325f2717da3365756a90e
