Commit graph

91 commits

Author SHA1 Message Date
Roan Kattouw 9061f480db (bug 32451) Clicking on a special characters section loses the selection in IE8. Patch by Lupo 2011-11-20 15:02:20 +00:00
Derk-Jan Hartman 6325d5ea3b Harden the toolbar builder for character insertion a bit against incorrect configurations.
Will now check if character is defined and will return empty string as result instead.

Added a mw.log to catch this situation for developers.
Based on patch by User:Lupo.

Bug 31673
2011-11-14 21:55:46 +00:00
Derk-Jan Hartman 2c9bbffca7 Make sure a row is closed in the toolbar.
Patch by User:Lupo
Bug 31673
2011-11-14 21:21:15 +00:00
Roan Kattouw d82577cce1 Remove stray comma per bug 31673 comment 4 2011-11-14 13:51:40 +00:00
Roan Kattouw a1cec03598 (bug 32374) Heading dropdown disappears behind textarea after closing and re-opening the Advanced section. This seems to be caused by the collapsing animation that sets position:absolute on the section, does the fadeOut animation, then after the animation sets the position 'back' to relative. However, the position was never relative to begin with, so now the absolutely positioned header dropdown has a different closest positioned anchestor and it appears things go wrong from there and cause the bug. So instead of setting the position to relative after the animation, set it back to what it actually was before, which is static (implicitly). 2011-11-12 09:08:00 +00:00
Roan Kattouw 432415b129 Followup r96944: rename "Replace next" button to "Replace" cause that's what it does now 2011-10-31 08:38:35 +00:00
Sam Reed 7f10e92044 Swap
/*
 *

for

/**
 *
2011-10-26 03:49:06 +00:00
Roan Kattouw 280ae464a4 (bug 31499) articlePathRegex (detection of external links within the same wiki) broken when wgServer is protocol-relative 2011-10-25 14:30:33 +00:00
Derk-Jan Hartman 11aabbd4a9 Fix bug 31604.
Table should now load the tablesorter if needed, and make sure that the table is sortable.
2011-10-22 17:21:03 +00:00
Roan Kattouw fe7b614517 (bug 31411) Remove stray comma introduced in r86853, broke WikiEditor in IE 2011-10-06 13:15:03 +00:00
Roan Kattouw bf8858349b WikiEditor: Fix bug where ext.wikiEditor would load and wrap the textarea even if the toolbar was disabled. This has been reported to me on IRC but I'm not aware of any bug report in BZ 2011-09-29 19:04:54 +00:00
Siebrand Mazeland cc71ec5354 * bump version to 0.3.1
* stylize.php
2011-09-13 08:56:32 +00:00
Siebrand Mazeland 868eec7504 (bug 20919) Search & Replace: Change "Replace Next" functionality to "Replace" functionality. Patch by Amir E. Aharoni.
Submitter's comment: "Replace next" now replaces the currently selected text instead of finding the next occurrence and replacing it. To keep the location of the current occurrence, i added matchIndex to $(this).data.

I added some comments renamed a couple of variable for readability:
* s to textRemainder
* replace to actualReplacement

This is my first significant jQuery-style patch so it may have embarrassing mistakes - constructive criticism is welcome.
2011-09-13 08:53:12 +00:00
Siebrand Mazeland 85ad75bc8c (bug 30611) Improve WikiEditor localization for Arabic script languages. Patch by Amir E. Aharoni.
Split the Arabic section in jquery.wikiEditor.toolbar.config.js into Arabic and Arabic extended. Arabic contains the core 28-letter alphabet, special letters for the Arabic language, vowels, punctuation and digits. "Arabic extended" contains most of the other letters and signs that are used by languages such as Arabic, Urdu, Balochi, etc.
2011-08-30 16:22:26 +00:00
Roan Kattouw 0af1258eef Followup r82900: per CR, use .length instead of size(), strict comparison with zero, and re-select from the DOM after removal to guard against weird interaction between .remove() and .length 2011-08-20 12:47:00 +00:00
Roan Kattouw dccf13d8c3 (bug 29750) In the special characters toolbar, add Ș (\u0218), ș (\u0129), Ț (\u021a), ț (\u021b) and remove Ţ (\u0162), ţ (\u0163), Ŀ (\u013f), ŀ (\u0140). Patch by Amir Aharoni 2011-08-14 09:29:45 +00:00
Leo Koppelkamm fb2ee48521 r91740: Updating module name in extensions 2011-07-08 18:00:38 +00:00
Derk-Jan Hartman e2f796c8d9 One more fix for the for in loops.
Follow up to r91347
2011-07-07 20:54:24 +00:00
Derk-Jan Hartman f83bb24864 Follow up to r91349
Missed adding quotes to two of the [rel=]
2011-07-03 22:42:28 +00:00
Derk-Jan Hartman 6f6e7d0565 Adding quotes for the [rel=] stuff, since this broke one test.
Reported in bug 29106. Patch by Michael M.
2011-07-02 09:17:01 +00:00
Derk-Jan Hartman 3cae03cef5 Correct for in loops on arrays.
Reported in bug 29106. Patch by Michael M.
2011-07-02 09:09:05 +00:00
Derk-Jan Hartman c1edd49986 Clean up some global var leaking in WikiEditor toolbar
Reported in bug 29106. Patch by Michael M.
2011-07-02 08:54:01 +00:00
Derk-Jan Hartman e7132c5323 * Fix broken post call to api in side-to-side diffs
* Fix support for side-to-side diffs in section editing

Reported in bug 29106. Patch by Michael M.
2011-07-02 08:46:50 +00:00
Krinkle 6b2326d26d Follow-up r90845: mw.get > mw.config.get 2011-06-26 19:54:21 +00:00
Mark A. Hershberger b18069c06a Bug #29106: Patch from Michael M. to address JS legacy globals in wikiEditor 2011-06-26 19:25:27 +00:00
Brion Vibber 2b22c37b88 * (bug 29322) Move some iframe-specific code in WikiEditor JS to its proper module 2011-06-09 18:10:02 +00:00
Brion Vibber 85ec51cce0 Fix for WikiEditor iframe extension on IE: use $.inArray() instead of Array.indexOf(), which is not in earlier JS standards as implemented in IE 8.
Use of Array.indexOf was added in r74271 when the iframe bits were broken out to an extension.
2011-06-09 00:20:13 +00:00
Krinkle 40bb0c72b5 Extension:WikiEditor Code quality, JSHint validation and JSPERF
- Leaked globals
- Strict comparison to 0, false and ''
- Missing semicolon
- Variable name collision
- Minor improvements in caching (in a few places "var $that" cached $(this), but wasn't actually used)
- Replace calls to deprecated $j with $
- Checking undefined by strictly comparing references instead of a string comparison and typeof (speed)

(see bug 29106)
2011-06-06 23:18:13 +00:00
Roan Kattouw 63e9d0ff85 WikiEditor: (bug 27698) Toolbar height isn't updated in all code paths of addToToolbar(), causes toolbar to overlap part of the edit box if certain race conditions happen. Patch by Salvatore Ingala 2011-05-13 14:34:43 +00:00
Leo Koppelkamm 57721bd94e Followup to r86108 per CR: Fix two calls to legacy tablesorter 2011-04-30 18:58:17 +00:00
Jan Paul Posma 6e998359f0 Fixes bug 24088: WikiEditor toolbar RTL icons 2011-04-25 12:26:20 +00:00
Jan Paul Posma 4c8f157f1a Fixes bug 28149 (but with default to true) 2011-04-22 12:10:18 +00:00
Roan Kattouw fad3b6568b (bug 22209, bug 22574) Make indent, bullet list and numbered list buttons in the WikiEditor toolbar act on each line individually
* Reintroduce support for the splitlines argument in encapsulateSelection(). Was implemented by Adam Miller in r61493 but got lost somehow
* Add 'splitlines': true for the bullet list and numbered list buttons. The indent button already had it, so that part of r61493 did survive
* Copy options.pre and options.post to local pre and post variables instead of using (and modifying!) them directly all over the place
2011-04-21 13:42:39 +00:00
Leo Koppelkamm 724dccc131 Fix jumping of textbox in link-dialog. This happened when the link was being checked and the too large spinner image pushed the field down 2011-04-21 08:59:13 +00:00
Marcin Cieślak e8625d2726 Additonal pair of quotes in the enhanced edit toolbar
Some langages (Croatian, Hungarian, Polish, Romanian, Serbian)
use DOUBLE LOW-9 QUOTATION MARK (U+201E) and 
RIGHT DOUBLE QUOTATION MARK (U+201D) in marking up
quotes. For more details, see:

http://en.wikipedia.org/wiki/Quotation_mark,_non-English_usage
2011-04-04 23:06:47 +00:00
Derk-Jan Hartman d0b6d276cf Because this element has margins, the scrollWidth will be larger by definition, causing the box to continiously grow in size when opening it multiple times.
Fixes bug 27566
2011-03-28 21:11:17 +00:00
Michael Dale 203a9133a2 removed addMediaWizard gadget ( should be supported via dedicated extension 'AddMediaWizard' ) 2011-03-11 21:42:03 +00:00
Jan Paul Posma 9df5838aa5 Fixes bug when having multiple textareas, which is caused by the fact that dialogs are kept in memory for performance, even when selecting a different textarea. 2011-02-27 17:14:01 +00:00
Jan Paul Posma 9d6f6e3526 1. Re-introduces check if the browser supports the dialogs, which was removed for no apparent reason in r74276.
2. Makes the isEnabled function public, to allow other extensions to use the same configuration settings as WikiEditor.
2011-02-25 00:01:57 +00:00
Jan Paul Posma 8ca58dd46b A bit of a reorganisation that fixes bug 27164. Basically the extensive configuration in the ext.wikieditor.* functions is moved to the jquery plugins, to be able to use these configurations in other extensions which don't have a #wpTextbox1.
Please review this to check if this is the right way to do it!
2011-02-24 01:45:55 +00:00
Roan Kattouw ee3a8e68b0 WikiEditor: Add missing message and shut up a source of JS errors 2011-02-23 20:50:52 +00:00
Max Semenik dcebf90c7c WikiEditor: removed duplicate Hebrew characters. Reported on IRC by Yair Rand. 2011-02-21 15:35:01 +00:00
Roan Kattouw 7464078c73 (bug 27502) Monospace text too small 2011-02-19 15:02:14 +00:00
Roan Kattouw 9eaa77a549 WikiEditor: Use wgExtensionAssetsPath instead of wgScriptPath + '/extensions' 2011-02-16 14:52:34 +00:00
Roan Kattouw b7f45b1e01 WikiEditor: Add some var statements to code introduced in r74271 2011-02-08 07:04:12 +00:00
Roan Kattouw 94c2e2f19d WikiEditor: Fix usage of $.client 2011-02-07 21:59:01 +00:00
Brion Vibber 9021930871 * (bug 26975) Regression fix for search-and-replace in WikiEditor
string_instance.escapeRE() -> $.escapeRE(string_instance)
2011-02-07 21:46:25 +00:00
Trevor Parscal 541af6f940 Changed how namespace is injected into gallery and file example messages. We don't have template processing on the client (yet) so this will work for now. 2011-01-13 00:58:32 +00:00
Trevor Parscal 9cff4eb684 Removed ad-hoc rtl rules - CSSJanus out of the box is doing just fine. 2011-01-12 00:06:57 +00:00
Trevor Parscal 2c4ea9d393 Improved on r79973 re-resolves #25724 after #80057 re-broke it. Aparently Opera was choking on, and ignoring the following CSS rule after, a CSS rule that ended in "background-image: url(some url here) !important;" Removing the "!important" part fixed the problem, and in this case it didn't seem to be needed anyways. So much for unicorn tears... 2011-01-11 23:55:39 +00:00