Commit graph

25 commits

Author SHA1 Message Date
Ed Sanders 7eed707a48 Replace jshint/jscs with eslint/stylelint
Change-Id: Ife5e782bd5513e0496e384655b9b203de5c841a5
2016-11-21 21:02:38 +00:00
Fomafix fe7e2a790c Load module 'mediawiki.diff.styles' on show changes
The loading of the diff styles get lost in 6627f2cd.

In MediaWiki 1.28 the name of the module was renamed from
'mediawiki.action.history.diff' to 'mediawiki.diff.styles'.

Bug: T142845
Change-Id: I86ed2a0568c6bc4e81819633a295cec2e8924215
2016-09-26 21:29:14 +02:00
Derk-Jan Hartman 6627f2cd94 Small side-by-side preview improvements
- load jsconfigvars
- trigger the hooks for wikipage.content and wikipage.diff
- rvdifftotextpst for diffs
- improve section support

This module is not used within WMF, but has some users amongst 3rd
parties.

Change-Id: I7f0b2de4a984d811ccd94149670390929a6182f6
2016-04-16 00:34:05 +02:00
Ramunas Geciauskas ddda9c0c13 Fix spelling mistakes and clarify code comments
No functional changes

Change-Id: I395f97640931d7902cb468d62187d6d8fd10c0b7
2016-03-31 10:28:32 -04:00
Fomafix d7d2b65487 Use formatversion=2 for API request
With formatversion=2 the JSON response uses UTF-8 instead of escape sequence
with hex for encoding of non-ASCII characters (e.g. "\u00e4" for "ä").

The JSON response from formatversion=2 has some structural improvements.
This allows a simplification of the processing of the response.
The parameter indexpageids= is not necessary anymore.

Change-Id: Ic08c8ba46b7529952c0fb2f04564b458b55112fd
2016-02-08 11:49:17 +00:00
paladox bdb67f719c build: Test JS code with jshint and jscs via npm
Change-Id: I039bc4c17fbba3c74a5050066b20af05434ca482
2015-11-18 12:06:36 +00:00
Timo Tijhof c4a6039f8c Remove use of deprecated 'modulemessages'
Deprecated as of MediaWiki 1.26, replaced with an empty array.

Change-Id: Ic5f308060f796b896f98de34e153bb8bd11f8e6c
2015-09-24 18:01:24 +01:00
Fomafix 77fca50876 Use mw.Api() instead of $.ajax()
Add dependency to the already used module 'mediawiki.api'.

Change-Id: I236b3be5f64ac92f6710e5c690b0cc1800ceb1c5
2015-01-07 18:25:47 +00:00
Derk-Jan Hartman 4af678cdd2 Preview: Add content clears after side-by-side preview
Change-Id: Ib6147e38aa98a5498300513da3557ce74af1252d
2014-11-10 21:02:43 +01:00
Timo Tijhof d0ebd8f812 jquery.wikiEditor.preview: Clean up
* Rename 'collection' to 'loadmodules'.
* Consistently close parentheses and brackets at the same
  indentation level as they were opened.
* Use $.ajax directly instead of $.post, especially the fourth
  argument to $.post makes it hard to read.
* Use promise interface of $.ajax and $.post instead of the
  (deprecated) callback parameter.

Change-Id: I48924c9a1ce29829f8994be05c46d5563b2c25d6
2014-05-04 15:52:04 +02:00
Derk-Jan Hartman 0be6642d42 WikiEditor: Make JS preview load required modules
Change-Id: I5cc3c8577ab088eeba9e6f4ac78411c31ee38fa9
2014-05-04 14:27:04 +02:00
Derk-Jan Hartman 4936de4f3c WikiEditor: Fix API warning in preview requests
Change-Id: I8e8b344da2c39dfc107525561078947708c75868
2014-05-04 13:42:07 +02:00
Derk-Jan Hartman 36588027e5 Fix infinite spinner in JS version of show changes
Empty content causes the hiding of the spinner to be skipped.

Bug: 38502
Change-Id: Iefb224877976d463a5bb7b92a8e09fe958cd16c2
2014-04-07 18:52:19 +02:00
Timo Tijhof 1a2daca06a Kranitor: Make JSHint pass
eqeqeq:
* Change loose comparisons to strict comparisons where
  it seems safe to use a strict comparision instead.
  Mostly comparisons to strings or objects, and comparisons to
  numbers where the other value is known to be a number, too.
  E.g. foo == 'string', bar == node, indexOf() != -1.
* Add eqeqeq:false to files where there are non-obvious usages
  left.

onevar, quotmark:
* Disabled in files with lots of style violations.

unused:
* Remove unused variables that have no side-effects in their
  assigned expression.

Coding style cleanups on affected lines where trivial.

Change-Id: I5db155a632740e24cb52dba2177c7fc35d5aebd5
2013-11-10 07:36:03 +00:00
Timo Tijhof 7721909f9f WikiEditor: Linting and conventions
* Code clean up in preparation for enabling linting in the future

* Update code to use latest code conventions and best practices:
 - Make use of jQuery.Event (e.g. no need to check both e.keyCode
   and e.which)
 - jQuery: .size() -> .length
 - jQuery: (where appropiate) .attr() -> .prop()
   Setting properties like 'checked' via attr() has been deprecated
   in jQuery.
 - Whitespace
 - Single quotes instead of double quotes
 - Use literal keys in object literals instead of strings
 - Pass mediaWiki to closure, use mw. locally instead of "mediaWiki"
   global directly.
 - Fix indentation
 - Brackets around if, else and for bodies
 - Strict comparison to 0, null, false, true etc.
 - Fix missing radix parameter in parseInt
 - Use local $ instead of global $
 - Use `foo || bar` instead of `foo ? foo : bar`
 - Variable scope hoisting
 - Double/redundant variable declarations
 - ['foo'] is better written in dot notation
 - New line at EOF
 - Consistency in jQuery construction:
   Tag name for element creation $( '<div>' )
   Valid html for html parsing $( '<div foo="bar"></div>' )
 - Fix regex escape warnings per JSLint/JSHint.
   Do escape ][, don't escape ><
 - ..

* Add .jshintrc / .jshintignore

* Updated most files, but not all. Too much at once.

Change-Id: I445639b25a9688b3cdf9e5449e3d31cbcfa9c7ae
2012-07-17 13:27:27 -07:00
Siebrand Mazeland cc71ec5354 * bump version to 0.3.1
* stylize.php
2011-09-13 08:56:32 +00:00
Leo Koppelkamm fb2ee48521 r91740: Updating module name in extensions 2011-07-08 18:00:38 +00:00
Derk-Jan Hartman e7132c5323 * Fix broken post call to api in side-to-side diffs
* Fix support for side-to-side diffs in section editing

Reported in bug 29106. Patch by Michael M.
2011-07-02 08:46:50 +00:00
Mark A. Hershberger b18069c06a Bug #29106: Patch from Michael M. to address JS legacy globals in wikiEditor 2011-06-26 19:25:27 +00:00
Trevor Parscal bb88f087b4 Mostly reverted r75487, making use of a new version of mediaWiki.msg. 2010-10-27 00:16:32 +00:00
Trevor Parscal 55a8f66322 Updated use of mediaWiki.msg to mediaWiki.message 2010-10-26 23:42:23 +00:00
Trevor Parscal da918a5d68 Made use of mediaWiki.loader for adding in mediawiki.legacy.diff for the change tab of jquery.wikiEditor.preview 2010-10-05 22:06:16 +00:00
Trevor Parscal 0fd0380e20 Fixed bug that made preview not work with textarea. Also discontinued use of some globals. 2010-09-17 23:58:41 +00:00
Trevor Parscal a9c45c88e0 Lots of refactoring. This still does not work! But it's getting close. 2010-09-15 22:40:50 +00:00
Trevor Parscal 9d278e8dee Copied over all the resources needed to make WikiEditor stand on it's own two feet. Lots more to do as far as organizing and fleshing out the extensions's PHP bits. 2010-09-15 03:08:35 +00:00