Commit graph

43 commits

Author SHA1 Message Date
Ed Sanders 1d20fd47a3 Remove $controls / $tabs / $buttons interfaces
Bug: T380034
Change-Id: I041ae16f5916a51697aabd1a31d6f7fbc051b8e4
2024-12-04 12:48:57 +00:00
Ed Sanders 5e73c18eb1 Follow-up Ib536b51: Remove wikieditor-toolbar-tool-link-int-invalid, unused
Change-Id: Iab5491e098b15268e3017f931d49a0d7dd69d818
2023-11-03 13:36:40 -04:00
Ed Sanders c3b77c004b Follow-up Ib66025d: Remove unused message keys
Change-Id: If92c408f94473d1a138e77105ef4946edb393f40
2023-11-03 13:25:30 -04:00
Ed Sanders 0fe46f50c0 Delete messages from real-time preview beta feture/onboarding
These were orphaned in I8d05e143858.

Change-Id: I602d2e83d5886a832ba20a59f9a8a48b073ead3f
2023-11-02 18:41:24 +00:00
Jon Harald Søby 499c71114a Stop using autoMsg and use mw.messages directly instead
WikiEditor has a clever functionality where you can enter a message
key directly by using [key]Msg syntax in the object definition. While
that may have been a clever approach, it led to tons of messages
in this extension having to be marked as RawHtmlMessages because
they could potentially be parsed as HTML. Thus I am replacing all
of these instances with using mw.message explicitly instead, with
the necessary method attached.

The autoMsg (and its cloned autoSafeMsg) functions have had FIXME
comments attached since 2018 saying that these methods are
unnecessarily complex and should be replaced with using mw.messages
directly.

This solves a lot of problems for translators in Translatewiki, and
hopefully makes the code more straightforward and easier to understand
for those reading it down the line.

I would like to remove the autoMsg and autoSafeMsg functions
altogether, but their functionality is still in use in a few
extensions (and potentially on-wiki code), so we would have to
clean up that first.

Bug: T154891
Bug: T294760
Change-Id: I2835341867df85552579ea6927cd39a6f889fa6b
2023-07-06 10:39:24 +02:00
Jon Harald Søby 5c18abff00 Move reference-specific settings to the Cite extension
These config settings were specific to the Cite extension,
and are misleading on wikis that don't have that extension
installed. Move the functionality to the Cite extension
instead.

Bug: T339973
Depends-On: Ib3fdc897dd3330f69c5832003d4c3cb1e6dba2f3
Change-Id: Ib619706ddfca724990e1db2d51f12a2eb05f6a72
2023-06-22 14:07:29 +02:00
Sam Wilson 4ff946aea4 Realtime Preview onboarding popup
Add a pulsating blue dot to the Realtime Preview toolbar button
that displays an onboarding popup when clicked and disappears
forever when dismissed.

Bug: T294589
Change-Id: I7f4dd0858349b0e7c4f4bedea5c7a62a51c6fa3a
2022-06-01 14:11:49 +08:00
Thiemo Kreuz 7573a7dbad Remove all unused "loading" code, messages and animations
The CSS was already unused when the extension was created in 2010.
A comment that still mentioned the CSS class was removed via
I0798864 in 2022.

The message is unused since I9fb7e66, that was in 2021.

Change-Id: I25cd31efc4ee61ff3f857c280b5cd18c3ae4bd00
2022-04-21 15:29:15 +02:00
Sam Wilson 4c760f8634 Realtime Preview: display manual-reload bar when previews are slow
After three slow preview requests, switch to showing a bar at the
top of the preview area that contains a manual 'reload' button.

The manual bar will be hidden when an error message is show, but
re-shown again after the error is dismissed. Closing and
re-opening the preview pane doesn't reset the manual mode.

Bug: T304568
Change-Id: Ia72bd1ceab68fdaed5de53137bd8ac5961db4714
2022-04-20 13:01:14 +08:00
Sam Wilson 94d4912103 Realtime Preview: add hover button for reloading
Add a 'reload' button to the right-side preview pane (that shows
on hover, and stays in the same place when the preview is
scrolled), and also an accesskey to trigger the preview. If the
preview is not open when the accesskey is pressed, it'll be
opened.

Bug: T303532
Change-Id: Ifa77ad7cf6d2ed6a8b955f9a324986d1c6f9a993
2022-04-14 08:08:58 +08:00
MusikAnimal b8bdd64ee5 Realtime Preview: add as a Beta Feature
For MW installations where BetaFeatures is not available, Realtime
Preview is enabled solely with the $wgWikiEditorRealtimePreview
configuration setting.

Bug: T304596
Change-Id: I880022883bf526a2aef237f4a75e790b0f9bd4e5
2022-04-06 13:45:44 -04:00
Sam Wilson 6175e2c519 Add nicer realtime preview error messages
Add a new ErrorLayout to display error messages along with an
image.

Bug: T303383
Change-Id: I1ec27a212b5ab67d3e805c0d7756432850de89ea
2022-03-24 14:56:19 +08:00
Sam Wilson 411be83bc3 Add toggle button and two-pane layout for realtime preview
* Toolbar button to toggle a two-pane layout on and off.
* Resizable bar for the width of the two panes.
* Resizable bar for the edit box height, even when realtime preview is off.
* Only enabled when $wgWikiEditorRealtimePreview = true.
* Fires JS hooks when enabled, resized, and disabled.

Bug: T293347
Change-Id: Id09d44519249c0b7f5c33d48d524b7c92a5a9106
2022-03-13 07:28:01 +08:00
Sam Wilson 2aa9e1d298 Remove unused messages and commented-out code
It looks like `wikieditor-loading` was already commented out in 2010:
9d278e8dee%5E!/#F114
and I couldn't find any usage of `wikieditor-toolbar-loading`.

Change-Id: I07988643ca502dcbd7c3208fb803a84003947d5e
2022-03-02 02:40:05 +00:00
Ed Sanders b4f144057e Tag WikiEditor edits with a hidden tag
Bug: T249038
Change-Id: Ia4267bc430ba0f12cce496ebf6f8c1773ae355a6
2021-12-07 23:30:27 +00:00
Sam Wilson 79a0d3040e Disable link-insert button if target is empty
Set the opening state of the insertion button (in the insert-link
dialog) to disabled, and also disable it whenever the target field
is empty. This makes it unneccessary to show an alert when trying
to insert a blank target so that code is removed.

Bug: T293167
Change-Id: I3541f438fad9b7e0bf23ead2f2e164e84565d254
2021-11-26 12:45:48 +08:00
Amir E. Aharoni 675dfe18c6 Fix comma splice in a message
Change-Id: Ia851143a4febdcc2d520214d52c9514f932b9dbf
2021-10-09 14:55:43 +03:00
Sam Wilson 6384498d75 Switch to OOUI TitleInputWidget for the link-inserter
In order to get a better look-up experience (images, description,
redirects, and disambigutation pages listed last), swich from
a custom title-autocomplete input (that used jquery.suggestions)
to OOUI's standard one (which is used in a bunch of other places
in MediaWiki).

This means a fair bit of code can be deleted from
jquery.wikiEditor.dialogs.config.js, and some of it moved to
the new OOUI classes.

This patch aims to be the minimum required, and so leaves a few
things for subsequent patches (such as converting the other parts
of the insert-link dialog to OOUI).

Bug: T289214
Change-Id: I9fb7e66bf925eb9a8260d6245d2a7db54a7a2fec
2021-10-08 12:43:55 +00:00
Ammar Abdulhamid ab287ade14 Allow specifying alt-text in File dialog
* Also add expandable help message to explain the alt text field

Bug: T260006
Change-Id: If16ff742d7a8dee4917884e73e9c95bf76350773
2021-01-22 21:37:17 +01:00
pcoombe a822d1c197 Add caption when inserting table
Data tables should always include a caption for accessibility reasons.
So add a placeholder caption when using the "insert table" button.

Bug: T252350
Change-Id: I6773e2274007946de516ae34e841f66ad20ebc0c
2020-05-11 11:09:23 +01:00
Alexander Jones 884991e4a0 Localize numbers before passing to mw.msg
This commit localizes numbers before passing to mw.msg. This occurs
in two places, the successful replacement count and the error message
where too many cells are used in the table tool. The comment above the
second call was not correct, as the existing message used a substitution.

Bug: T244812
Change-Id: I00f83bd478bc42cb536edceba2bcc9daf0b13b3d
2020-03-27 14:04:27 +00:00
Bartosz Dziewoński 1ec89c8729 Adjust file/image button tooltip to match VisualEditor
Bug: T223775
Change-Id: Id72c6fbcc18eeceb8ae63f988cac4a398554f541
2019-10-31 23:11:50 +01:00
Derk-Jan Hartman f501cdc9c6 Search: Add option to search whole words
Bug: T24478
Change-Id: Idb47ac392b0f8b1425053c6916db8f25c11c9762
2019-05-15 22:03:54 +02:00
James D. Forrester 169d38fa75 Re-label preference now that the 2006 wikitext editor doesn't exist
Add the secondary label in a 'help' note to make it easier to identify
the different editors.

Bug: T32795
Change-Id: I6d17359166f58811ba99893ce4a4500a87deb827
2018-10-25 14:33:31 -07:00
James D. Forrester be36244c70 Radically simplify this extension now there's only one config option
On or off. Pick your apples.

Change-Id: I7677f0b597c33f236192aea1aaa347a36216fbb7
2018-01-02 21:25:16 +00:00
James D. Forrester 77cea2697c Drop the never-finished "Labs" publish and preview features
These features were ideas in the Usability Initiative but were never
finished to the level that they would be deployed on Wikimedia wikis
and have been marked as "going to be removed" for years. Now is time
to act on that promise.

Change-Id: Ia1eb91d2dfb1979518d97badc1477146b4606f7c
2018-01-02 21:00:44 +00:00
Ed Sanders 781504057a Make toolbar and dialog part of the core module
Bug: T163793
Change-Id: Ia6d02b51d4e04f148d836827640ff132366c4bee
2017-05-03 11:54:23 -07:00
Derk-Jan Hartman 95ab425166 Remove non-working {{#special:mypage}} from help
Bug: T44107
Change-Id: Iff987eddfb1fbe6a6ce1c88795b9dc1fd5b47f9e
2015-12-25 20:28:43 +00:00
Prateek Saxena 5ea5952cd1 Use mw.Upload.Dialog to upload and insert file
Bug: T115748
Change-Id: I2427cd959f0d9b6872866e120e7bd0e7e298ec27
2015-10-23 16:54:24 +00:00
Siebrand Mazeland 53cde9093c Update indentation to use tabs
Change-Id: Ie862e8cd093f05f7e4faee41dca6c16bb5b8e4ae
2015-10-12 11:30:33 +02:00
This, that and the other 52d3e279a1 Replace hidesig module with a more robust implementation
Per T42972, the current hidesig implementation is broken, and only
hides the signature button in namespace 0 regardless of the value of
$wgContentNamespaces.

Seeing as the old implementation of hidesig was broken, I don't really
think backward compatibility with old configurations is a useful
concern here. In particular, hiding of the signature button is no longer
able to be configured in Special:Preferences (why such a trivial pref was
ever able to be exposed to users, I don't know).

Bug: T59727
Change-Id: I596fd435bc9be8c37da43177c1bea90ebff0b2fe
2015-08-05 13:59:00 +10:00
Schnark 27353c44b7 WikiEditor: Improve help section
* Internal links: Show simple example first
* References: Show use of unnamed references
* Discussion: Use --~~~~ for consistency with what the toolbar button inserts

Bug: T26128
Change-Id: I08de0ad416727447eccad914c2ade3a93e5a8ae2
2015-07-20 07:42:35 +00:00
Nemo bis a5bf9a0dca Actually use the parameter in wikieditor-toolbar-tool-table-toomany
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Wikieditor-toolbar-tool-table-toomany/ksh

Change-Id: Ibe8aaec4e5a2cd5986074ab4c5314af1c58c1041
2015-05-23 14:33:31 +02:00
Alex Monk fb4f71a46b Move WikiEditor's special character data and messages out to core
Core part done in If9c5cdbe

Bug: T91608
Change-Id: Ifd0ed245ca9d1209b3dad5334f3fcfca428ceeec
2015-03-27 22:46:24 +00:00
Fomafix 5c36a20623 Move hardcoded parsed thumbnail html from i18n to config
Also update the actual HTML with what the current parser outputs:
* width:104px -> width:102px (2px in addition to 100px image width)
* No more "title" attribute on the outer <a>.

And reduce duplication in the message:
* Re-use "thumbnail-more" message.
* Re-use "wikieditor-toolbar-help-content-file-caption" message.

Change-Id: I25f0763b2274ebdcf681c78af277a9be302350a1
2015-03-14 20:41:11 +01:00
Fomafix a42f39dd7f Replace 104px by 102px for width of thumbnail div
[[File:Example.png|thumb|100px]]
generates a surrounding div with a width of 102px.

Change-Id: Ie2eb46452de607b83abb5f61af5782dedbf7aa84
2015-03-14 18:19:30 +00:00
Derk-Jan Hartman 2946fcd56d Remove reference to magnify-clip.png
magnify-clip.png was recently removed from the core styles directory,
but the Help panel of the WikiEditor still references it by way of i18n
message: wikieditor-toolbar-help-content-file-result

Also remove unused local copy

Bug: T85920
Change-Id: Icc17092c0f854360b2f2999b8f153827bf194c0c
2015-01-07 10:19:35 +01:00
Derk-Jan Hartman 3e04196b79 Toolbar help: Make magic word from help string a param
Instead of having this magic word in the translation message, make it a
parameter of the translation message and retrieve it from
wgWikiEditorMagicWords.

Bug: T40831
Change-Id: Id3155221aa61bc86da2d90000dedab36cbe9dd96
2014-12-08 12:22:49 +01:00
Derk-Jan Hartman 360419f397 Remove previewDialog
This was never launched, and is no longer working either.

Change-Id: Ic49e84b8a91da701673949a8d441c788a4feaa22
2014-11-30 20:25:22 +01:00
Thiemo Mättig ed348c489f Remove optional namespace prefixes from <gallery> example
The namespace is optional since at least 2011, see
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/79639

More and more wikis switch to the syntax without repeating the
namespace over and over again. Main advantage: This avoids all
discussions which alias (localized or what) should be used.
Example discussion:
https://de.wikipedia.org/wiki/WP:VV#Erweiterte_Bearbeiten-Werkzeugleiste_-_Bildgalerie_einf.C3.BCgen

This change keeps the parameter in the JavaScript so it still can
be used in local translations and existing local translations don't
trick users into inserting $1's into the edit window.

Change-Id: I31826d1a3db51f22f46ae469864a23d7c8298e09
2014-06-03 20:06:04 +02:00
Derk-Jan Hartman e53521b32b WikiEditor: Remove unmaintained template editor modules
Change-Id: I47119d6cfdde4b40ff5b07be0c7d327b80598142
2014-04-03 17:11:10 +02:00
Derk-Jan Hartman 9bb94e8319 WikiEditor: Remove old unmaintained ToC module
Change-Id: I0f53a68e50fc950d7f407ee81b2bf0d81ef4948d
2014-04-03 17:02:32 +02:00
Siebrand Mazeland 11f0e1ab32 Migrate to JSON i18n
Procedure per https://www.mediawiki.org/wiki/Manual:GenerateJsonI18n.php
with shim.

Change-Id: Id90e104793d3ca8243d0ef918b9bc91cf474c36d
2014-03-29 17:14:05 +01:00