Commit graph

2969 commits

Author SHA1 Message Date
Alex Monk 2b914eeddf Don't try to do event logging if we don't have a stats ID
I found that pages like:
https://pl.wikipedia.org/w/index.php?title=Wikipedia:Strona_g%C5%82%C3%B3wna&action=edit
which load WE dynamically don't have this.

Change-Id: Ib3952f4efbf265dbb0d1e25b2059e1be934565a7
2015-03-20 01:26:31 +00:00
Alex Monk bf15f72dc7 Try to prevent crazy EventLogging entries with no session ID etc.
Seems to be causing errors on view (!) on plwiki, and I would not expect this
to work on non-wikitext pages.

Bug: T93242
Change-Id: I0336a85a2ab4bef1d20086382012047688ffa909
2015-03-19 21:29:57 +00:00
jenkins-bot 262a2b22d7 Merge "Only do client-side instrumentation on action=edit/action=submit" 2015-03-19 21:29:16 +00:00
Translation updater bot 0953d69223 Localisation updates from https://translatewiki.net.
Change-Id: Ic24ba9100a40ff787d8a7ecda362b6f692e4090b
2015-03-19 21:18:13 +01:00
Alex Monk 4d54fa4471 Only do client-side instrumentation on action=edit/action=submit
So we don't break the tests

Bug: T93119
Change-Id: Ib0545f581fd2a845b893a046ab7aa7161e27180e
2015-03-18 23:59:24 +00:00
Alex Monk e19968d4e1 Fix WebRequest::getVal calls for instrumentation
As it actually defaults to either null or (string)$default, not $default.
So therefore getVal( 'key', false ) will never return false, even if 'key' is
not set.

Change-Id: Ibe6beae9d2c4a19ff59d1035564f17373298529d
2015-03-18 19:40:30 +00:00
Translation updater bot 9d2092b25c Localisation updates from https://translatewiki.net.
Change-Id: I36bc6f77f65ddfb313f8612bdfbb22555d064aae
2015-03-18 16:09:23 +01:00
Translation updater bot 1ab97a76c0 Localisation updates from https://translatewiki.net.
Change-Id: I9ad9ed728f4232854bf83eacf9e02ddd0420d74b
2015-03-16 22:02:01 +01:00
jenkins-bot 49524147a8 Merge "Insert link: trim whitespace from the external link" 2015-03-16 10:59:28 +00:00
Kunal Mehta 11781784de Revert making installable via composer (and add composer test entry point)
This reverts b8abb9b5f2 (a self-merged "experiment") and
1bb0ea4f76 (Convert entry point to use explicit globals).

The maintainers of this extension do not plan on supporting installation
via composer. This functionality was never included in a stable release
branch, and should not break anyone sticking to stable
branches.

Once merged, I can remove the package from packagist.org

The composer.json is now used to add a "composer test" entry point to run
PHPCS, which this extension badly needs.

Change-Id: I2f3db6addd883d94366a696d5185bf05b2695b11
2015-03-15 18:01:50 -07:00
Derk-Jan Hartman 1514d166e0 Insert link: trim whitespace from the external link
Bug: T25499
Change-Id: I2392ade17d3d4428784c40dabf9ae5e216fbab47
2015-03-16 00:16:13 +01:00
Translation updater bot 2c3fe04ce1 Localisation updates from https://translatewiki.net.
Change-Id: I9b60dacf88bd700e5c46ff98597d27ee66e486fc
2015-03-15 21:54:59 +01:00
jenkins-bot 789bb7c7d3 Merge "Move hardcoded parsed thumbnail html from i18n to config" 2015-03-15 11:32:29 +00:00
Translation updater bot 0bc60008e8 Localisation updates from https://translatewiki.net.
Change-Id: Id0c176f18078629d6c9a7162c3393fbfceff360d
2015-03-14 21:38:29 +01:00
Fomafix 5c36a20623 Move hardcoded parsed thumbnail html from i18n to config
Also update the actual HTML with what the current parser outputs:
* width:104px -> width:102px (2px in addition to 100px image width)
* No more "title" attribute on the outer <a>.

And reduce duplication in the message:
* Re-use "thumbnail-more" message.
* Re-use "wikieditor-toolbar-help-content-file-caption" message.

Change-Id: I25f0763b2274ebdcf681c78af277a9be302350a1
2015-03-14 20:41:11 +01:00
Fomafix a42f39dd7f Replace 104px by 102px for width of thumbnail div
[[File:Example.png|thumb|100px]]
generates a surrounding div with a width of 102px.

Change-Id: Ie2eb46452de607b83abb5f61af5782dedbf7aa84
2015-03-14 18:19:30 +00:00
Tiziano Müller 51f3d145bc Reformat the license warning only if available
If the WikiEditor is enabled for Semantic Forms Text Area Input there is
no license warning div around.

Change-Id: I8d39f8d47a73cdc2d4be198061e8f68f22c0c308
2015-03-14 18:10:52 +00:00
Fomafix 83c079ceb6 Reuse variable profile instead of $.client.profile()
Change-Id: I66543bd0838b062bea08ca4b5f4fded41ff835cc
2015-03-14 18:01:58 +00:00
Fomafix d16dfb0ad5 Style code
* Fix errors and warnings from phpcs.
* Add commas at end of lines for arrays in PHP.
* Add space between // and comment.
* Add space between ) and {.
* Use tabs instead of spaces for indenting.
* Break lines in PHP with more than 100 characters.
* Remove double spaces and spaces at end of line.
* Remove spaces before comma.
* Fix some typos.

Change-Id: I9c014bdfa9832fa6a20d0190fe2fc668983d0fb9
2015-03-14 15:49:04 +00:00
Translation updater bot f691fbb8f2 Merge "Localisation updates from https://translatewiki.net." 2015-03-14 07:39:06 +00:00
Translation updater bot e57740f4b5 Localisation updates from https://translatewiki.net.
Change-Id: I6e7a8e6b7e04f5011d01251ff79d1730a9716caf
2015-03-14 08:38:05 +01:00
Alex Monk 1f1ec7d4b8 Don't try to log a boolean for page.revid
It won't work.

Change-Id: I9f1a34dcdada5cd33a212ed6cb01750ccfa7abfe
2015-03-13 23:44:05 +00:00
Alex Monk 6f5c181d6c Fix name of editingSessionId
Oops.

Change-Id: I332c49c3a0c4529c20ff7d5ffe5336054349340f
2015-03-13 23:19:12 +00:00
Alex Monk 1096e18a55 Default user.editCount to 0 in the Edit schema
Otherwise it will fail to validate for anonymous users (getEditCount returns null)
as it is a required field

Change-Id: I3d438cfde172b2598955773c4c22fc2d4a502f16
2015-03-13 23:13:10 +00:00
Translation updater bot f061205405 Localisation updates from https://translatewiki.net.
Change-Id: I1754068eea8005ec8d57f681620d5cd97e1fe27f
2015-03-12 21:32:46 +01:00
Alex Monk ef7c4ce2be Don't try to load edit schema if it's not installed
It would only be installed by the WikimediaEvents extension.

Change-Id: I0a1841ad7639765cedf6294d62104f9aedb36d83
2015-03-12 16:49:50 +00:00
Alex Monk 74da530f2d Schema:Edit instrumentation
Depends on Ib8612626

Bug: T88027
Change-Id: I67f1000d23cb257df29d5d4be8ae85764458e6c1
2015-03-10 14:56:45 +01:00
jenkins-bot caa4ef8d08 Merge "Convert .css to .less" 2015-03-10 04:47:32 +00:00
paladox 3f692d9e15 Convert .css to .less
* This patch convert .css to .less
* Semantic changes are avoided, but there are minor
  tweaks such as capitalization and ordering.

Change-Id: Iebff0f8e3d87bb792093a10d87f33540aca301d5
2015-03-09 21:24:23 -04:00
Translation updater bot 603873070e Localisation updates from https://translatewiki.net.
Change-Id: Ia51b9d428028ee2e23214626ca0f2462627a97cf
2015-03-09 22:11:34 +01:00
Translation updater bot 3e59317621 Localisation updates from https://translatewiki.net.
Change-Id: Ia344ed277bfa3977f8bb37d541384141e53ef8fa
2015-03-05 22:30:50 +01:00
Translation updater bot cf654b244b Localisation updates from https://translatewiki.net.
Change-Id: I57206b351b31c7e34207fb528b83fc5af19625a9
2015-03-01 22:11:07 +01:00
Translation updater bot 45737059ff Localisation updates from https://translatewiki.net.
Change-Id: Ie455978d0cccf4535665fb4fbd5eaa841000bf62
2015-02-26 21:41:02 +01:00
Translation updater bot 9a8bb8fd14 Localisation updates from https://translatewiki.net.
Change-Id: I48b32919060ee6642f3ccc4616b72a01bb31db76
2015-02-24 22:06:16 +01:00
Translation updater bot 814970bf85 Localisation updates from https://translatewiki.net.
Change-Id: I4da6998f955663360dddf7eacb62cdd956375048
2015-02-23 22:01:34 +01:00
jenkins-bot 82a290b452 Merge "Skip an old IE 8 bug workaround in WikiEditor on IE 11/Spartan" 2015-02-21 22:36:26 +00:00
Translation updater bot 631515a147 Merge "Localisation updates from https://translatewiki.net." 2015-02-19 21:13:17 +00:00
Translation updater bot 610291e0a1 Localisation updates from https://translatewiki.net.
Change-Id: I87cdd4a12b0b06e288199016833c2940ff153ef1
2015-02-19 22:12:40 +01:00
Brion Vibber ab2c7e3ce6 Skip an old IE 8 bug workaround in WikiEditor on IE 11/Spartan
An early version of WikiEditor added a workaround for a reported
bug with IE 8 where textarea scroll and selection state was lost
when the contents were modified.

This doesn't seem to be needed on modern versions of IE such as 11
and above and the newer 'Edge' HTML engine mode in Windows 10.

Actually, I can't reproduce it in Windows 7 or XP with IE 8 either
from the original bugs, but just in case it's needed on some particular
version that we don't know about I've only added a check for modern
IEs, which is already in use on other old-IE workarounds in the
module.

Bug: T88875
Change-Id: I25b667a8d8378c417441adee5d97571c71a1c8c7
2015-02-19 21:01:21 +00:00
Brion Vibber 4f8ad57aaf Enable search-replace dialog on IE 11+
The search-replace box in WikiEditor was blacklisted entirely from
MSIE, although it appears to work fine in IE 11 on Windows 8.1
and Windows 10 Tech Preview.

IE/Spartan team specifically requested a fix for this bug; looks like
it's an easy case of adjusting the blacklist with a version component...

(Note that in RTL the dialog positioning is bad, but that affects
other WikiEditor dialogs too.)

Bug: T88875
Change-Id: I4cf1eb76cc8a788cab233fe9ed04aaeba4af5725
2015-02-19 12:55:29 -08:00
Fomafix d67b50eeb5 Remove color overwrite for dialog header border bottom
This changes the color of the line under the hader of the dialog boxes
from #6bc8f3 to the default #aed0ea.
This difference is nearly not recognizable and it is not worth to overwrite
the default color.

Change-Id: I88580ab74fc158ec1a498fc489fbdd9cd5ba897a
2015-02-18 21:27:37 +00:00
Fomafix 6986f8dba8 Remove CSS definition for tables in dialogs
The only dialog with a table is the table creator dialog.
For this table a more specific definition exist in
jquery.wikiEditor.dialogs.config.css
These rules overwrite all here removed definitions except of
  wikiEditor-toolbar-dialog table { margin-top: 0.75em; }
Without this definition the margin-top slightly increase to the
definition from .wikitable with margin-top: 1em.

Change-Id: I0aab246db05cb4330287666f6a71b56d6b88b0af
2015-02-18 20:09:21 +00:00
Translation updater bot d7a7d55a62 Localisation updates from https://translatewiki.net.
Change-Id: Iba891ff193489f041446b80b08952be8e9601aee
2015-02-16 21:59:11 +01:00
Matthew Flaschen 736b94f827 Update autoMsg doc for plain call
* Reflect that we're now calling mw.message( ... ).plain()
* Remove vague statement about "may eventually become a wrapper for
  some kind of core MW functionality."

Change-Id: Ibe743162c1f72bb3977ec16e2ba4b023a66e3907
2015-02-14 22:32:35 -05:00
Translation updater bot e208d0f4b7 Localisation updates from https://translatewiki.net.
Change-Id: I4889a1106a0065721d03e0d22bbb7cc809f77246
2015-02-09 21:38:47 +01:00
jenkins-bot 51cc8a3d21 Merge "Move style from JavaScript to CSS" 2015-02-08 19:55:44 +00:00
jenkins-bot de5f3932b9 Merge "Allow a resizeable toolbar index" 2015-02-05 12:44:02 +00:00
Fomafix 78bdeffcc6 Use "obj.hasOwnProperty( prop )" instead of "prop in obj"
'constructor' in {}; // true
Object.prototype.hasOwnProperty( {}, 'constructor' ); // false

Bug: T86643
Change-Id: I4356608956d722dc086e6876a53fdd93435c6f0a
2015-02-05 13:34:03 +01:00
jenkins-bot d70fe376eb Merge "Use sprite as button icon where possible" 2015-02-05 12:25:11 +00:00
Fomafix da5c8abe9e Allow a resizeable toolbar index
Change-Id: I329a143e2ee0a21bee4a9b146c28e6e8df58d570
2015-01-29 08:45:08 +00:00