Commit graph

346 commits

Author SHA1 Message Date
Fomafix 5432a42d2d Use background-image instead of <img> for spinner
* Background images get embedded.

Change-Id: Iea1fb3db29b1eb8d5bff1b9b07a6c16145b9efc0
2017-05-05 19:09:37 +02:00
Ed Sanders 1b0bd60ee8 build: Update eslint to 0.4.0 and make pass
Change-Id: Ib0ac14fb53479eb964a5d51066661b4771b1f72e
2017-05-04 22:38:47 +00:00
jenkins-bot ecc01e9122 Merge "Explicit load module 'jquery.tablesorter' instead of use when loaded" 2017-04-27 13:04:51 +00:00
Fomafix 278ae63c04 Explicit load module 'jquery.tablesorter' instead of use when loaded
The module 'jquery.tablesorter' is already loaded a few lines above.
The previous situation depends on a race-condition of the function is called
or not.

Change-Id: If6777fcc7d9d49604eb78b6d233a32898fc82446
2017-04-27 13:50:23 +02:00
Fomafix 25d64833dd Remove workarounds for IE8
Since MediaWiki 1.27 JavaScript is disabled on Internet Explorer 8.

Bug: T123219
Change-Id: If8e36d5cf39531ca9c599131847f612d17c31166
2017-04-26 18:28:25 +02:00
jenkins-bot 983cd6f480 Merge "Replace deprecated jQuery.isArray with Array.isArray" 2017-04-26 16:12:50 +00:00
Fomafix 24ee938095 Replace deprecated jQuery.isArray with Array.isArray
jQuery.isArray was deprecated in jQuery 3.2.0. [1]

Array.isArray is part of ES5 and MediaWiki 1.29+ which ensures that
JavaScript is only used when the browser supports ES5. (T128115)

Performed using:
find . -type f -name \*.js -exec sed -i -e 's/\$\.isArray/Array.isArray/g' {} \;

[1] https://blog.jquery.com/2017/03/16/jquery-3-2-0-is-out/
[2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray#Browser_compatibility

Change-Id: Ia1a118fefb23761fe297647442f0a598a9488968
2017-04-26 16:04:51 +00:00
jenkins-bot 744dd98914 Merge "Fix deprecation warning since jQuery 3" 2017-04-17 20:58:19 +00:00
Amire80 677041ff59 Add Canadian Aboriginal characters to the special characters toolbar
Bug: T108626
Change-Id: I613e89a520f78bcf7b6640c3ed5b9f3cce351912
Depends-On: Ia337d42c6ef7f9645f1dd843ef0e7553857f6aa3
2017-04-17 14:23:26 +00:00
Fomafix 74229b1d25 Fix deprecation warning since jQuery 3
JQMIGRATE: Attribute selector with '#' must be quoted: a:not([href^=#])

Change-Id: I892d27fd5e1b7e4a8b495f295d95592f164f7003
2017-04-13 11:18:45 +02:00
Fomafix ebf4d28dfe Replace deprecated jQuery .bind() by .on()
jQuery .bind() is deprecated since jQuery 3.0.
https://api.jquery.com/bind/

Change-Id: Ibbcfbefe2983b2ed2e3b110518c16539cbb84d88
2017-03-24 08:51:58 +01:00
Fomafix bd133991ba Replace deprecated jQuery .unbind() by .off()
jQuery .unbind() is deprecated since jQuery 3.0.
https://api.jquery.com/unbind/

The deprecated jQuery .bind() was aready replaced by .on() in 7769baa5.

Change-Id: Ia03d7a26754cc26345d9551d740719c43f598995
2017-03-23 20:36:39 +01:00
Ed Sanders d4b3d2c87f build: Update stylelint to 0.4.1
Change-Id: I4f21c19a9b834fa5442df201c4d65c6184bcbd2c
2017-03-20 14:39:18 +00:00
Ed Sanders 9f7fcfd80e Follow-up Ife5e782bd: Syntax fixes
Change-Id: I0a9d68344b2e5ed5589d421525e6113b72476705
2017-01-09 13:43:42 -08:00
Timo Tijhof 7769baa56e Replace deprecated jQuery bind() and size()
> JQMIGRATE: jQuery.fn.bind() is deprecated
> JQMIGRATE: jQuery.fn.size() is deprecated; use the .length property

Note that bind() is not removed in v3, merely deprecated.
Even after the jQuery Migrate phase, it will continue to work.

size() was removed in v3 and works only during the Migrate phase.

https://api.jquery.com/size/
https://api.jquery.com/bind/
https://jquery.com/upgrade-guide/3.0/

Bug: T124742
Change-Id: I6bbd8f829ecf987228c6a5abd32c84e4e088a9bd
2016-11-21 18:23:50 -08:00
Ed Sanders 7eed707a48 Replace jshint/jscs with eslint/stylelint
Change-Id: Ife5e782bd5513e0496e384655b9b203de5c841a5
2016-11-21 21:02:38 +00:00
Bartosz Dziewoński eb3097759f Make Upload/Insert buttons in "Insert media" dialog less confusing
The "Upload" button is now displayed on the left side of the dialog,
which make it clear it's a "secondary" action. "Insert" is on the
right, like all jQuery UI buttons, and the primary action.

Unfortunately jQuery UI doesn't give us a lot of styling options for
buttons or dialogs, even this is a bit of a hack.

Bug: T135917
Change-Id: Ia64229b880653668c11787744c177f6c91900382
2016-11-02 16:56:37 +01:00
Fomafix fe7e2a790c Load module 'mediawiki.diff.styles' on show changes
The loading of the diff styles get lost in 6627f2cd.

In MediaWiki 1.28 the name of the module was renamed from
'mediawiki.action.history.diff' to 'mediawiki.diff.styles'.

Bug: T142845
Change-Id: I86ed2a0568c6bc4e81819633a295cec2e8924215
2016-09-26 21:29:14 +02:00
Derk-Jan Hartman 10583ec1a7 Avoid flash of content when hiding editHelp and the pipe separator
Bug: T120408
Change-Id: I651ea3d2b891ce347a51be9b3bc3e34351bc53dc
2016-05-25 11:26:13 +00:00
Derk-Jan Hartman 79a052dc5e Avoid reflow due to WikiEditor toolbar loading
This avoids part of the reflow that occurs when the WikiEditor has
finished loading it's toolbar, by reserving 33px above the textarea.

I will still reflow to uncollapse a Advanced or Help section of
course, but there is only so much we can do.

Bug: T125843
Change-Id: Ibadea803bdfde9f88cff082b043ed58a05ed75a9
2016-05-25 00:26:20 +02:00
Paladox f473a2bc36 Allow the signature wikitext to be overridden locally
Bug: T26191
Depends-On: I33de58e9729a51ae73a13853ffcfcbb2d2305111
Change-Id: I43f5bbaee007bbd038f2e118b3ffb8690753afb8
2016-05-18 00:43:15 +00:00
jenkins-bot d1bfcb7d5a Merge "Small side-by-side preview improvements" 2016-04-19 15:57:59 +00:00
Derk-Jan Hartman 6627f2cd94 Small side-by-side preview improvements
- load jsconfigvars
- trigger the hooks for wikipage.content and wikipage.diff
- rvdifftotextpst for diffs
- improve section support

This module is not used within WMF, but has some users amongst 3rd
parties.

Change-Id: I7f0b2de4a984d811ccd94149670390929a6182f6
2016-04-16 00:34:05 +02:00
Ed Sanders 785703b5c5 Add 'Greek extended' to special character list
Bug: T130535
Change-Id: I57634d14b8ada16bd00db0c0333c1fc87d2be28c
2016-04-14 19:58:51 +01:00
jenkins-bot c49eba0099 Merge "Fix spelling mistakes and clarify code comments" 2016-04-01 10:50:36 +00:00
Ramunas Geciauskas c277e3eeb6 Stop any other tab animations when clicking on the tab button
When quickly clicking on a tab (the same one or a different one) in the
toolbar the new animation is started immediately even though previously
triggered animations might still be running. This leads to potential
issues as reported in T106993 bug report.
Make sure to stop previous animation first before issuing a new one.
Additionally 'resize' trigger is under racing conditions when
expanding/collapsing tabs, and needs to be invoked explicitly on any
size-change event (cannot rely on the fact that the last issued animation
will trigger last).

Bug: T106993
Change-Id: I874dd7cb9f2fe96e3a6493508cbae4de56f7a6c0
2016-03-31 12:08:07 -04:00
Ramunas Geciauskas ddda9c0c13 Fix spelling mistakes and clarify code comments
No functional changes

Change-Id: I395f97640931d7902cb468d62187d6d8fd10c0b7
2016-03-31 10:28:32 -04:00
jenkins-bot a9aeec920d Merge "Revert "Compress PNGs with zopflipng"" 2016-02-28 00:29:33 +00:00
Legoktm c950e0a53f Revert "Compress PNGs with zopflipng"
This reverts commit f50c6d0bb7.

Change-Id: I62e486f949bf0940e109ae5b1dabe098cbcb4c67
2016-02-28 00:07:54 +00:00
Derk-Jan Hartman cfb3d25117 Only load a page/booklet once
Bug: T126138
Change-Id: Ib4b2b76b115026df12a7d9cc3c30b7559c2580e4
2016-02-22 23:21:21 +01:00
jenkins-bot c1acfd639f Merge "Remove loading spinner" 2016-02-21 21:11:23 +00:00
jenkins-bot a1184765e6 Merge "Use formatversion=2 for API request" 2016-02-21 20:59:39 +00:00
Fomafix ce96b0c72e Remove loading spinner
Since e8d37102 the loading spinner is not visible, because all actions
relating to it are in the same render step of the browser.

The loading occurs fast enough now, that we also don't want to show an
intermediate spinner.

Change-Id: Id2a3584deed2ecde807d8f354341dd6868b10009
2016-02-21 20:57:44 +00:00
Ori Livneh f50c6d0bb7 Compress PNGs with zopflipng
Zopfli is the most efficient DEFLATE compression algorithm, trading run-time
performance for file sizes that are typically 3-8% smaller than those produced
by zlib with the maximum compression setting. Its output is Deflate-compatible,
so no specialized decoder is needed.

This change was created by running zopflipng against all the PNG files in this
repository. The exact invocation was:

  git ls-files --exclude-per-directory=.gitignore -- '*.png' \|
    parallel zopflipng -m -y {} {} \;

Files which zopflipng was not able to compress more efficiently were left unmodified.

Bug: T127608
Change-Id: I56c6870e86f9b359fc8c025caf6917560ebb606b
2016-02-21 02:04:49 +00:00
Ori Livneh 77f5499cfc Compress PNGs with zopflipng
Zopfli is the most efficient DEFLATE compression algorithm, trading run-time
performance for file sizes that are typically 3-8% smaller than those produced
by zlib with the maximum compression setting. Its output is Deflate-compatible,
so no specialized decoder is needed.

This change was created by running zopflipng against all the PNG files in this
repository. The exact invocation was:

  git ls-files --exclude-per-directory=.gitignore -- '*.png' \|
    parallel zopflipng -m -y {} {} \;

Files which zopflipng was not able to compress more efficiently were left unmodified.

Bug: T127608
Change-Id: Ic0aa0017f97411a282b54d51217a019871a93433
2016-02-21 00:44:19 +00:00
Fomafix d7d2b65487 Use formatversion=2 for API request
With formatversion=2 the JSON response uses UTF-8 instead of escape sequence
with hex for encoding of non-ASCII characters (e.g. "\u00e4" for "ä").

The JSON response from formatversion=2 has some structural improvements.
This allows a simplification of the processing of the response.
The parameter indexpageids= is not necessary anymore.

Change-Id: Ic08c8ba46b7529952c0fb2f04564b458b55112fd
2016-02-08 11:49:17 +00:00
Fomafix 3d103f09b5 JavaScript: Use single quotes instead of double quotes for
strings

* This avoids escaping of double quotes.
* Exceptions: "''" and "'''"
* https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Quotes

Set "validateQuoteMarks": { "mark": "'", "escape": true } in .jscsrc
This tests for single quotes but allows double quotes to avoid escaping.

Change-Id: Ibd32a63c4c97a7ef8938c6d2dff83b952cfca43e
2016-02-07 18:22:06 +00:00
Fomafix 0b5c23d42b Use .prop() instead of .attr()/.removeAttr() for boolean HTML attributes
https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Pitfalls

Create elements according to
https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Creating_elements

Change-Id: I14a7f6e8d2c0a43b89d0d186398a4fea76b7d362
2016-02-07 14:22:56 +00:00
Fomafix 7d8b6a1ab6 Use boolean values for .prop() on boolean HTML attributes
.prop() expects a boolean value. .id() returns a boolean value.

Change-Id: If3dc6197f9dded92e99faeaa33e31dc937ebf66f
2016-01-15 12:43:37 +00:00
jenkins-bot 60d9feb204 Merge "Use background-image instead of <img> for toolbar icons" 2016-01-07 19:35:23 +00:00
jenkins-bot af564f288b Merge "Add format-bold-Iab image for lang ce" 2015-12-28 09:15:22 +00:00
jenkins-bot 6b6109e222 Merge "Use mw.Message#text() instead of plain() in wikiEditor.autoMsg()" 2015-12-28 08:42:09 +00:00
Paladox 38d28d5631 Add format-bold-Iab image for lang ce
Also use the icon for Chechen. Also requested by Bug: T119716

Add these icons for lang ce

png

https://commons.wikimedia.org/wiki/File:Toolbaricon_bold_%D3%80%D0%B0%D1%8C.png

svg

https://commons.wikimedia.org/wiki/File:Toolbaricon_bold_%D3%80%D0%B0%D1%8C.svg

This was requested at
https://ru.wikipedia.org/wiki/%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F:%D0%A4%D0%BE%D1%80%D1%83%D0%BC/%D0%A2%D0%B5%D1%85%D0%BD%D0%B8%D1%87%D0%B5%D1%81%D0%BA%D0%B8%D0%B9#.D0.9F.D0.B0.D0.BD.D0.B5.D0.BB.D1.8C

Bug: T119716
Change-Id: I4b41aa53138eae660ebeb9b1d9f6f547cfcca7a4
2015-12-27 20:54:23 +00:00
Timo Tijhof f583469ece Use mw.Message#text() instead of plain() in wikiEditor.autoMsg()
* Follows-up 6a73d06 by removing the hardcoded SITENAME regex.
* Follows-up 1b797b7f6a which introduced this regression in the first
  place. This is exactly the reason why mw.msg() defaults to format
  'text' instead of 'plain' without transformations.

Change-Id: I7f1b877710fb6baa45b83054d1e30a24979b37b4
2015-12-25 21:33:47 +01:00
Derk-Jan Hartman 95ab425166 Remove non-working {{#special:mypage}} from help
Bug: T44107
Change-Id: Iff987eddfb1fbe6a6ce1c88795b9dc1fd5b47f9e
2015-12-25 20:28:43 +00:00
Fomafix 19789d762b Use background-image instead of <img> for toolbar icons
Change-Id: I8af0e2c8585e8d9f6f72133953792eb88a176bcf
2015-12-22 13:36:36 +00:00
2nd-player 6a73d06932 Substitute {{SITENAME}} in the title of dialogs
Bug: T62695
Change-Id: I7e5378b37e66b8b35bb7b3aa2121eea3cbf1defd
2015-12-21 20:03:32 +00:00
Fomafix de74cc81f5 Use mw. instead of mediaWiki. in code
Change-Id: Ib7905bbbb8954cf8e268acac45e00ceba959b00b
2015-12-13 12:44:49 +00:00
Paladox bfc5e2a6bd Fix ie 8 support in js follows-up: I039bc4c17fbba3c74a5050066b20af05434ca482
Change-Id: Icfea4cedde88efb88307cbb1842edc8a17ebf83a
2015-11-25 10:32:05 +00:00
paladox bdb67f719c build: Test JS code with jshint and jscs via npm
Change-Id: I039bc4c17fbba3c74a5050066b20af05434ca482
2015-11-18 12:06:36 +00:00