* No features have a 'configurations' setting, nor can I see any
client-side code looking for any. Was triggering phpcs because of
the 'global $$configuration;' line, which didn't start with "$wg".
* Remove unused selenium tests that were also triggering phpcs.
* Add composer.lock and vendor/ to .gitignore
Change-Id: If06a08b6a7c232ac69f9dff569ffa3e1c93ff0c5
Seems to be causing errors on view (!) on plwiki, and I would not expect this
to work on non-wikitext pages.
Bug: T93242
Change-Id: I0336a85a2ab4bef1d20086382012047688ffa909
As it actually defaults to either null or (string)$default, not $default.
So therefore getVal( 'key', false ) will never return false, even if 'key' is
not set.
Change-Id: Ibe6beae9d2c4a19ff59d1035564f17373298529d
This reverts b8abb9b5f2 (a self-merged "experiment") and
1bb0ea4f76 (Convert entry point to use explicit globals).
The maintainers of this extension do not plan on supporting installation
via composer. This functionality was never included in a stable release
branch, and should not break anyone sticking to stable
branches.
Once merged, I can remove the package from packagist.org
The composer.json is now used to add a "composer test" entry point to run
PHPCS, which this extension badly needs.
Change-Id: I2f3db6addd883d94366a696d5185bf05b2695b11
Also update the actual HTML with what the current parser outputs:
* width:104px -> width:102px (2px in addition to 100px image width)
* No more "title" attribute on the outer <a>.
And reduce duplication in the message:
* Re-use "thumbnail-more" message.
* Re-use "wikieditor-toolbar-help-content-file-caption" message.
Change-Id: I25f0763b2274ebdcf681c78af277a9be302350a1
If the WikiEditor is enabled for Semantic Forms Text Area Input there is
no license warning div around.
Change-Id: I8d39f8d47a73cdc2d4be198061e8f68f22c0c308
* Fix errors and warnings from phpcs.
* Add commas at end of lines for arrays in PHP.
* Add space between // and comment.
* Add space between ) and {.
* Use tabs instead of spaces for indenting.
* Break lines in PHP with more than 100 characters.
* Remove double spaces and spaces at end of line.
* Remove spaces before comma.
* Fix some typos.
Change-Id: I9c014bdfa9832fa6a20d0190fe2fc668983d0fb9
Otherwise it will fail to validate for anonymous users (getEditCount returns null)
as it is a required field
Change-Id: I3d438cfde172b2598955773c4c22fc2d4a502f16
* This patch convert .css to .less
* Semantic changes are avoided, but there are minor
tweaks such as capitalization and ordering.
Change-Id: Iebff0f8e3d87bb792093a10d87f33540aca301d5
An early version of WikiEditor added a workaround for a reported
bug with IE 8 where textarea scroll and selection state was lost
when the contents were modified.
This doesn't seem to be needed on modern versions of IE such as 11
and above and the newer 'Edge' HTML engine mode in Windows 10.
Actually, I can't reproduce it in Windows 7 or XP with IE 8 either
from the original bugs, but just in case it's needed on some particular
version that we don't know about I've only added a check for modern
IEs, which is already in use on other old-IE workarounds in the
module.
Bug: T88875
Change-Id: I25b667a8d8378c417441adee5d97571c71a1c8c7
The search-replace box in WikiEditor was blacklisted entirely from
MSIE, although it appears to work fine in IE 11 on Windows 8.1
and Windows 10 Tech Preview.
IE/Spartan team specifically requested a fix for this bug; looks like
it's an easy case of adjusting the blacklist with a version component...
(Note that in RTL the dialog positioning is bad, but that affects
other WikiEditor dialogs too.)
Bug: T88875
Change-Id: I4cf1eb76cc8a788cab233fe9ed04aaeba4af5725
This changes the color of the line under the hader of the dialog boxes
from #6bc8f3 to the default #aed0ea.
This difference is nearly not recognizable and it is not worth to overwrite
the default color.
Change-Id: I88580ab74fc158ec1a498fc489fbdd9cd5ba897a
The only dialog with a table is the table creator dialog.
For this table a more specific definition exist in
jquery.wikiEditor.dialogs.config.css
These rules overwrite all here removed definitions except of
wikiEditor-toolbar-dialog table { margin-top: 0.75em; }
Without this definition the margin-top slightly increase to the
definition from .wikitable with margin-top: 1em.
Change-Id: I0aab246db05cb4330287666f6a71b56d6b88b0af
