Commit graph

3163 commits

Author SHA1 Message Date
Fomafix 05f15dc79f Merge "Use Html::hidden instead of Xml::element" 2021-11-07 17:46:29 +00:00
jenkins-bot c0967dbe3a Merge "Don't add logging-related form inputs if not required" 2021-11-07 13:55:27 +00:00
Fomafix 758d0fb84a Use Html::hidden instead of Xml::element
This change replaces in the HTML

 <input type="hidden" name="wikieditorJavascriptSupport" id="wikieditorJavascriptSupport" value="" />

by

 <input id="wikieditorJavascriptSupport" type="hidden" name="wikieditorJavascriptSupport"/>

but the behavior is still the same.

Change-Id: Icc9b9c9480be3b220148466d3f93746e14de280a
2021-11-05 18:18:35 +00:00
Fomafix fae34607a7 Replace WebRequest::getVal by WebRequest::getRawVal
The UTF-8 normalization of getVal is not needed here.

Also explicit check for !== null instead of truthy because in PHP is
"0" != true.

Change-Id: I77a8a2c149045f677ff2a1f0e42d9ca9dccde321
2021-11-05 17:57:52 +00:00
Sam Wilson d23389cd06 Avoid User::getEditCount() and ::getOption()
The latter is deprecated, and the former is just a wrapper for
UserEditTracker::getUserEditCount().

Bug: T290521
Change-Id: Id3f2b9a007fe299d74d5957cbd3e31b11adb2790
2021-11-05 11:52:00 +08:00
Sam Wilson a2cccc57af Add live-preview logging
Log on every click (by any means, including accesskey) of the
main editing preview button.

Bug: T290521
Change-Id: I67d821445c5e39034bcb121beccf17a765a311ed
2021-11-04 10:09:56 +08:00
Translation updater bot d5175e8695 Localisation updates from https://translatewiki.net.
Change-Id: I8d58d90d344aca367b249764250f277d71bab7cb
2021-11-03 08:21:33 +01:00
Sam Wilson b980affad6 Don't add logging-related form inputs if not required
Change-Id: I71d7f9b741cb60d0bbb8f0fbd6e8ac0967ee1492
2021-11-03 13:40:19 +08:00
jenkins-bot 4e17f5a5d8 Merge "Fix excluded phpcs rules" 2021-11-02 14:14:45 +00:00
Translation updater bot 819297f7d8 Localisation updates from https://translatewiki.net.
Change-Id: I192be2b12cdf34d6a6f243ec048d25d63f54affe
2021-11-02 08:07:44 +01:00
Sam Wilson 0744773321 Fix excluded phpcs rules
Change-Id: Ie0d0a00e2a12dc50bd2ed9ba00b8e7f339227a56
2021-11-02 13:48:27 +08:00
Translation updater bot 10a35cc513 Localisation updates from https://translatewiki.net.
Change-Id: I2ebd4029ed1f20b522c8b325a0455a3793dce19f
2021-11-01 09:34:55 +01:00
Translation updater bot fc5d8708cf Localisation updates from https://translatewiki.net.
Change-Id: I6c506371e0d864b1f4f14ef91edc0bf46fa6b38c
2021-10-29 08:22:35 +02:00
Translation updater bot 7611a9b993 Localisation updates from https://translatewiki.net.
Change-Id: Ia338b091f70850b49143b728c1484495042f99c4
2021-10-26 08:18:20 +02:00
Translation updater bot 4b1ce7c6ca Localisation updates from https://translatewiki.net.
Change-Id: I45c9c0465ef3fc76f4eb234caeac3f0714d944ca
2021-10-25 08:52:57 +02:00
libraryupgrader 1b5449e6a3 build: Updating mediawiki/mediawiki-codesniffer to 38.0.0
Change-Id: Iac78325ade4c685a338df86306fa47c3b79c2fd4
2021-10-24 15:59:59 +00:00
Translation updater bot b0680dbca7 Localisation updates from https://translatewiki.net.
Change-Id: If95dcfd26b1e8cf400862f666792de84ad2147c9
2021-10-21 08:22:56 +02:00
Translation updater bot b45e353b10 Localisation updates from https://translatewiki.net.
Change-Id: I9927c7aa7376b74fa633e714ea3e54f0cee293a5
2021-10-20 08:38:08 +02:00
Translation updater bot 7cae6b916a Localisation updates from https://translatewiki.net.
Change-Id: I778e3410ecca747bcbe2c2df704757f2e188719b
2021-10-18 15:21:46 +02:00
jenkins-bot 3bcaa37303 Merge "Remove template for insert-link dialog" 2021-10-13 20:20:30 +00:00
jenkins-bot 97780d5e3e Merge "Remove 'resize' logic from jQuery UI dialogs" 2021-10-13 18:59:15 +00:00
Sam Wilson 54f3e15199 Remove out-of-date CSS
* #wikieditor-toolbar-link-int-text was removed in I17f34a8cbf72b80f3916581867e5828d9b129789
* .wikiEditor-template-dialog-fields was removed in I47119d6cfdde4b40ff5b07be0c7d327b80598142

Change-Id: If669eb3fa8e1401d640c879f808c097682c30f31
2021-10-13 11:03:32 +08:00
Sam Wilson 60be1db1d1 Remove template for insert-link dialog
The HTML template is no longer required, as all three fields are
now OOUI and so provide their own HTML.

Bug: T289214
Change-Id: Id7e02119f00e30244b8dc2048c1f694500151b25
2021-10-13 10:03:44 +08:00
Daimona Eaytoy 834632650d Remove 'resize' logic from jQuery UI dialogs
Added in https://phabricator.wikimedia.org/rSVN56198 in 2009

It seems to have no user-visible effect, and resizing is still working
as expected for the dialogs that use it.

OTOH, this logic is broken, since it doesn't account for elements hidden
via classes or anything other than inline style. For instance, if there
are OOUI text fields inside the dialog, the logic in resize() will add

  style="display:inline"

to the empty icon elements, which would then cover part of the input
field.

Bug: T293065
Change-Id: If53937dd9e80835774ef936c5aa19f78c7266ca7
2021-10-12 11:46:21 +02:00
Sam Wilson 0b14ae0666 Change insert-link radio buttons to OOUI
Add new OOUI field for the link-type radio buttons in the
insert-link dialog.

Bug: T289214
Change-Id: Idf80c533e5a17de3e9a57051c0608524b6d45098
2021-10-12 13:01:26 +08:00
Sam Wilson e3e9ebb6cb Change the (insert-link) title field to OOUI
Following-up on I9fb7e66bf925eb9a8260d6245d2a7db54a7a2fec
this converts the link-text field to OOUI.

Bug: T289214
Change-Id: I17f34a8cbf72b80f3916581867e5828d9b129789
2021-10-11 14:45:02 +00:00
Amir E. Aharoni 675dfe18c6 Fix comma splice in a message
Change-Id: Ia851143a4febdcc2d520214d52c9514f932b9dbf
2021-10-09 14:55:43 +03:00
libraryupgrader efb1157ff8 build: Updating ansi-regex to 5.0.1
* https://npmjs.com/advisories/1002401 (CVE-2021-3807)

Change-Id: I54be830d2119b232f59045bfb2b87dfe321a303c
2021-10-09 09:07:37 +00:00
jenkins-bot c3d4bfcd2e Merge "Allow a free-text string 'title' field when adding characters" 2021-10-08 22:24:07 +00:00
Sam Wilson 6384498d75 Switch to OOUI TitleInputWidget for the link-inserter
In order to get a better look-up experience (images, description,
redirects, and disambigutation pages listed last), swich from
a custom title-autocomplete input (that used jquery.suggestions)
to OOUI's standard one (which is used in a bunch of other places
in MediaWiki).

This means a fair bit of code can be deleted from
jquery.wikiEditor.dialogs.config.js, and some of it moved to
the new OOUI classes.

This patch aims to be the minimum required, and so leaves a few
things for subsequent patches (such as converting the other parts
of the insert-link dialog to OOUI).

Bug: T289214
Change-Id: I9fb7e66bf925eb9a8260d6245d2a7db54a7a2fec
2021-10-08 12:43:55 +00:00
Translation updater bot 4023b7af82 Localisation updates from https://translatewiki.net.
Change-Id: I8901d598a51327a719d64d0b466f23f6767456f5
2021-10-05 08:30:14 +02:00
Inductiveload b87612d937 Allow a free-text string 'title' field when adding characters
When adding characters to the WikiEditor toolbar, it's possible to set
titleMsg, but it's not possible to set a free-form string title. This is
rather limiting for personal or site-local scripts which might wish to
use a title tooltip but not be able to set a MediaWiki message.

This commit adds the ability to pass a 'title' field of a character
definition object. If both 'title' and 'titleMsg' are defined, 'titleMsg'
is used.

Bug: T292434
Change-Id: I00775d5e4690c0fd45c20639a122c39dc756135e
2021-10-04 15:48:55 +01:00
Sam Wilson 8a57d552bf Remove out-of-date version requirement from README
The required version is already documented in extension.json and
doesn't need to be repeated in README (where it gets forgotten
and not updated).

Change-Id: I667c9a00c0df381c506c877b5ea2786604ec05e8
2021-10-04 10:34:13 +08:00
Translation updater bot 1b84b98f20 Localisation updates from https://translatewiki.net.
Change-Id: Ie02fa2bcaade00ac363b22c7a98ae10f02d24dff
2021-09-29 09:02:25 +02:00
Translation updater bot ac7b7c1785 Localisation updates from https://translatewiki.net.
Change-Id: I6231009cc00cb16f638a2dd573f1b60eab257704
2021-09-28 08:19:22 +02:00
Translation updater bot 1dcc0ffd6b Localisation updates from https://translatewiki.net.
Change-Id: Ib3f67e6c210687cd0049d97df400b87e3be781bb
2021-09-27 08:35:56 +02:00
Translation updater bot b55a4fc9e3 Localisation updates from https://translatewiki.net.
Change-Id: I51c6f76b6e1971a6ce0ac993ec9004748f82c2b3
2021-09-24 08:26:34 +02:00
jenkins-bot 50f1b7593e Merge "Revert "Support colon link escapes for categories and files"" 2021-09-22 14:38:18 +00:00
Translation updater bot 8f97450d4b Localisation updates from https://translatewiki.net.
Change-Id: Ide748aef8d335956d3c5a603d0f86d0c330dda3d
2021-09-22 08:11:16 +02:00
Ammarpad 2affca03b3 Revert "Support colon link escapes for categories and files"
This reverts commit e76eba6b96.

Bug: T290818
Change-Id: I88f86935f0686b98105ddb49ede4b773d5e6de54
2021-09-21 18:12:25 +01:00
Translation updater bot 6a9a559794 Localisation updates from https://translatewiki.net.
Change-Id: Iea8db21ce80868e64f633742ed85d45616c36dc4
2021-09-20 08:19:51 +02:00
Translation updater bot 14f1598c1d Localisation updates from https://translatewiki.net.
Change-Id: I3b3925964743850d555aa391c0a2683db7e79fce
2021-09-15 08:15:01 +02:00
Translation updater bot 84be8ad42a Localisation updates from https://translatewiki.net.
Change-Id: Ic670bf1485047ea92ea9f5e6df6d70bb9d16f1bf
2021-09-13 08:30:34 +02:00
libraryupgrader 3ffcdfd1f2 build: Updating composer dependencies
* mediawiki/mediawiki-phan-config: 0.10.6 → 0.11.0
* php-parallel-lint/php-parallel-lint: 1.3.0 → 1.3.1

Additional changes:
* composer.json: Updated phpcs command in composer test (T280592).
* composer.json: Added phpcs command to scripts (T280592).

Change-Id: I7060b1fbea13ad7683107d58beee01c76490d35a
2021-09-10 11:51:00 +00:00
Translation updater bot 95327cac54 Localisation updates from https://translatewiki.net.
Change-Id: I1e19d2e91bec9bcb5c37ae459e0d5f401aff50a3
2021-09-10 08:16:09 +02:00
Translation updater bot fd5354f5fe Localisation updates from https://translatewiki.net.
Change-Id: I94a2474c10fc758dc3522ff5cbc38723725f16f1
2021-09-09 08:18:18 +02:00
Translation updater bot 1466354e0e Localisation updates from https://translatewiki.net.
Change-Id: I231e9fba493e3b9fcc356bc0aa11d16c0e2f76b1
2021-09-06 08:21:29 +02:00
Translation updater bot fbf299f18c Localisation updates from https://translatewiki.net.
Change-Id: I7b7803c38082121057fdf84e306b5695353702b9
2021-09-03 08:15:30 +02:00
Translation updater bot 7fe81e705f Localisation updates from https://translatewiki.net.
Change-Id: I1b12838127487dc724384dfb32e80561ecb32ea5
2021-09-02 08:26:58 +02:00
Sam Wilson b0904ce4f1 Remove unused image: insert-link-error.png
This image appears to have never been used, according to Git log searching.

Bug: T289214
Change-Id: I230db9ea85e0b3305c9bcc84531db21e93fecf4e
2021-09-01 16:29:05 +08:00