Commit graph

266 commits

Author SHA1 Message Date
Brion Vibber 2b22c37b88 * (bug 29322) Move some iframe-specific code in WikiEditor JS to its proper module 2011-06-09 18:10:02 +00:00
Brion Vibber 85ec51cce0 Fix for WikiEditor iframe extension on IE: use $.inArray() instead of Array.indexOf(), which is not in earlier JS standards as implemented in IE 8.
Use of Array.indexOf was added in r74271 when the iframe bits were broken out to an extension.
2011-06-09 00:20:13 +00:00
Krinkle 40bb0c72b5 Extension:WikiEditor Code quality, JSHint validation and JSPERF
- Leaked globals
- Strict comparison to 0, false and ''
- Missing semicolon
- Variable name collision
- Minor improvements in caching (in a few places "var $that" cached $(this), but wasn't actually used)
- Replace calls to deprecated $j with $
- Checking undefined by strictly comparing references instead of a string comparison and typeof (speed)

(see bug 29106)
2011-06-06 23:18:13 +00:00
Roan Kattouw 63e9d0ff85 WikiEditor: (bug 27698) Toolbar height isn't updated in all code paths of addToToolbar(), causes toolbar to overlap part of the edit box if certain race conditions happen. Patch by Salvatore Ingala 2011-05-13 14:34:43 +00:00
Leo Koppelkamm 57721bd94e Followup to r86108 per CR: Fix two calls to legacy tablesorter 2011-04-30 18:58:17 +00:00
Jan Paul Posma 6e998359f0 Fixes bug 24088: WikiEditor toolbar RTL icons 2011-04-25 12:26:20 +00:00
Jan Paul Posma 4c8f157f1a Fixes bug 28149 (but with default to true) 2011-04-22 12:10:18 +00:00
Roan Kattouw fad3b6568b (bug 22209, bug 22574) Make indent, bullet list and numbered list buttons in the WikiEditor toolbar act on each line individually
* Reintroduce support for the splitlines argument in encapsulateSelection(). Was implemented by Adam Miller in r61493 but got lost somehow
* Add 'splitlines': true for the bullet list and numbered list buttons. The indent button already had it, so that part of r61493 did survive
* Copy options.pre and options.post to local pre and post variables instead of using (and modifying!) them directly all over the place
2011-04-21 13:42:39 +00:00
Leo Koppelkamm 724dccc131 Fix jumping of textbox in link-dialog. This happened when the link was being checked and the too large spinner image pushed the field down 2011-04-21 08:59:13 +00:00
Marcin Cieślak e8625d2726 Additonal pair of quotes in the enhanced edit toolbar
Some langages (Croatian, Hungarian, Polish, Romanian, Serbian)
use DOUBLE LOW-9 QUOTATION MARK (U+201E) and 
RIGHT DOUBLE QUOTATION MARK (U+201D) in marking up
quotes. For more details, see:

http://en.wikipedia.org/wiki/Quotation_mark,_non-English_usage
2011-04-04 23:06:47 +00:00
Derk-Jan Hartman d0b6d276cf Because this element has margins, the scrollWidth will be larger by definition, causing the box to continiously grow in size when opening it multiple times.
Fixes bug 27566
2011-03-28 21:11:17 +00:00
Michael Dale 203a9133a2 removed addMediaWizard gadget ( should be supported via dedicated extension 'AddMediaWizard' ) 2011-03-11 21:42:03 +00:00
Jan Paul Posma 9df5838aa5 Fixes bug when having multiple textareas, which is caused by the fact that dialogs are kept in memory for performance, even when selecting a different textarea. 2011-02-27 17:14:01 +00:00
Jan Paul Posma 9d6f6e3526 1. Re-introduces check if the browser supports the dialogs, which was removed for no apparent reason in r74276.
2. Makes the isEnabled function public, to allow other extensions to use the same configuration settings as WikiEditor.
2011-02-25 00:01:57 +00:00
Jan Paul Posma 8ca58dd46b A bit of a reorganisation that fixes bug 27164. Basically the extensive configuration in the ext.wikieditor.* functions is moved to the jquery plugins, to be able to use these configurations in other extensions which don't have a #wpTextbox1.
Please review this to check if this is the right way to do it!
2011-02-24 01:45:55 +00:00
Roan Kattouw ee3a8e68b0 WikiEditor: Add missing message and shut up a source of JS errors 2011-02-23 20:50:52 +00:00
Max Semenik dcebf90c7c WikiEditor: removed duplicate Hebrew characters. Reported on IRC by Yair Rand. 2011-02-21 15:35:01 +00:00
Roan Kattouw 7464078c73 (bug 27502) Monospace text too small 2011-02-19 15:02:14 +00:00
Roan Kattouw 9eaa77a549 WikiEditor: Use wgExtensionAssetsPath instead of wgScriptPath + '/extensions' 2011-02-16 14:52:34 +00:00
Roan Kattouw b7f45b1e01 WikiEditor: Add some var statements to code introduced in r74271 2011-02-08 07:04:12 +00:00
Roan Kattouw 94c2e2f19d WikiEditor: Fix usage of $.client 2011-02-07 21:59:01 +00:00
Brion Vibber 9021930871 * (bug 26975) Regression fix for search-and-replace in WikiEditor
string_instance.escapeRE() -> $.escapeRE(string_instance)
2011-02-07 21:46:25 +00:00
Trevor Parscal 541af6f940 Changed how namespace is injected into gallery and file example messages. We don't have template processing on the client (yet) so this will work for now. 2011-01-13 00:58:32 +00:00
Trevor Parscal 9cff4eb684 Removed ad-hoc rtl rules - CSSJanus out of the box is doing just fine. 2011-01-12 00:06:57 +00:00
Trevor Parscal 2c4ea9d393 Improved on r79973 re-resolves #25724 after #80057 re-broke it. Aparently Opera was choking on, and ignoring the following CSS rule after, a CSS rule that ended in "background-image: url(some url here) !important;" Removing the "!important" part fixed the problem, and in this case it didn't seem to be needed anyways. So much for unicorn tears... 2011-01-11 23:55:39 +00:00
Trevor Parscal 1ed22372ab Removed more IE6 stuff. 2011-01-11 23:44:53 +00:00
Trevor Parscal 81bb906c99 Removed RTL rules and IE6 stuff from toolbar css, ResourceLoader uses CSSJanus to auto-flip the rules, and IE6 is blacklisted anyways. 2011-01-11 23:41:23 +00:00
Trevor Parscal ada78c1546 Fixed annoying bug where the index would not highlight the current page the first time you open the booklet. 2011-01-10 23:45:03 +00:00
Trevor Parscal 47d4852f07 Resolved #25724 using evil black magic and unicorn tears. 2011-01-10 23:32:52 +00:00
Trevor Parscal 1f17742ba1 Changed the way the toolbar creates it's file tool - which inserts [[File:<selection>]] - now we are using the wgFormattedNamespaces configuration. wikieditor-toolbar-tool-file-pre is not needed anymore, and has been removed. 2011-01-10 22:41:17 +00:00
Roan Kattouw c345140f63 WikiEditor: (bug 26621) References button was shown in all namespaces while it's only supposed to show in non-talk namespaces. Regression in r74114 2011-01-07 21:07:08 +00:00
Roan Kattouw 4b89c4440b WikiEditor: Fix templateEditor dialogs, which were broken by lazy creation in the dialogs module, by allowing them to specify they need immediate creation. Also add a few missing var keywords and explicitly pass a variable that was previously passed by accident because it leaked into the global scope without the var on it. 2011-01-04 12:53:20 +00:00
Roan Kattouw 5c5897ef77 Followup r79570: fix the image paths up for real 2011-01-04 12:03:41 +00:00
Roan Kattouw bc9fec6080 WikiEditor: Fix paths to images in jquery.wikiEditor.html , apparently these were never updated for the UsabilityInitiative->WikiEditor move 2011-01-04 11:58:31 +00:00
Sam Reed c4dcd265e4 Fix syntax error from r77928 2010-12-08 19:20:44 +00:00
Sam Reed d1c8a22f6d Some more unterminated statements (bug 26265) 2010-12-06 22:51:54 +00:00
Sam Reed a3cba4154c Remove a couple of commas 2010-12-06 11:07:50 +00:00
Trevor Parscal de04fce204 Prevent focus outline in webkit for textarea in editor. 2010-12-01 22:41:52 +00:00
Roan Kattouw 0d78534735 Remove RegExp.escape() in favor of String.prototype.escapeRE() 2010-10-28 15:32:43 +00:00
Roan Kattouw 947fe69c27 (bug 25339) Allow specifying separate base paths for local and remote paths in ResourceLoaderFileModule::__construct(). Extensions can use this to properly point the resource loader to their resources in a way that doesn't depend on the extensions/ directory being a subdirectory of phase3/ on the filesystem and that respects $wgExtensionAssetsPath. Also converted all extensions using ResourceLoader to use this approach, except MWEmbed which uses way more indirection building its module registrations than I can deal with after midnight.
What actually happens here
* Add $localBasePath, $remoteBasePath params to the FileModule constructor, defaulting to $IP and $wgScriptPath respectively
* Add getLocalPath() and getRemotePath(), which use this information to build a proper FS or URL path for a file
* Make readScriptFiles() non-static so it can use these functions
* Run every single file path we use through either getLocalPath() or getRemotePath() as appropriate
** Except file dependencies, these are already prefixed. Our inability to give them special treatment caused bugs earlier
* Kill prefixFilePathList() and resolveFilePath(), no longer needed
2010-10-27 22:22:10 +00:00
Trevor Parscal bb88f087b4 Mostly reverted r75487, making use of a new version of mediaWiki.msg. 2010-10-27 00:16:32 +00:00
Trevor Parscal 55a8f66322 Updated use of mediaWiki.msg to mediaWiki.message 2010-10-26 23:42:23 +00:00
Roan Kattouw 4e9d2b26d2 WikiEditor: (bug 25460) Place cursor behind, not before, inserted signature 2010-10-11 08:24:04 +00:00
Trevor Parscal da918a5d68 Made use of mediaWiki.loader for adding in mediawiki.legacy.diff for the change tab of jquery.wikiEditor.preview 2010-10-05 22:06:16 +00:00
Trevor Parscal 49eb154f2c * Fixed mistake made in r74271 where some functions were moved from core jquery.wikiEditor into jquery.wikiEditor.iframe, causing errors for textarea mode. These changes properly split the functions, allowing the iframe to override the textarea functions, and using $.client to only execute them on IE. (tested in IE7)
* Also fixed IE bug, where "delete window.myThing;" fails but "delete myThing;" succeeds.
2010-10-05 20:54:38 +00:00
Trevor Parscal c92c4436a5 Fixed autoMsg misusing mediaWiki.msg.get 2010-10-04 21:17:08 +00:00
Trevor Parscal cb6ff96431 Got more dialogs working again 2010-10-04 21:08:41 +00:00
Trevor Parscal 0a71513db4 * Introduced the concept of context extensions
* Abstracted the requirements concept being used to hack in the iframe as a context extension requirement
* Removed some hardcoding for iframe stuff
* Moved about 60k of JavaScript code out of the main wikiEditor script, and into an iframe only context extension.
2010-10-04 20:12:30 +00:00
Trevor Parscal 0a0f6f6e8e * Fixed the toolbar, where sprited buttons weren't receiving the correct classes.
* Changed the way dialogs toolbar buttons were being added
* Made dialog code load on the fly
2010-10-01 21:58:04 +00:00
Trevor Parscal d5f8b1bc3a Using new group feature of ResourceLoaderFileModule objects. 2010-09-20 23:31:56 +00:00
Trevor Parscal 089b73aa5d * Moved ResourceLoader modules into the ext.* space - this is the convention that should be followed in the future
* Moved test resource to the modules folder and registered it
* Fixed tests file to use $ not $j
* Cleaned up syntax in module definitions
2010-09-20 20:06:18 +00:00
Trevor Parscal 0fd0380e20 Fixed bug that made preview not work with textarea. Also discontinued use of some globals. 2010-09-17 23:58:41 +00:00
Trevor Parscal c3d1da7254 Added in conentCollector for paste-filtering support 2010-09-16 23:13:05 +00:00
Trevor Parscal d35fddbda6 Added embed tags to CSS image URLs 2010-09-16 22:57:22 +00:00
Trevor Parscal fd441d4b6d Remapped image and html paths to new extension location. 2010-09-16 22:54:59 +00:00
Trevor Parscal 9862d7d871 Removed dependency on global variable "wgWikiEditorIconVersion" 2010-09-16 22:40:24 +00:00
Trevor Parscal d555f70643 Removed unused code. 2010-09-16 22:20:43 +00:00
Trevor Parscal ff8e204ccd Table of contents is working now - fixed dependency issues and removed some globals that are no longer needed. 2010-09-16 22:20:17 +00:00
Trevor Parscal 94c8be537b Moved one rule back. 2010-09-16 21:44:43 +00:00
Trevor Parscal 7d438b6006 Moving some CSS to the vector jquery ui skin, rather than keeping them here as WikiEditor only customizations 2010-09-16 21:43:11 +00:00
Trevor Parscal 81510294e1 Moved some images to the vector jquery ui skin, rather than keeping them here as WikiEditor only customizations 2010-09-16 21:40:56 +00:00
Trevor Parscal 6b8e5f2f54 This extension now functions. iframe dependendt modules need more work still. 2010-09-16 21:11:46 +00:00
Trevor Parscal 8be53e71af Merged in changes from r73123 2010-09-16 17:22:23 +00:00
Trevor Parscal a9c45c88e0 Lots of refactoring. This still does not work! But it's getting close. 2010-09-15 22:40:50 +00:00
Trevor Parscal c45ca9a77e Changed naming of files to follow new conventions. 2010-09-15 19:18:26 +00:00
Trevor Parscal 9d278e8dee Copied over all the resources needed to make WikiEditor stand on it's own two feet. Lots more to do as far as organizing and fleshing out the extensions's PHP bits. 2010-09-15 03:08:35 +00:00