Eranroz
44122de2dc
fixing some RTL issues with Wikieditor dialogs.
...
Original support for RTL here was written before ResourceLoader, now
ResourceLoader handles it and this special code for RTL shouldn't exist
:)
Long time ago some css specific for RTL was added for supporting RTL with
body.rtl (before ResourceLoader). However now it is not needed as
ResourceLoader already flips right/left, and moreover it even causes wrong
direconality as ResourceLoader flipps the special handling for RTL.
Changes:
1. dialogs buttons were on right (in English buttons on the
right side too) => now on left side
2. Title of dialogs was in left, and close on right => now title is on
right and close on left
3. Link dialogs: the "Target Page" and the icon for "Broken/Good link" was
flipped
Change-Id: Ia85dfcfcea5945d088cffc4da6198fa506933f81
2012-05-03 22:13:23 +03:00
Trevor Parscal
96052d0d97
(bug 34885) Fixes issue where old toolbar was killed, even when the new toolbar was incompatible
...
Instead of wiping the old toolbar out on the server side we now just wrap the old toolbar in a div that has an inline style that prevents it from being displayed. This is only done when the toolbar is enabled. When the toolbar code runs on the client, if the toolbar ends up being incompatible, the old toolbar's wrapping div is shown. This avoids the side-effect of the old toolbar showing up momentarily while the new toolbar loads. It's a dirty hack, but we explored this extensively and it's the least evil way we could come up with that worked consistently.
Change-Id: I6fefadea4dbd01b96a0b95c50bc9ef526144dc3c
2012-04-17 15:19:20 -07:00
Krinkle
8730cde553
Merge "Don't escape $, not needed in JS"
2012-04-17 21:30:41 +00:00
Catrope
aa78431fc0
Merge "Adding Tamil numerals special character insertion toolbar."
2012-04-17 21:21:40 +00:00
srikanthlogic
2dc745c7ef
Adding Tamil numerals special character insertion toolbar.
...
Patchset 2: (Roan) Fix indentation to use tabs instead of spaces
Change-Id: Ia55da864a01a0adc6ac15d5c132832b11a4d94c2
2012-04-17 14:20:00 -07:00
Catrope
5bd7ef6a1b
Merge "Moved character 25cc (dotted circle) before the diacritic."
2012-04-17 21:14:53 +00:00
Catrope
c96beedf86
Merge "RTL fix for special characters insertion links."
2012-04-17 21:12:14 +00:00
Catrope
99a8b25d3b
Merge "Adding pretty quotation marks for Hebrew."
2012-04-17 21:11:32 +00:00
Catrope
ba2cf2f249
Don't escape $, not needed in JS
...
This makes jquery.wikiEditor.toolbar.config.js pass jshint (the
command-line jshint from npm that is)
Change-Id: I74d353c956c2b9616a9f80e10d5309ae9ee544db
2012-04-17 13:41:13 -07:00
Amir E. Aharoni
ec24d21801
Updating the Gujarati character insertion toolbar.
...
New characters are added and existing characters are reordered
according to comments received from the Gujarati Language support
team.
Change-Id: I769594ec1088d2c3326477a3f1065d576c6dcdf7
2012-04-01 14:39:51 +03:00
Amir E. Aharoni
f963e0f704
Adding pretty quotation marks for Hebrew.
...
Change-Id: Ief0aad430b4565a46f5772b6ef24e41e11e98774
2012-03-29 11:22:59 +02:00
Amir E. Aharoni
e6640f53ba
Moved character 25cc (dotted circle) before the diacritic.
...
The diacritic is supposed to appear after the dotted circle. It is
already like this in other languages.
Change-Id: Id157ab58ae41bd6e8f78c26b35b65003abc7bf7a
2012-03-29 10:15:43 +02:00
Amir E. Aharoni
7cea0eb810
RTL fix for special characters insertion links.
...
Added @noflip, because it's explicitly rtl. Without it, it becomes ltr.
Change-Id: Ifda0894d8745faea2dc18e4efed3a3dfa52239d8
2012-03-29 10:10:23 +02:00
Brion VIBBER
954636d7ca
Merge "Added ZWNJ and ZWJ according to request at bug 30611. Split special characters from digits."
2012-03-26 22:50:21 +00:00
Amir E. Aharoni
562f1d3fbc
Grouped Hebrew characters and added comments. Added required punctuation characters.
...
Change-Id: I353e3c12be8c2fdb8abcc1d6690b43e71717f689
2012-03-24 15:00:50 +02:00
Amir E. Aharoni
aa493220fa
Added ZWNJ and ZWJ according to request at bug 30611.
...
Split special characters from digits.
Change-Id: Ibcaaa1f5447495647ff18658c4250617f8307455
2012-03-24 12:56:08 +02:00
Sam Reed
0514d49717
More image compression for extensions
2012-03-01 02:24:49 +00:00
Roan Kattouw
f26acc15c7
Add a configuration variable for disabling tracking clicks on the toolbar buttons
2012-02-23 22:29:37 +00:00
Daniel Friesen
45f3e29065
Add resize: vertical; to the textarea's css so that browsers like firefox and chrome won't allow horizontal resizing resulting in WikiEditor background showing.
2012-02-15 06:06:27 +00:00
Roan Kattouw
9061f480db
(bug 32451) Clicking on a special characters section loses the selection in IE8. Patch by Lupo
2011-11-20 15:02:20 +00:00
Derk-Jan Hartman
6325d5ea3b
Harden the toolbar builder for character insertion a bit against incorrect configurations.
...
Will now check if character is defined and will return empty string as result instead.
Added a mw.log to catch this situation for developers.
Based on patch by User:Lupo.
Bug 31673
2011-11-14 21:55:46 +00:00
Derk-Jan Hartman
2c9bbffca7
Make sure a row is closed in the toolbar.
...
Patch by User:Lupo
Bug 31673
2011-11-14 21:21:15 +00:00
Roan Kattouw
d82577cce1
Remove stray comma per bug 31673 comment 4
2011-11-14 13:51:40 +00:00
Roan Kattouw
a1cec03598
(bug 32374) Heading dropdown disappears behind textarea after closing and re-opening the Advanced section. This seems to be caused by the collapsing animation that sets position:absolute on the section, does the fadeOut animation, then after the animation sets the position 'back' to relative. However, the position was never relative to begin with, so now the absolutely positioned header dropdown has a different closest positioned anchestor and it appears things go wrong from there and cause the bug. So instead of setting the position to relative after the animation, set it back to what it actually was before, which is static (implicitly).
2011-11-12 09:08:00 +00:00
Roan Kattouw
432415b129
Followup r96944: rename "Replace next" button to "Replace" cause that's what it does now
2011-10-31 08:38:35 +00:00
Sam Reed
7f10e92044
Swap
...
/*
*
for
/**
*
2011-10-26 03:49:06 +00:00
Roan Kattouw
280ae464a4
(bug 31499) articlePathRegex (detection of external links within the same wiki) broken when wgServer is protocol-relative
2011-10-25 14:30:33 +00:00
Derk-Jan Hartman
11aabbd4a9
Fix bug 31604.
...
Table should now load the tablesorter if needed, and make sure that the table is sortable.
2011-10-22 17:21:03 +00:00
Roan Kattouw
fe7b614517
(bug 31411) Remove stray comma introduced in r86853, broke WikiEditor in IE
2011-10-06 13:15:03 +00:00
Roan Kattouw
bf8858349b
WikiEditor: Fix bug where ext.wikiEditor would load and wrap the textarea even if the toolbar was disabled. This has been reported to me on IRC but I'm not aware of any bug report in BZ
2011-09-29 19:04:54 +00:00
Siebrand Mazeland
cc71ec5354
* bump version to 0.3.1
...
* stylize.php
2011-09-13 08:56:32 +00:00
Siebrand Mazeland
868eec7504
(bug 20919) Search & Replace: Change "Replace Next" functionality to "Replace" functionality. Patch by Amir E. Aharoni.
...
Submitter's comment: "Replace next" now replaces the currently selected text instead of finding the next occurrence and replacing it. To keep the location of the current occurrence, i added matchIndex to $(this).data.
I added some comments renamed a couple of variable for readability:
* s to textRemainder
* replace to actualReplacement
This is my first significant jQuery-style patch so it may have embarrassing mistakes - constructive criticism is welcome.
2011-09-13 08:53:12 +00:00
Siebrand Mazeland
85ad75bc8c
(bug 30611) Improve WikiEditor localization for Arabic script languages. Patch by Amir E. Aharoni.
...
Split the Arabic section in jquery.wikiEditor.toolbar.config.js into Arabic and Arabic extended. Arabic contains the core 28-letter alphabet, special letters for the Arabic language, vowels, punctuation and digits. "Arabic extended" contains most of the other letters and signs that are used by languages such as Arabic, Urdu, Balochi, etc.
2011-08-30 16:22:26 +00:00
Roan Kattouw
0af1258eef
Followup r82900: per CR, use .length instead of size(), strict comparison with zero, and re-select from the DOM after removal to guard against weird interaction between .remove() and .length
2011-08-20 12:47:00 +00:00
Roan Kattouw
dccf13d8c3
(bug 29750) In the special characters toolbar, add Ș (\u0218), ș (\u0129), Ț (\u021a), ț (\u021b) and remove Ţ (\u0162), ţ (\u0163), Ŀ (\u013f), ŀ (\u0140). Patch by Amir Aharoni
2011-08-14 09:29:45 +00:00
Leo Koppelkamm
fb2ee48521
r91740: Updating module name in extensions
2011-07-08 18:00:38 +00:00
Derk-Jan Hartman
e2f796c8d9
One more fix for the for in loops.
...
Follow up to r91347
2011-07-07 20:54:24 +00:00
Derk-Jan Hartman
f83bb24864
Follow up to r91349
...
Missed adding quotes to two of the [rel=]
2011-07-03 22:42:28 +00:00
Derk-Jan Hartman
6f6e7d0565
Adding quotes for the [rel=] stuff, since this broke one test.
...
Reported in bug 29106. Patch by Michael M.
2011-07-02 09:17:01 +00:00
Derk-Jan Hartman
3cae03cef5
Correct for in loops on arrays.
...
Reported in bug 29106. Patch by Michael M.
2011-07-02 09:09:05 +00:00
Derk-Jan Hartman
c1edd49986
Clean up some global var leaking in WikiEditor toolbar
...
Reported in bug 29106. Patch by Michael M.
2011-07-02 08:54:01 +00:00
Derk-Jan Hartman
e7132c5323
* Fix broken post call to api in side-to-side diffs
...
* Fix support for side-to-side diffs in section editing
Reported in bug 29106. Patch by Michael M.
2011-07-02 08:46:50 +00:00
Krinkle
6b2326d26d
Follow-up r90845: mw.get > mw.config.get
2011-06-26 19:54:21 +00:00
Mark A. Hershberger
b18069c06a
Bug #29106 : Patch from Michael M. to address JS legacy globals in wikiEditor
2011-06-26 19:25:27 +00:00
Brion Vibber
2b22c37b88
* (bug 29322) Move some iframe-specific code in WikiEditor JS to its proper module
2011-06-09 18:10:02 +00:00
Brion Vibber
85ec51cce0
Fix for WikiEditor iframe extension on IE: use $.inArray() instead of Array.indexOf(), which is not in earlier JS standards as implemented in IE 8.
...
Use of Array.indexOf was added in r74271 when the iframe bits were broken out to an extension.
2011-06-09 00:20:13 +00:00
Krinkle
40bb0c72b5
Extension:WikiEditor Code quality, JSHint validation and JSPERF
...
- Leaked globals
- Strict comparison to 0, false and ''
- Missing semicolon
- Variable name collision
- Minor improvements in caching (in a few places "var $that" cached $(this), but wasn't actually used)
- Replace calls to deprecated $j with $
- Checking undefined by strictly comparing references instead of a string comparison and typeof (speed)
(see bug 29106)
2011-06-06 23:18:13 +00:00
Roan Kattouw
63e9d0ff85
WikiEditor: (bug 27698) Toolbar height isn't updated in all code paths of addToToolbar(), causes toolbar to overlap part of the edit box if certain race conditions happen. Patch by Salvatore Ingala
2011-05-13 14:34:43 +00:00
Leo Koppelkamm
57721bd94e
Followup to r86108 per CR: Fix two calls to legacy tablesorter
2011-04-30 18:58:17 +00:00
Jan Paul Posma
6e998359f0
Fixes bug 24088: WikiEditor toolbar RTL icons
2011-04-25 12:26:20 +00:00
Jan Paul Posma
4c8f157f1a
Fixes bug 28149 (but with default to true)
2011-04-22 12:10:18 +00:00
Roan Kattouw
fad3b6568b
(bug 22209, bug 22574) Make indent, bullet list and numbered list buttons in the WikiEditor toolbar act on each line individually
...
* Reintroduce support for the splitlines argument in encapsulateSelection(). Was implemented by Adam Miller in r61493 but got lost somehow
* Add 'splitlines': true for the bullet list and numbered list buttons. The indent button already had it, so that part of r61493 did survive
* Copy options.pre and options.post to local pre and post variables instead of using (and modifying!) them directly all over the place
2011-04-21 13:42:39 +00:00
Leo Koppelkamm
724dccc131
Fix jumping of textbox in link-dialog. This happened when the link was being checked and the too large spinner image pushed the field down
2011-04-21 08:59:13 +00:00
Marcin Cieślak
e8625d2726
Additonal pair of quotes in the enhanced edit toolbar
...
Some langages (Croatian, Hungarian, Polish, Romanian, Serbian)
use DOUBLE LOW-9 QUOTATION MARK (U+201E) and
RIGHT DOUBLE QUOTATION MARK (U+201D) in marking up
quotes. For more details, see:
http://en.wikipedia.org/wiki/Quotation_mark,_non-English_usage
2011-04-04 23:06:47 +00:00
Derk-Jan Hartman
d0b6d276cf
Because this element has margins, the scrollWidth will be larger by definition, causing the box to continiously grow in size when opening it multiple times.
...
Fixes bug 27566
2011-03-28 21:11:17 +00:00
Michael Dale
203a9133a2
removed addMediaWizard gadget ( should be supported via dedicated extension 'AddMediaWizard' )
2011-03-11 21:42:03 +00:00
Jan Paul Posma
9df5838aa5
Fixes bug when having multiple textareas, which is caused by the fact that dialogs are kept in memory for performance, even when selecting a different textarea.
2011-02-27 17:14:01 +00:00
Jan Paul Posma
9d6f6e3526
1. Re-introduces check if the browser supports the dialogs, which was removed for no apparent reason in r74276.
...
2. Makes the isEnabled function public, to allow other extensions to use the same configuration settings as WikiEditor.
2011-02-25 00:01:57 +00:00
Jan Paul Posma
8ca58dd46b
A bit of a reorganisation that fixes bug 27164. Basically the extensive configuration in the ext.wikieditor.* functions is moved to the jquery plugins, to be able to use these configurations in other extensions which don't have a #wpTextbox1.
...
Please review this to check if this is the right way to do it!
2011-02-24 01:45:55 +00:00
Roan Kattouw
ee3a8e68b0
WikiEditor: Add missing message and shut up a source of JS errors
2011-02-23 20:50:52 +00:00
Max Semenik
dcebf90c7c
WikiEditor: removed duplicate Hebrew characters. Reported on IRC by Yair Rand.
2011-02-21 15:35:01 +00:00
Roan Kattouw
7464078c73
(bug 27502) Monospace text too small
2011-02-19 15:02:14 +00:00
Roan Kattouw
9eaa77a549
WikiEditor: Use wgExtensionAssetsPath instead of wgScriptPath + '/extensions'
2011-02-16 14:52:34 +00:00
Roan Kattouw
b7f45b1e01
WikiEditor: Add some var statements to code introduced in r74271
2011-02-08 07:04:12 +00:00
Roan Kattouw
94c2e2f19d
WikiEditor: Fix usage of $.client
2011-02-07 21:59:01 +00:00
Brion Vibber
9021930871
* (bug 26975) Regression fix for search-and-replace in WikiEditor
...
string_instance.escapeRE() -> $.escapeRE(string_instance)
2011-02-07 21:46:25 +00:00
Trevor Parscal
541af6f940
Changed how namespace is injected into gallery and file example messages. We don't have template processing on the client (yet) so this will work for now.
2011-01-13 00:58:32 +00:00
Trevor Parscal
9cff4eb684
Removed ad-hoc rtl rules - CSSJanus out of the box is doing just fine.
2011-01-12 00:06:57 +00:00
Trevor Parscal
2c4ea9d393
Improved on r79973 re-resolves #25724 after #80057 re-broke it. Aparently Opera was choking on, and ignoring the following CSS rule after, a CSS rule that ended in "background-image: url(some url here) !important;" Removing the "!important" part fixed the problem, and in this case it didn't seem to be needed anyways. So much for unicorn tears...
2011-01-11 23:55:39 +00:00
Trevor Parscal
1ed22372ab
Removed more IE6 stuff.
2011-01-11 23:44:53 +00:00
Trevor Parscal
81bb906c99
Removed RTL rules and IE6 stuff from toolbar css, ResourceLoader uses CSSJanus to auto-flip the rules, and IE6 is blacklisted anyways.
2011-01-11 23:41:23 +00:00
Trevor Parscal
ada78c1546
Fixed annoying bug where the index would not highlight the current page the first time you open the booklet.
2011-01-10 23:45:03 +00:00
Trevor Parscal
47d4852f07
Resolved #25724 using evil black magic and unicorn tears.
2011-01-10 23:32:52 +00:00
Trevor Parscal
1f17742ba1
Changed the way the toolbar creates it's file tool - which inserts [[File:<selection>]] - now we are using the wgFormattedNamespaces configuration. wikieditor-toolbar-tool-file-pre is not needed anymore, and has been removed.
2011-01-10 22:41:17 +00:00
Roan Kattouw
c345140f63
WikiEditor: (bug 26621) References button was shown in all namespaces while it's only supposed to show in non-talk namespaces. Regression in r74114
2011-01-07 21:07:08 +00:00
Roan Kattouw
4b89c4440b
WikiEditor: Fix templateEditor dialogs, which were broken by lazy creation in the dialogs module, by allowing them to specify they need immediate creation. Also add a few missing var keywords and explicitly pass a variable that was previously passed by accident because it leaked into the global scope without the var on it.
2011-01-04 12:53:20 +00:00
Roan Kattouw
5c5897ef77
Followup r79570: fix the image paths up for real
2011-01-04 12:03:41 +00:00
Roan Kattouw
bc9fec6080
WikiEditor: Fix paths to images in jquery.wikiEditor.html , apparently these were never updated for the UsabilityInitiative->WikiEditor move
2011-01-04 11:58:31 +00:00
Sam Reed
c4dcd265e4
Fix syntax error from r77928
2010-12-08 19:20:44 +00:00
Sam Reed
d1c8a22f6d
Some more unterminated statements (bug 26265)
2010-12-06 22:51:54 +00:00
Sam Reed
a3cba4154c
Remove a couple of commas
2010-12-06 11:07:50 +00:00
Trevor Parscal
de04fce204
Prevent focus outline in webkit for textarea in editor.
2010-12-01 22:41:52 +00:00
Roan Kattouw
0d78534735
Remove RegExp.escape() in favor of String.prototype.escapeRE()
2010-10-28 15:32:43 +00:00
Roan Kattouw
947fe69c27
(bug 25339) Allow specifying separate base paths for local and remote paths in ResourceLoaderFileModule::__construct(). Extensions can use this to properly point the resource loader to their resources in a way that doesn't depend on the extensions/ directory being a subdirectory of phase3/ on the filesystem and that respects $wgExtensionAssetsPath. Also converted all extensions using ResourceLoader to use this approach, except MWEmbed which uses way more indirection building its module registrations than I can deal with after midnight.
...
What actually happens here
* Add $localBasePath, $remoteBasePath params to the FileModule constructor, defaulting to $IP and $wgScriptPath respectively
* Add getLocalPath() and getRemotePath(), which use this information to build a proper FS or URL path for a file
* Make readScriptFiles() non-static so it can use these functions
* Run every single file path we use through either getLocalPath() or getRemotePath() as appropriate
** Except file dependencies, these are already prefixed. Our inability to give them special treatment caused bugs earlier
* Kill prefixFilePathList() and resolveFilePath(), no longer needed
2010-10-27 22:22:10 +00:00
Trevor Parscal
bb88f087b4
Mostly reverted r75487, making use of a new version of mediaWiki.msg.
2010-10-27 00:16:32 +00:00
Trevor Parscal
55a8f66322
Updated use of mediaWiki.msg to mediaWiki.message
2010-10-26 23:42:23 +00:00
Roan Kattouw
4e9d2b26d2
WikiEditor: (bug 25460) Place cursor behind, not before, inserted signature
2010-10-11 08:24:04 +00:00
Trevor Parscal
da918a5d68
Made use of mediaWiki.loader for adding in mediawiki.legacy.diff for the change tab of jquery.wikiEditor.preview
2010-10-05 22:06:16 +00:00
Trevor Parscal
49eb154f2c
* Fixed mistake made in r74271 where some functions were moved from core jquery.wikiEditor into jquery.wikiEditor.iframe, causing errors for textarea mode. These changes properly split the functions, allowing the iframe to override the textarea functions, and using $.client to only execute them on IE. (tested in IE7)
...
* Also fixed IE bug, where "delete window.myThing;" fails but "delete myThing;" succeeds.
2010-10-05 20:54:38 +00:00
Trevor Parscal
c92c4436a5
Fixed autoMsg misusing mediaWiki.msg.get
2010-10-04 21:17:08 +00:00
Trevor Parscal
cb6ff96431
Got more dialogs working again
2010-10-04 21:08:41 +00:00
Trevor Parscal
0a71513db4
* Introduced the concept of context extensions
...
* Abstracted the requirements concept being used to hack in the iframe as a context extension requirement
* Removed some hardcoding for iframe stuff
* Moved about 60k of JavaScript code out of the main wikiEditor script, and into an iframe only context extension.
2010-10-04 20:12:30 +00:00
Trevor Parscal
0a0f6f6e8e
* Fixed the toolbar, where sprited buttons weren't receiving the correct classes.
...
* Changed the way dialogs toolbar buttons were being added
* Made dialog code load on the fly
2010-10-01 21:58:04 +00:00
Trevor Parscal
d5f8b1bc3a
Using new group feature of ResourceLoaderFileModule objects.
2010-09-20 23:31:56 +00:00
Trevor Parscal
089b73aa5d
* Moved ResourceLoader modules into the ext.* space - this is the convention that should be followed in the future
...
* Moved test resource to the modules folder and registered it
* Fixed tests file to use $ not $j
* Cleaned up syntax in module definitions
2010-09-20 20:06:18 +00:00
Trevor Parscal
0fd0380e20
Fixed bug that made preview not work with textarea. Also discontinued use of some globals.
2010-09-17 23:58:41 +00:00
Trevor Parscal
c3d1da7254
Added in conentCollector for paste-filtering support
2010-09-16 23:13:05 +00:00
Trevor Parscal
d35fddbda6
Added embed tags to CSS image URLs
2010-09-16 22:57:22 +00:00
Trevor Parscal
fd441d4b6d
Remapped image and html paths to new extension location.
2010-09-16 22:54:59 +00:00
Trevor Parscal
9862d7d871
Removed dependency on global variable "wgWikiEditorIconVersion"
2010-09-16 22:40:24 +00:00
Trevor Parscal
d555f70643
Removed unused code.
2010-09-16 22:20:43 +00:00
Trevor Parscal
ff8e204ccd
Table of contents is working now - fixed dependency issues and removed some globals that are no longer needed.
2010-09-16 22:20:17 +00:00
Trevor Parscal
94c8be537b
Moved one rule back.
2010-09-16 21:44:43 +00:00
Trevor Parscal
7d438b6006
Moving some CSS to the vector jquery ui skin, rather than keeping them here as WikiEditor only customizations
2010-09-16 21:43:11 +00:00
Trevor Parscal
81510294e1
Moved some images to the vector jquery ui skin, rather than keeping them here as WikiEditor only customizations
2010-09-16 21:40:56 +00:00
Trevor Parscal
6b8e5f2f54
This extension now functions. iframe dependendt modules need more work still.
2010-09-16 21:11:46 +00:00
Trevor Parscal
8be53e71af
Merged in changes from r73123
2010-09-16 17:22:23 +00:00
Trevor Parscal
a9c45c88e0
Lots of refactoring. This still does not work! But it's getting close.
2010-09-15 22:40:50 +00:00
Trevor Parscal
c45ca9a77e
Changed naming of files to follow new conventions.
2010-09-15 19:18:26 +00:00
Trevor Parscal
9d278e8dee
Copied over all the resources needed to make WikiEditor stand on it's own two feet. Lots more to do as far as organizing and fleshing out the extensions's PHP bits.
2010-09-15 03:08:35 +00:00
