Commit graph

3188 commits

Author SHA1 Message Date
Sam Wilson 623e6e7a46 Realtime Preview: remove the scroll linking between source and preview
It doesn't work well when there are infoboxes etc. and the actual
scroll behaviour is jerky and not very pleasing.

Bug: T294977
Change-Id: I8fbba61ddd902c16b3c63b41fc361afb5d1c1a1b
2022-06-17 11:09:04 +08:00
jenkins-bot 07402fc0a6 Merge "Log if an edit attempt began from the sticky header" 2022-06-16 18:01:23 +00:00
Translation updater bot 1038ab99f6 Localisation updates from https://translatewiki.net.
Change-Id: I51ca6cd3cbc09b7192295ff8dbde33a175c52bec
2022-06-16 09:25:47 +02:00
David Lynch fd0841a899 Log if an edit attempt began from the sticky header
Bug: T298634
Depends-On: I871494b6e783018b1433f294e09b0d53dded6c3d
Change-Id: I07d3c91a63e78f091a1046ca49830e141f6ef8d4
2022-06-15 02:54:03 -05:00
Translation updater bot 1770eeaa5d Localisation updates from https://translatewiki.net.
Change-Id: I9f6224bd80038404e7f446e11a51d85cb02cbdca
2022-06-15 08:42:40 +02:00
Translation updater bot 0bba508498 Localisation updates from https://translatewiki.net.
Change-Id: I6416da3bbbcb9b97129b244d29c4da125f106be3
2022-06-14 08:49:27 +02:00
Translation updater bot 6b1698d408 Localisation updates from https://translatewiki.net.
Change-Id: I97bd6717443110c90787d9cdcce2b282d2a12d08
2022-06-13 08:29:24 +02:00
jenkins-bot 82e7d45aa5 Merge "Realtime preview: match scroll positions between textarea and preview" 2022-06-10 19:42:50 +00:00
jenkins-bot 9f0a13b3b0 Merge "URI-decode external link page names when turning them into local links" 2022-06-10 13:35:01 +00:00
Sam Wilson 9a5e7dd919 Realtime preview: allow loading as a gadget
* Prevent the realtimepreview module loading on anything
  other than wikitext pages (as is already done PHP-side
  but that is bypassed when loaded as a gadget).
* Give the #wpTextbox1 a class so we don't always style it.

Bug: T307039
Bug: T308176
Bug: T309330
Change-Id: I26111a61c8cf37520b3619faf09d76445973edd3
2022-06-09 17:27:24 +08:00
Sam Wilson e575822c73 Realtime preview: match scroll positions between textarea and preview
When either the textarea or the preview pane is scrolled, match the
other to the same vertical scroll percentage.

Bug: T294977
Change-Id: Ieda15868162caf06ef9099065ba55cfd8d8bfd0f
2022-06-09 12:57:54 +08:00
Translation updater bot bdc97feba3 Localisation updates from https://translatewiki.net.
Change-Id: I63b9ba8685a9600976f87a964452b35146fac6aa
2022-06-08 08:28:24 +02:00
Translation updater bot 0e16ebf47b Localisation updates from https://translatewiki.net.
Change-Id: I0c2b04c689f28b9b2a12ddd6c55f64f15fd02d30
2022-06-07 10:01:55 +02:00
Translation updater bot 1ee04337c9 Localisation updates from https://translatewiki.net.
Change-Id: I4aa6d0d721213a6ecc8237f99454c148338ab4fc
2022-06-06 09:27:09 +02:00
Translation updater bot d33cd27b0a Localisation updates from https://translatewiki.net.
Change-Id: I9b9c1e603df57c6fe848661648554ae42629f465
2022-06-02 08:15:52 +02:00
Sam Wilson 4fc6cb53b8 Realtime preview: keep original scroll position when enabling/disabling
Because the DOM and layout changes reset the scroll position of the
editing text area, it must be manually saved before enabling/disabling
and reset afterwards.

Bug: T294977
Change-Id: I7722213e682401d29b6b53d672a487da042be6a9
2022-06-01 10:41:54 +00:00
jenkins-bot 111185fb56 Merge "Realtime Preview onboarding popup" 2022-06-01 10:39:20 +00:00
Translation updater bot ef783c3f4c Localisation updates from https://translatewiki.net.
Change-Id: I37f74a3123ce6a0c461a5826bc160758cb02777a
2022-06-01 08:21:23 +02:00
Sam Wilson 4ff946aea4 Realtime Preview onboarding popup
Add a pulsating blue dot to the Realtime Preview toolbar button
that displays an onboarding popup when clicked and disappears
forever when dismissed.

Bug: T294589
Change-Id: I7f4dd0858349b0e7c4f4bedea5c7a62a51c6fa3a
2022-06-01 14:11:49 +08:00
Translation updater bot 24ddf194a8 Localisation updates from https://translatewiki.net.
Change-Id: Iff62e0662b784b49df7164230c53b82f3bc972f9
2022-05-30 09:24:36 +02:00
libraryupgrader bcd481e215 build: Updating grunt to 1.5.3
Change-Id: Id32cc655547a44328466e14a86c79dada78ffe48
2022-05-27 04:15:59 +00:00
Translation updater bot 86619d9b09 Localisation updates from https://translatewiki.net.
Change-Id: I686d73badb30ed2f27e3c6276e6e1d619ecad106
2022-05-26 08:52:22 +02:00
jenkins-bot b62c5cf06a Merge "Use new ResourceLoader namespace" 2022-05-25 02:16:51 +00:00
Tim Starling 6b2cca3b2b Use new ResourceLoader namespace
Extensions using Phan need to be updated simultaneously with core due
to T308443.

Bug: T308718
Depends-On: Id08a220e1d6085e2b33f3f6c9d0e3935a4204659
Change-Id: I289b8cb5e74b5d87e26bfe6b779a22eaaa1071ee
2022-05-24 22:59:49 +00:00
Translation updater bot 395a056291 Localisation updates from https://translatewiki.net.
Change-Id: I21b2f832be97bf8de954ea331fd240155d1bf930
2022-05-23 08:17:54 +02:00
libraryupgrader a05273e3c2 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 38.0.0 → 39.0.0
* php-parallel-lint/php-console-highlighter: 0.5.0 → 1.0.0
* php-parallel-lint/php-parallel-lint: 1.3.1 → 1.3.2

npm:
* grunt: 1.4.1 → 1.5.2
* stylelint-config-wikimedia: 0.12.2 → 0.13.0
* async: 3.2.0 → 3.2.3
  * https://github.com/advisories/GHSA-fwr7-v2mv-hh25

Additional changes:
* Set `name` in package.json.

Change-Id: Ife7f40d1f7d18c3ce66003aa50ac347d62441346
2022-05-21 17:46:08 +00:00
jenkins-bot 54019ffc38 Merge "Update schema logging of bucket for new DiscussionTools A/B test" 2022-05-20 22:28:18 +00:00
Translation updater bot 3769bb9e07 Localisation updates from https://translatewiki.net.
Change-Id: I18b4b711e85167905032bf38e51435515503ed9d
2022-05-20 08:37:42 +02:00
David Lynch ce2ecf084f Update schema logging of bucket for new DiscussionTools A/B test
Bug: T304030
Depends-On: I5e57bb9b7958576f3a04373748331a86f4626fb5
Change-Id: I084d26c95d5be78eddb4edd1b42aa52eef909356
2022-05-19 09:50:04 -05:00
Translation updater bot d3850e5262 Localisation updates from https://translatewiki.net.
Change-Id: I83b84edca3640a3116faed56482ef8bddeb4e89a
2022-05-17 08:29:17 +02:00
Translation updater bot 5f7581d1c5 Localisation updates from https://translatewiki.net.
Change-Id: I921f0bf0cc5cfeb380459482ebda9de1c6631ebd
2022-05-16 08:25:38 +02:00
Translation updater bot a18b43a9b9 Localisation updates from https://translatewiki.net.
Change-Id: I4fba47951a57a4c8e1332723b3322b8593926e85
2022-05-13 08:27:11 +02:00
Translation updater bot c5aa5ae1fe Localisation updates from https://translatewiki.net.
Change-Id: I39f84f382bac2ec78a302f787cab50d863975442
2022-05-12 08:14:04 +02:00
jenkins-bot 49a7811277 Merge "Realtime preview: Visual adjustments on handlebars" 2022-05-11 10:58:19 +00:00
samtar b49e0a9d6c Realtime preview: Visual adjustments on handlebars
Set both drag element lengths to 52px (@affordance-length)
Set the margin on (.ext-WikiEditor-ResizingDragBar span) to 2px
Set (.ext-WikiEditor-ResizingDragBar-ew) background-color to
@colorGray15 (i.e. #F8F9FA)
Remove legacy comment.

Bug: T307105
Change-Id: If0087398920c7ad92e5a2cd1ee5c178644f8d95b
2022-05-11 10:00:42 +01:00
Translation updater bot fe69f2bc51 Localisation updates from https://translatewiki.net.
Change-Id: Ibfed79ef0d511a0edeecaf0885b5cd80805d16d3
2022-05-11 08:12:23 +02:00
Translation updater bot 70814eb0cc Localisation updates from https://translatewiki.net.
Change-Id: If6d91c0c8666d577d4e17babcd497a7d3da50092
2022-05-10 08:10:13 +02:00
Translation updater bot 008edb592d Localisation updates from https://translatewiki.net.
Change-Id: I0851789edcc36e6a2ebde9a24d5943da0e562eb2
2022-05-09 08:12:37 +02:00
samtar 45501cfd92 Realtime preview: Suppress reopening pane
Change the handling of the manual reload button's accessKey to
only refresh the preview if the pane is currently open.
Duplicate change to ManualWidget's handler.

Bug: T307805
Change-Id: I0f07ff346eef4bd93d13d55548381a71c0f660d3
2022-05-07 01:21:40 +01:00
Sam Wilson be4ee228aa Realtime Preview: show and hide preview and error areas appropriately
* Always hide the error message after a successful preview.
* Before previewing, make sure the preview node is un-hidden, in
  case it was previously hidden by showError().
* Stop checkResponseTimes() from hiding any error (it only handles the
  manual mode).
* Stop showError() from hiding the manual bar (it's okay to see both).

Bug: T306965
Change-Id: Ic2ad52fea41070adb196ef2fbd740e808d373e5e
2022-05-06 08:23:50 +08:00
Sam Wilson 96c905f1dc Realtime Preview: Make whole manual-loading bar clickable
Make the manual-mode loading bar clickable by turing it all into
an anchor element with various mixins for functionality.

Also adds a tooltip to the whole bar, and makes the same accesskey
work (including when the preview pane is closed).

Bug: T306590
Bug: T306906
Bug: T306880
Change-Id: I915a430300c75256d89b929e3925d0ea714807bb
2022-05-06 07:32:37 +08:00
samtar 755f984335 Realtime preview: set minimal resize limit
Add a minimal resize limit on the preview pane (`.ext-WikiEditor-twopanes-pane2`) to 248px

Bug: T307105
Change-Id: If05376571bb0b223edac48adecbe124e01293c7a
2022-05-05 19:53:40 +00:00
jenkins-bot 19f784233a Merge "Add JSDoc configuration and test" 2022-05-05 19:50:46 +00:00
jenkins-bot 8840c90692 Merge "tests: Remove use of QUnit 1.x setup()/teardown()" 2022-05-04 11:34:43 +00:00
jenkins-bot 6a91c1f3ea Merge "Realtime preview: improve toolbar button style" 2022-05-04 11:31:57 +00:00
Translation updater bot 8c3608cb25 Localisation updates from https://translatewiki.net.
Change-Id: Ia52c284389d86c951aa4f69cbb96a43c4829134d
2022-05-04 08:19:07 +02:00
Sam Wilson 9921163d54 Add JSDoc configuration and test
Bug: T307415
Change-Id: I770677608b5d2e4532528467d1c4141019dd01e4
2022-05-03 15:28:02 +08:00
Translation updater bot c23c11ae75 Localisation updates from https://translatewiki.net.
Change-Id: I1f378bb447f2303cc913bfc1aa72ecf9a6eb1da4
2022-05-03 08:45:56 +02:00
Sam Wilson 42192e75c9 Invert RealtimePreview.setEnabled parameter meaning
To make it clearer that setEnabled(true) enables the feature, and
setEnabled(false) disables it, invert the function of the first
parameter. Also improve jsDoc parameter documentation.

Follow-up: I4615f629a0c97fb325721bbddee5c9eb074c3a5c
Change-Id: Icb84bcf0624774b9a7002110f1fac31bf48ebd1d
2022-05-03 13:18:05 +08:00
jenkins-bot 43d15ff91e Merge "Realtime preview: disable preview when screen is small" 2022-05-03 02:49:36 +00:00