Commit graph

30 commits

Author SHA1 Message Date
Ed Sanders 796d82a7ab ESLint: Enforce no-var and autofix
Change-Id: I6f2a1e11acdcdb70902357316b504f903abe8bca
2024-11-15 11:08:22 +00:00
Ed Sanders 5fc902bd9c ESLint: Update to ES6 and autofix
Change-Id: I38afd9a3340ca9a85e7204978cae00b48513f5ca
2024-11-15 11:07:55 +00:00
Timo Tijhof 17fec690b0 tests: Remove use of QUnit 1.x setup()/teardown()
No longer supported upstream. Was kept compatible via MW core
testrunner.js, which I'd like to phase out so that our custom wrapper
can be removed, and thus other features like `QUnit.module.skip()`
become available.

While at it, also convert the file from an ad-hoc closure to using
the QUnit.module() scope and hooks object, as per
<https://api.qunitjs.com/QUnit/module/>.

Bug: T250045
Change-Id: I8c04c56cf5eec3f19ef12a803a192cd824b82f81
2022-05-03 01:22:12 +02:00
Thiemo Kreuz dbb6583bbb Streamline smaller pieces of JavaScript code
The main idea is to make the code shorter and easier to read.

One notable change is to use .test() for boolean tests instead of the
actual .match() function.

Change-Id: Ic43442b75f839906b644d4586c907601f4d5d521
2022-03-04 09:22:07 +00:00
Ed Sanders 7fea791042 build: Update eslint-config-wikimedia to 0.21.0
Change-Id: I87bca80d107c965296af74e16961cd855d72b806
2022-02-07 17:27:27 +00:00
Inductiveload b87612d937 Allow a free-text string 'title' field when adding characters
When adding characters to the WikiEditor toolbar, it's possible to set
titleMsg, but it's not possible to set a free-form string title. This is
rather limiting for personal or site-local scripts which might wish to
use a title tooltip but not be able to set a MediaWiki message.

This commit adds the ability to pass a 'title' field of a character
definition object. If both 'title' and 'titleMsg' are defined, 'titleMsg'
is used.

Bug: T292434
Change-Id: I00775d5e4690c0fd45c20639a122c39dc756135e
2021-10-04 15:48:55 +01:00
Kunal Mehta 5f53eb3a2c Upgrade to new phan
Bug: T216951
Change-Id: I05416b7244bf55a600d508ca253fec8410abbbc7
2019-03-16 21:44:36 -07:00
Ed Sanders 583ad04b87 build: Update eslint-config-wikimedia to 0.10.0
Change-Id: I5fea8a1d6c91ea69c3490101ea38ce4626bd7e11
2019-01-08 23:32:56 +00:00
Ed Sanders 4fa41179e8 Remove obsolete aliases from closures
Bug: T208951
Change-Id: I0b2993912de221e810414e46708c19be163922f6
2018-11-12 22:28:40 +00:00
Roan Kattouw 55b89c1ede Oversample Schema:Edit events when configured to do so
Respect the config var exported by WikimediaEvents that, if set to true,
forces oversampling. When oversampling, all events are logged even if
they would have been sampled out. The isOversample property is set to
true if the event was oversampled and would not otherwise have been
logged.

Bug: T206543
Depends-On: I5fdf5fdd2dc0d99a0a0d7eb7ab2e3dce4798009b
Change-Id: I7e504884a888c4d080cd4762549b72489126ed65
2018-10-18 10:58:45 -07:00
Ed Sanders 5a5d351aaf build: Update linters
Change-Id: Ib52195a49c7333ab0cc8a703f987126cfc4e603e
2018-09-14 13:19:52 +01:00
Kunal Mehta 9bf8876fe9 build: Updating mediawiki/mediawiki-phan-config to 0.2.0
Change-Id: I79951e606f3a3aadcd4873e4b15cdeb987ca662a
2018-04-05 17:25:18 -07:00
Kunal Mehta c8e0ad5b1f Migrate to mediawiki-phan-config
Change-Id: I1f604b797ec97511cd1b5a226d9851d94cbab416
2018-02-16 14:08:08 -08:00
Rafid Aslam 272c20326f Add phan configuration for static analysis
Bug: T179554
Change-Id: Id8d4def828976c1ecbaf83e23d9eb445bdb28cd8
2017-12-25 17:03:54 +07:00
WMDE-Fisch bd35af14dd Fix Qunit tests to work with 2.x
Tests broke with Ibc0909ed5fbde715814b0ddb1a1d1c9668d10a85 .

Bug: T170515
Change-Id: Ib132b5a73540a0e78a4498f52c5f1c57defe05c3
2017-10-25 13:24:53 +02:00
Ed Sanders 7eed707a48 Replace jshint/jscs with eslint/stylelint
Change-Id: Ife5e782bd5513e0496e384655b9b203de5c841a5
2016-11-21 21:02:38 +00:00
paladox bdb67f719c build: Test JS code with jshint and jscs via npm
Change-Id: I039bc4c17fbba3c74a5050066b20af05434ca482
2015-11-18 12:06:36 +00:00
Kunal Mehta 59e7d9546f Remove unused code, pass phpcs
* No features have a 'configurations' setting, nor can I see any
client-side code looking for any. Was triggering phpcs because of
the 'global $$configuration;' line, which didn't start with "$wg".
* Remove unused selenium tests that were also triggering phpcs.
* Add composer.lock and vendor/ to .gitignore

Change-Id: If06a08b6a7c232ac69f9dff569ffa3e1c93ff0c5
2015-03-25 15:27:10 -07:00
Fomafix d16dfb0ad5 Style code
* Fix errors and warnings from phpcs.
* Add commas at end of lines for arrays in PHP.
* Add space between // and comment.
* Add space between ) and {.
* Use tabs instead of spaces for indenting.
* Break lines in PHP with more than 100 characters.
* Remove double spaces and spaces at end of line.
* Remove spaces before comma.
* Fix some typos.

Change-Id: I9c014bdfa9832fa6a20d0190fe2fc668983d0fb9
2015-03-14 15:49:04 +00:00
Alexander Jones 55c6e1271f Add QUnit test for ext.wikiEditor.toolbar
This patch replaces the manually operated test module for ext.wikiEditor.toolbar
with one based on QUnit. The new test suite uncovered a bug with the removeFromToolbar
API function in jquery.wikiEditor.toolbar, which prevented the removal of select buttons
from the toolbar. This issue has also been fixed in this commit. .jshintrc was updated
to ignore the new QUnit global.

Bug: T39485
Change-Id: Icef3debcffa484a8d78628bcd9da0892b750bb40
2014-11-29 14:12:26 -06:00
Derk-Jan Hartman 55929241a3 WikiEditor: Remove unmaintained highlight plugin
Change-Id: I9740a1197209f177217b034e8b94a90b3905a560
2014-04-03 17:12:07 +02:00
Derk-Jan Hartman e53521b32b WikiEditor: Remove unmaintained template editor modules
Change-Id: I47119d6cfdde4b40ff5b07be0c7d327b80598142
2014-04-03 17:11:10 +02:00
Derk-Jan Hartman 9bb94e8319 WikiEditor: Remove old unmaintained ToC module
Change-Id: I0f53a68e50fc950d7f407ee81b2bf0d81ef4948d
2014-04-03 17:02:32 +02:00
Siebrand Mazeland c93dc3714c Remove unnecessary colon and redundant closing tags
Change-Id: Icc9d4d647ce189ba8044627bcdface0c7a33e31d
2012-08-26 01:01:36 +02:00
Sam Reed 53a10fc446 Fix more comments 2011-10-14 21:30:16 +00:00
Siebrand Mazeland cc71ec5354 * bump version to 0.3.1
* stylize.php
2011-09-13 08:56:32 +00:00
Priyanka Dhanda dd5add4e37 Tests for Toolbar dialogs in the wikieditor. Migrated part of Calcey's tests from svn.wikimedia.org/svnroot/mediawiki/trunk/testing/selenium/UsabilityInitiative/WikiAutomationTC/testCases 2010-10-14 16:42:56 +00:00
Trevor Parscal 089b73aa5d * Moved ResourceLoader modules into the ext.* space - this is the convention that should be followed in the future
* Moved test resource to the modules folder and registered it
* Fixed tests file to use $ not $j
* Cleaned up syntax in module definitions
2010-09-20 20:06:18 +00:00
Trevor Parscal 8be53e71af Merged in changes from r73123 2010-09-16 17:22:23 +00:00
Trevor Parscal 9d278e8dee Copied over all the resources needed to make WikiEditor stand on it's own two feet. Lots more to do as far as organizing and fleshing out the extensions's PHP bits. 2010-09-15 03:08:35 +00:00