Commit graph

259 commits

Author SHA1 Message Date
Fomafix 5c36a20623 Move hardcoded parsed thumbnail html from i18n to config
Also update the actual HTML with what the current parser outputs:
* width:104px -> width:102px (2px in addition to 100px image width)
* No more "title" attribute on the outer <a>.

And reduce duplication in the message:
* Re-use "thumbnail-more" message.
* Re-use "wikieditor-toolbar-help-content-file-caption" message.

Change-Id: I25f0763b2274ebdcf681c78af277a9be302350a1
2015-03-14 20:41:11 +01:00
Tiziano Müller 51f3d145bc Reformat the license warning only if available
If the WikiEditor is enabled for Semantic Forms Text Area Input there is
no license warning div around.

Change-Id: I8d39f8d47a73cdc2d4be198061e8f68f22c0c308
2015-03-14 18:10:52 +00:00
Fomafix 83c079ceb6 Reuse variable profile instead of $.client.profile()
Change-Id: I66543bd0838b062bea08ca4b5f4fded41ff835cc
2015-03-14 18:01:58 +00:00
Fomafix d16dfb0ad5 Style code
* Fix errors and warnings from phpcs.
* Add commas at end of lines for arrays in PHP.
* Add space between // and comment.
* Add space between ) and {.
* Use tabs instead of spaces for indenting.
* Break lines in PHP with more than 100 characters.
* Remove double spaces and spaces at end of line.
* Remove spaces before comma.
* Fix some typos.

Change-Id: I9c014bdfa9832fa6a20d0190fe2fc668983d0fb9
2015-03-14 15:49:04 +00:00
Alex Monk ef7c4ce2be Don't try to load edit schema if it's not installed
It would only be installed by the WikimediaEvents extension.

Change-Id: I0a1841ad7639765cedf6294d62104f9aedb36d83
2015-03-12 16:49:50 +00:00
Alex Monk 74da530f2d Schema:Edit instrumentation
Depends on Ib8612626

Bug: T88027
Change-Id: I67f1000d23cb257df29d5d4be8ae85764458e6c1
2015-03-10 14:56:45 +01:00
paladox 3f692d9e15 Convert .css to .less
* This patch convert .css to .less
* Semantic changes are avoided, but there are minor
  tweaks such as capitalization and ordering.

Change-Id: Iebff0f8e3d87bb792093a10d87f33540aca301d5
2015-03-09 21:24:23 -04:00
jenkins-bot 82a290b452 Merge "Skip an old IE 8 bug workaround in WikiEditor on IE 11/Spartan" 2015-02-21 22:36:26 +00:00
Brion Vibber ab2c7e3ce6 Skip an old IE 8 bug workaround in WikiEditor on IE 11/Spartan
An early version of WikiEditor added a workaround for a reported
bug with IE 8 where textarea scroll and selection state was lost
when the contents were modified.

This doesn't seem to be needed on modern versions of IE such as 11
and above and the newer 'Edge' HTML engine mode in Windows 10.

Actually, I can't reproduce it in Windows 7 or XP with IE 8 either
from the original bugs, but just in case it's needed on some particular
version that we don't know about I've only added a check for modern
IEs, which is already in use on other old-IE workarounds in the
module.

Bug: T88875
Change-Id: I25b667a8d8378c417441adee5d97571c71a1c8c7
2015-02-19 21:01:21 +00:00
Brion Vibber 4f8ad57aaf Enable search-replace dialog on IE 11+
The search-replace box in WikiEditor was blacklisted entirely from
MSIE, although it appears to work fine in IE 11 on Windows 8.1
and Windows 10 Tech Preview.

IE/Spartan team specifically requested a fix for this bug; looks like
it's an easy case of adjusting the blacklist with a version component...

(Note that in RTL the dialog positioning is bad, but that affects
other WikiEditor dialogs too.)

Bug: T88875
Change-Id: I4cf1eb76cc8a788cab233fe9ed04aaeba4af5725
2015-02-19 12:55:29 -08:00
Fomafix d67b50eeb5 Remove color overwrite for dialog header border bottom
This changes the color of the line under the hader of the dialog boxes
from #6bc8f3 to the default #aed0ea.
This difference is nearly not recognizable and it is not worth to overwrite
the default color.

Change-Id: I88580ab74fc158ec1a498fc489fbdd9cd5ba897a
2015-02-18 21:27:37 +00:00
Fomafix 6986f8dba8 Remove CSS definition for tables in dialogs
The only dialog with a table is the table creator dialog.
For this table a more specific definition exist in
jquery.wikiEditor.dialogs.config.css
These rules overwrite all here removed definitions except of
  wikiEditor-toolbar-dialog table { margin-top: 0.75em; }
Without this definition the margin-top slightly increase to the
definition from .wikitable with margin-top: 1em.

Change-Id: I0aab246db05cb4330287666f6a71b56d6b88b0af
2015-02-18 20:09:21 +00:00
Matthew Flaschen 736b94f827 Update autoMsg doc for plain call
* Reflect that we're now calling mw.message( ... ).plain()
* Remove vague statement about "may eventually become a wrapper for
  some kind of core MW functionality."

Change-Id: Ibe743162c1f72bb3977ec16e2ba4b023a66e3907
2015-02-14 22:32:35 -05:00
jenkins-bot 51cc8a3d21 Merge "Move style from JavaScript to CSS" 2015-02-08 19:55:44 +00:00
jenkins-bot de5f3932b9 Merge "Allow a resizeable toolbar index" 2015-02-05 12:44:02 +00:00
Fomafix 78bdeffcc6 Use "obj.hasOwnProperty( prop )" instead of "prop in obj"
'constructor' in {}; // true
Object.prototype.hasOwnProperty( {}, 'constructor' ); // false

Bug: T86643
Change-Id: I4356608956d722dc086e6876a53fdd93435c6f0a
2015-02-05 13:34:03 +01:00
jenkins-bot d70fe376eb Merge "Use sprite as button icon where possible" 2015-02-05 12:25:11 +00:00
Fomafix da5c8abe9e Allow a resizeable toolbar index
Change-Id: I329a143e2ee0a21bee4a9b146c28e6e8df58d570
2015-01-29 08:45:08 +00:00
jenkins-bot bca8c3cf69 Merge "Prevent line wrapping for link syntax help column" 2015-01-24 08:01:57 +00:00
jenkins-bot 6433e68160 Merge "Remove style for wpSummary and wpSummaryLabel" 2015-01-24 08:01:03 +00:00
jenkins-bot c9b6a851b4 Merge "Use font-family: monospace, Courier" 2015-01-24 07:59:52 +00:00
Fomafix 17cb22e4f3 Use sprite as button icon where possible
The icon for italic in language 'os' exists in the sprite like for 'ru'.

Change-Id: I126b3fbc2246b485c2b7e8572037447498821e35
2015-01-21 18:31:33 +00:00
Fomafix 342cebaba6 Use font-family: monospace, Courier
Use
   font-family: monospace, Courier
instead of
   font-family: monospace, "Courier New"
like in resources/src/mediawiki.skinning/elements.css from core.

Change-Id: I87145f8254d34b6d00d76f22c3d0819b9ea5839f
2015-01-14 10:26:55 +00:00
Fomafix 5186f34fd3 Prevent line wrapping for link syntax help column
Bug: T33649
Change-Id: Ia814105aaac986e4ba216d68b1a8afaf38ddfdc1
2015-01-14 09:45:55 +00:00
Fomafix 000031fd48 Move style from JavaScript to CSS
Change-Id: I1bf4b886e3b9b789df377dbdd2df94eb80dd61d1
2015-01-14 07:51:24 +00:00
Fomafix 790a1af231 Fix whitespaces in JavaScript
* Use a singe space as whitespace.
* Remove space before colon when not used as ternary operator

Change-Id: I6391bbcf10d26fadf82686d7ff226b773868415c
2015-01-14 07:14:44 +00:00
Fomafix 216a271213 jquery.wikiEditor.toolbar.css: Remove selectors without prefix "cell-"
The selectors
.wikiEditor-ui-toolbar .section-help .page-table td.description
.wikiEditor-ui-toolbar .section-help .page-table td.syntax
.wikiEditor-ui-toolbar .section-help .page-table td.result
are not used. The used selectors have the prefix "cell-":
.wikiEditor-ui-toolbar .section-help .page-table td.cell-description
.wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax
.wikiEditor-ui-toolbar .section-help .page-table td.cell-result

Also add the missing selector
.wikiEditor-ui-toolbar .section-help .page-table td.cell-description

Change-Id: I26a131f269c6d0ee11015e388224dae79de4494f
2015-01-14 00:16:38 +00:00
Fomafix 169c4bfb7d Fix whitespaces for JavaScript and CSS
Change-Id: I3f6bf0d9e788cdca19b2b699fcb0a7b5ceab2a93
2015-01-13 09:14:53 +00:00
Fomafix 90592de211 Remove style for wpSummary and wpSummaryLabel
WikiEditor should not responsible for the style of the summary.

Change-Id: I8a6f3d3b6212a105fa3fa3326eb35c3e7e1e5c0b
2015-01-12 06:57:41 +00:00
jenkins-bot ebb75b8815 Merge "Toolbar: Reset lineheight for character cells" 2015-01-09 23:14:13 +00:00
Fomafix 77fca50876 Use mw.Api() instead of $.ajax()
Add dependency to the already used module 'mediawiki.api'.

Change-Id: I236b3be5f64ac92f6710e5c690b0cc1800ceb1c5
2015-01-07 18:25:47 +00:00
Derk-Jan Hartman 2946fcd56d Remove reference to magnify-clip.png
magnify-clip.png was recently removed from the core styles directory,
but the Help panel of the WikiEditor still references it by way of i18n
message: wikieditor-toolbar-help-content-file-result

Also remove unused local copy

Bug: T85920
Change-Id: Icc17092c0f854360b2f2999b8f153827bf194c0c
2015-01-07 10:19:35 +01:00
Derk-Jan Hartman 4e65f2b204 Toolbar: Reset lineheight for character cells
Bug: T78354
Change-Id: I2f004a29b19d5629ba78a94b4cd26bb91d5a8747
2015-01-06 17:41:16 +01:00
Derk-Jan Hartman 3e04196b79 Toolbar help: Make magic word from help string a param
Instead of having this magic word in the translation message, make it a
parameter of the translation message and retrieve it from
wgWikiEditorMagicWords.

Bug: T40831
Change-Id: Id3155221aa61bc86da2d90000dedab36cbe9dd96
2014-12-08 12:22:49 +01:00
Fomafix bfe2fc6c4e Workaround for a scrolling bug in IE8 on resize
Bug: T63910
Change-Id: I6dacc1ed2f2fdf4ea615a477b711dc78667bae68
2014-12-06 12:40:50 +00:00
jenkins-bot ea569a993a Merge "Remove previewDialog" 2014-12-05 13:03:26 +00:00
Derk-Jan Hartman 360419f397 Remove previewDialog
This was never launched, and is no longer working either.

Change-Id: Ic49e84b8a91da701673949a8d441c788a4feaa22
2014-11-30 20:25:22 +01:00
Alexander Jones 55c6e1271f Add QUnit test for ext.wikiEditor.toolbar
This patch replaces the manually operated test module for ext.wikiEditor.toolbar
with one based on QUnit. The new test suite uncovered a bug with the removeFromToolbar
API function in jquery.wikiEditor.toolbar, which prevented the removal of select buttons
from the toolbar. This issue has also been fixed in this commit. .jshintrc was updated
to ignore the new QUnit global.

Bug: T39485
Change-Id: Icef3debcffa484a8d78628bcd9da0892b750bb40
2014-11-29 14:12:26 -06:00
Derk-Jan Hartman 4af678cdd2 Preview: Add content clears after side-by-side preview
Change-Id: Ib6147e38aa98a5498300513da3557ce74af1252d
2014-11-10 21:02:43 +01:00
Derk-Jan Hartman c618166249 Revert "Add SVG versions of toolbar icons"
There were issues with shadows, and the sprite creating weird
offsetted buttons on Chrome.
Subsequent attempts have been incomplete at solving these, so
reverting this and hoping that the next person to attempt a conversion
to SVG is more successful.

This reverts commit e027051c58.

Bug: 35342
Change-Id: Id296899a2c3746957c17068ab17ca8266f6ff0d3
2014-11-04 22:21:05 +00:00
Florianschmidtwelzow e7251d7dc5 Remove padding from Textbox
The padding for wpTextbox1 (on Editpage) conflicts with mediawikui.

Bug: 70194
Change-Id: I251256ef17a4ac978cb2d7bbd62daaa84fcc4843
2014-09-14 15:44:10 +02:00
Derk-Jan Hartman 70194d574e Dialogs: Reset values of file insertion dialog properly
Bug: 67111
Change-Id: I63a5cac9108cf9e6966964347407cc63fc0fb9b5
2014-08-14 22:02:16 +02:00
jenkins-bot 388482c0b8 Merge "Enable WikiEditor toolbar on iOS" 2014-06-03 18:59:58 +00:00
Derk-Jan Hartman f64a3c26c6 Enable WikiEditor toolbar on iOS
Since we now have a full fledged mobile solution, I think we should
strive to have the site 'proper' work as much on any platform as
possible.

WikiEditor traditionally was not loaded on iOS.
No one really knows why this was not loaded. It can have been bugs or
just to 'slim down'. It works on iOS 6 and iOS 7, so for that reason
I'm now changing the blacklist in this respect. It might work with
earlier versions, but I can't really test that right now.

Bug: 63277
Change-Id: I605eb0e093b84203f1157d9e20788eaa0040ddbf
2014-05-26 14:34:17 +00:00
Derk-Jan Hartman 44c56d482c Convert from show()/hide() to using classes
jQuery's show/hide/fadeIn/fadeOut methods makes changes to the
style attributes of elements. That makes them rather hard to override
their visibility, without adding an entire API to the module to do so.

This replaces the default animations with one using classes to control
visibility and only animates the animatable properties using
the style attributes.

Follow-up to: Iadaae3fb9ae1899e12605d653b2688616b8f7c40

Change-Id: I4652ade66c6de864ee3e74b3817ed9b93967ce3d
2014-05-23 16:06:16 +02:00
Derk-Jan Hartman 346a100248 Also remove NToC and TemplateEditor images
In I0f53a68e50fc950d7f407ee81b2bf0d81ef4948d and
I47119d6cfdde4b40ff5b07be0c7d327b80598142 I forgot to remove the images
of the corresponding modules.

Change-Id: I8de59f6ce54d0cc7f67f56853386d4338c693b98
2014-05-14 15:54:50 +02:00
Timo Tijhof b965e0af4f jquery.wikiEditor.toolbar: Clean up target variable
Follows-up 5667dfcd54.

Change-Id: Ib2365aa6ab626717d346ab2e299c174bebfff506
2014-05-09 12:26:15 +02:00
jenkins-bot 887dcfcbc9 Merge "Repair removeFromToolbar() to handle image buttons" 2014-05-09 10:23:04 +00:00
jenkins-bot ba9cbdaa35 Merge "Prevent style jumping in WikiEditor" 2014-05-06 16:53:46 +00:00
Derk-Jan Hartman f0505e6dee Prevent style jumping in WikiEditor
Add a new styles module. This module makes sure that the textarea is
already properly styled (jumping lineheight bug) before we start the
JS. Also hide the toolbar before it's styles have finished loading, so
you don't see it being constructed on the fly. Move inline styling for
the old toolbar into this stylesheet as well.

Bug: 47708
Change-Id: I40bec0a24dbd295db301e7faefb93d8991981acb
2014-05-06 15:03:01 +02:00