Commit graph

2866 commits

Author SHA1 Message Date
jenkins-bot b62c5cf06a Merge "Use new ResourceLoader namespace" 2022-05-25 02:16:51 +00:00
Tim Starling 6b2cca3b2b Use new ResourceLoader namespace
Extensions using Phan need to be updated simultaneously with core due
to T308443.

Bug: T308718
Depends-On: Id08a220e1d6085e2b33f3f6c9d0e3935a4204659
Change-Id: I289b8cb5e74b5d87e26bfe6b779a22eaaa1071ee
2022-05-24 22:59:49 +00:00
Translation updater bot 395a056291 Localisation updates from https://translatewiki.net.
Change-Id: I21b2f832be97bf8de954ea331fd240155d1bf930
2022-05-23 08:17:54 +02:00
libraryupgrader a05273e3c2 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 38.0.0 → 39.0.0
* php-parallel-lint/php-console-highlighter: 0.5.0 → 1.0.0
* php-parallel-lint/php-parallel-lint: 1.3.1 → 1.3.2

npm:
* grunt: 1.4.1 → 1.5.2
* stylelint-config-wikimedia: 0.12.2 → 0.13.0
* async: 3.2.0 → 3.2.3
  * https://github.com/advisories/GHSA-fwr7-v2mv-hh25

Additional changes:
* Set `name` in package.json.

Change-Id: Ife7f40d1f7d18c3ce66003aa50ac347d62441346
2022-05-21 17:46:08 +00:00
jenkins-bot 54019ffc38 Merge "Update schema logging of bucket for new DiscussionTools A/B test" 2022-05-20 22:28:18 +00:00
Translation updater bot 3769bb9e07 Localisation updates from https://translatewiki.net.
Change-Id: I18b4b711e85167905032bf38e51435515503ed9d
2022-05-20 08:37:42 +02:00
David Lynch ce2ecf084f Update schema logging of bucket for new DiscussionTools A/B test
Bug: T304030
Depends-On: I5e57bb9b7958576f3a04373748331a86f4626fb5
Change-Id: I084d26c95d5be78eddb4edd1b42aa52eef909356
2022-05-19 09:50:04 -05:00
Translation updater bot d3850e5262 Localisation updates from https://translatewiki.net.
Change-Id: I83b84edca3640a3116faed56482ef8bddeb4e89a
2022-05-17 08:29:17 +02:00
Translation updater bot 5f7581d1c5 Localisation updates from https://translatewiki.net.
Change-Id: I921f0bf0cc5cfeb380459482ebda9de1c6631ebd
2022-05-16 08:25:38 +02:00
Translation updater bot a18b43a9b9 Localisation updates from https://translatewiki.net.
Change-Id: I4fba47951a57a4c8e1332723b3322b8593926e85
2022-05-13 08:27:11 +02:00
Translation updater bot c5aa5ae1fe Localisation updates from https://translatewiki.net.
Change-Id: I39f84f382bac2ec78a302f787cab50d863975442
2022-05-12 08:14:04 +02:00
jenkins-bot 49a7811277 Merge "Realtime preview: Visual adjustments on handlebars" 2022-05-11 10:58:19 +00:00
samtar b49e0a9d6c Realtime preview: Visual adjustments on handlebars
Set both drag element lengths to 52px (@affordance-length)
Set the margin on (.ext-WikiEditor-ResizingDragBar span) to 2px
Set (.ext-WikiEditor-ResizingDragBar-ew) background-color to
@colorGray15 (i.e. #F8F9FA)
Remove legacy comment.

Bug: T307105
Change-Id: If0087398920c7ad92e5a2cd1ee5c178644f8d95b
2022-05-11 10:00:42 +01:00
Translation updater bot fe69f2bc51 Localisation updates from https://translatewiki.net.
Change-Id: Ibfed79ef0d511a0edeecaf0885b5cd80805d16d3
2022-05-11 08:12:23 +02:00
Translation updater bot 70814eb0cc Localisation updates from https://translatewiki.net.
Change-Id: If6d91c0c8666d577d4e17babcd497a7d3da50092
2022-05-10 08:10:13 +02:00
Translation updater bot 008edb592d Localisation updates from https://translatewiki.net.
Change-Id: I0851789edcc36e6a2ebde9a24d5943da0e562eb2
2022-05-09 08:12:37 +02:00
samtar 45501cfd92 Realtime preview: Suppress reopening pane
Change the handling of the manual reload button's accessKey to
only refresh the preview if the pane is currently open.
Duplicate change to ManualWidget's handler.

Bug: T307805
Change-Id: I0f07ff346eef4bd93d13d55548381a71c0f660d3
2022-05-07 01:21:40 +01:00
Sam Wilson be4ee228aa Realtime Preview: show and hide preview and error areas appropriately
* Always hide the error message after a successful preview.
* Before previewing, make sure the preview node is un-hidden, in
  case it was previously hidden by showError().
* Stop checkResponseTimes() from hiding any error (it only handles the
  manual mode).
* Stop showError() from hiding the manual bar (it's okay to see both).

Bug: T306965
Change-Id: Ic2ad52fea41070adb196ef2fbd740e808d373e5e
2022-05-06 08:23:50 +08:00
Sam Wilson 96c905f1dc Realtime Preview: Make whole manual-loading bar clickable
Make the manual-mode loading bar clickable by turing it all into
an anchor element with various mixins for functionality.

Also adds a tooltip to the whole bar, and makes the same accesskey
work (including when the preview pane is closed).

Bug: T306590
Bug: T306906
Bug: T306880
Change-Id: I915a430300c75256d89b929e3925d0ea714807bb
2022-05-06 07:32:37 +08:00
samtar 755f984335 Realtime preview: set minimal resize limit
Add a minimal resize limit on the preview pane (`.ext-WikiEditor-twopanes-pane2`) to 248px

Bug: T307105
Change-Id: If05376571bb0b223edac48adecbe124e01293c7a
2022-05-05 19:53:40 +00:00
jenkins-bot 19f784233a Merge "Add JSDoc configuration and test" 2022-05-05 19:50:46 +00:00
jenkins-bot 8840c90692 Merge "tests: Remove use of QUnit 1.x setup()/teardown()" 2022-05-04 11:34:43 +00:00
jenkins-bot 6a91c1f3ea Merge "Realtime preview: improve toolbar button style" 2022-05-04 11:31:57 +00:00
Translation updater bot 8c3608cb25 Localisation updates from https://translatewiki.net.
Change-Id: Ia52c284389d86c951aa4f69cbb96a43c4829134d
2022-05-04 08:19:07 +02:00
Sam Wilson 9921163d54 Add JSDoc configuration and test
Bug: T307415
Change-Id: I770677608b5d2e4532528467d1c4141019dd01e4
2022-05-03 15:28:02 +08:00
Translation updater bot c23c11ae75 Localisation updates from https://translatewiki.net.
Change-Id: I1f378bb447f2303cc913bfc1aa72ecf9a6eb1da4
2022-05-03 08:45:56 +02:00
Sam Wilson 42192e75c9 Invert RealtimePreview.setEnabled parameter meaning
To make it clearer that setEnabled(true) enables the feature, and
setEnabled(false) disables it, invert the function of the first
parameter. Also improve jsDoc parameter documentation.

Follow-up: I4615f629a0c97fb325721bbddee5c9eb074c3a5c
Change-Id: Icb84bcf0624774b9a7002110f1fac31bf48ebd1d
2022-05-03 13:18:05 +08:00
jenkins-bot 43d15ff91e Merge "Realtime preview: disable preview when screen is small" 2022-05-03 02:49:36 +00:00
Timo Tijhof 17fec690b0 tests: Remove use of QUnit 1.x setup()/teardown()
No longer supported upstream. Was kept compatible via MW core
testrunner.js, which I'd like to phase out so that our custom wrapper
can be removed, and thus other features like `QUnit.module.skip()`
become available.

While at it, also convert the file from an ad-hoc closure to using
the QUnit.module() scope and hooks object, as per
<https://api.qunitjs.com/QUnit/module/>.

Bug: T250045
Change-Id: I8c04c56cf5eec3f19ef12a803a192cd824b82f81
2022-05-03 01:22:12 +02:00
hmonroy 090929cf1d Realtime preview: disable preview when screen is small
Disable preview functionality when screen is less than 600px.

Bug: T293337
Change-Id: I4615f629a0c97fb325721bbddee5c9eb074c3a5c
2022-05-02 15:26:20 -07:00
Translation updater bot 9fa65ba1ed Localisation updates from https://translatewiki.net.
Change-Id: I2ac71dd6ce2e1bbda58116cef83a147e7bb0b25a
2022-05-02 08:20:39 +02:00
Translation updater bot 9def93705d Localisation updates from https://translatewiki.net.
Change-Id: I815ffdc99d1540f2703bbf53696c925f2e9c52f6
2022-04-29 08:44:07 +02:00
jenkins-bot e7e3522ed6 Merge "Realtime preview: don't show reload button on error message" 2022-04-27 11:18:14 +00:00
Translation updater bot 0e1ca8124d Localisation updates from https://translatewiki.net.
Change-Id: I7f909904d39900b41f4f4a48539154d86f4dd7cd
2022-04-27 08:08:54 +02:00
Sam Wilson 37836d7fcc Realtime preview: don't show reload button on error message
When the error layout is shown, hide the hover reload button,
and only re-show it if the preview is successful.

Bug: T306866
Change-Id: I5e72295069ee9e8279c5786c3959db5902da0e25
2022-04-26 16:23:51 +08:00
Sam Wilson 3ab9a863a2 Realtime preview: improve toolbar button style
* Add hover and active styles to match normal toolbar state styling.
* Move border from right to left on `.section-secondary .group`.
* Add a skinStyle for MonoBook so it doesn't get the button style,
  because it provides its own.

Bug: T303991
Change-Id: I6f08906156a9768729d779b6c50c9e804f51fb98
2022-04-26 15:08:28 +08:00
Translation updater bot 45a8a077b1 Localisation updates from https://translatewiki.net.
Change-Id: I271d026b9b1ab86da3308e1b63ea68a49aa90cec
2022-04-25 08:19:25 +02:00
jenkins-bot 06cda6ee49 Merge "Remove all unused "loading" code, messages and animations" 2022-04-22 16:15:39 +00:00
Translation updater bot cea6217c7c Localisation updates from https://translatewiki.net.
Change-Id: I7a5f0eea08288b2814001528c662d4c433bb39fa
2022-04-22 08:23:58 +02:00
jenkins-bot fd701e2f5f Merge "Disable the realtime preview reload button during loading" 2022-04-21 15:06:01 +00:00
Thiemo Kreuz 7573a7dbad Remove all unused "loading" code, messages and animations
The CSS was already unused when the extension was created in 2010.
A comment that still mentioned the CSS class was removed via
I0798864 in 2022.

The message is unused since I9fb7e66, that was in 2021.

Change-Id: I25cd31efc4ee61ff3f857c280b5cd18c3ae4bd00
2022-04-21 15:29:15 +02:00
Translation updater bot 8ec5192822 Localisation updates from https://translatewiki.net.
Change-Id: Icbd21bd5c091650d3dcfe35ef5d87c856e32fe37
2022-04-21 08:12:50 +02:00
Sam Wilson a8833fcd3b Disable the realtime preview reload button during loading
Make the reloadButton into a class member so that it's
accessible in doRealtimePreview().

Bug: T304568
Change-Id: I81c1870becd81884894353921f878653cd690d7a
2022-04-21 11:16:54 +08:00
Sam Wilson 84b41f07be Reduce $wgWikiEditorRealtimeDisableDuration from 10 to 6 seconds
Bug: T304568
Change-Id: I70c7b0e42b47f564ea3106544da0674fa28d1b71
2022-04-21 11:10:12 +08:00
Sam Wilson 4da4db0472 URI-decode external link page names when turning them into local links
Decode local page names after the "looks like internal" dialog,
to avoid invalid page names. If it can't be decoded, use the full
page title string.

This doesn't decode text in the ArticlePath, but that sounds like it's
much rarer and could perhaps create other issues.

Bug: T25789
Change-Id: Iac03573515affbc509f674db155767a81bad8b9f
2022-04-21 11:03:04 +08:00
jenkins-bot e0aa0ee307 Merge "Realtime Preview: display manual-reload bar when previews are slow" 2022-04-21 00:55:21 +00:00
jenkins-bot 2354e775b6 Merge "Realtime Preview: make button toggle state more visible in MonoBook" 2022-04-20 19:12:21 +00:00
MusikAnimal 472cf0c07c Realtime Preview: make button toggle state more visible in MonoBook
Bug: T305953
Change-Id: Ibb0ee08837b7e3f5e98fa11d9e7a97dcef2dee9e
2022-04-20 12:30:30 -04:00
jenkins-bot 3c2223fd3b Merge "Fix return value of TitleInputWidget.looksLikeExternalLink()" 2022-04-20 07:45:58 +00:00
Sam Wilson 6cd0094581 Fix return value of TitleInputWidget.looksLikeExternalLink()
This method is supposed to return a boolean.

Change-Id: Id8fd80879770b6eeb5fcfce00eab4f124a8c1a56
2022-04-20 14:47:03 +08:00