Commit graph

2772 commits

Author SHA1 Message Date
jenkins-bot 4d479d62f9 Merge "Search & Replace: Use actual global replace" 2018-11-19 22:54:43 +00:00
Derk-Jan Hartman 38c3f2ed98 Search & Replace: Fix using replace as first action
When you use replace, before having used find, matchIndex gets out of
sync with what replace is expecting and encapsulateSelection won't
have a selection and thus defaults to position 0.

Bug: T76750
Change-Id: I1dcc724e7548690a3cc63672f93a3099c028f123
2018-11-19 07:21:21 +00:00
Ed Sanders 65ce4f6e73 Make button padding clickable
Currently the hover state include the padding, but
only the icon part is clickable.

Change-Id: Ifde032313452dff2ab74197477b0eb3dd6b5dfe1
2018-11-18 15:01:09 +00:00
jenkins-bot 7ff3ffa829 Merge "Remove the dialog version of ref inserter" 2018-11-18 14:38:23 +00:00
jenkins-bot ec8742491f Merge "LinkDialog: Switch to jquery.throttle-debounce plugin" 2018-11-18 14:31:56 +00:00
jenkins-bot f5ed495ba8 Merge "JS for ie-mac is not supported, so no need for this CSS" 2018-11-18 14:31:55 +00:00
Translation updater bot 71b727a03a Localisation updates from https://translatewiki.net.
Change-Id: I9164f7518514856a0fbfe40d0ef6e990808427ba
2018-11-17 22:19:56 +01:00
Derk-Jan Hartman 8284c0480d Search & Replace: Use actual global replace
The old S&R implementation introduces problems with regexes (T58228 and
T50614) and is also rather slow. At some point in the past it was faster
to do multiple search/replace actions using textSelection perhaps, but
with current browsers doing a one shot replace will perform much faster.

If you have CodeMirror enabled, there will be a delay after replacing
all content on a major page, but no worse than the original page load
one, which I think is acceptable.

Bug: T58228
Bug: T50614
Bug: T25510
Change-Id: Ifab1d071d9f09ec55aa6556b5dca04378c4e5273
2018-11-17 21:11:01 +00:00
Derk-Jan Hartman dc86b00db3 JS for ie-mac is not supported, so no need for this CSS
Change-Id: I1aac178c5e162c6a19318d9980283ea562718db7
2018-11-17 13:09:30 +01:00
Derk-Jan Hartman 0089645a46 LinkDialog: Switch to jquery.throttle-debounce plugin
Change-Id: Iebca0398d6bc2939a0904c4cd23395d3207cfea5
2018-11-17 12:07:39 +00:00
jenkins-bot 619b5d34c9 Merge "remove old -khtml-box-sizing..." 2018-11-16 21:36:44 +00:00
Translation updater bot 7efe56d903 Localisation updates from https://translatewiki.net.
Change-Id: I89bb5fa3d0f0d751b6343fdfff5c630ff8d95214
2018-11-16 22:29:50 +01:00
Derk-Jan Hartman 709e2bbdfd Remove the dialog version of ref inserter
1: reftoolbar is used in more advanced situations
2: it doesn't actually do much
3: leaner

Keeping it in the same file, because that will preserve order. seems
safer.

Change-Id: I9bb2cf1e8731d12551a00b717b11602e6192d299
2018-11-16 21:49:31 +01:00
Derk-Jan Hartman cc3f42f6a1 remove old -khtml-box-sizing...
Change-Id: Idbd0b16431e2a9c34c28c68b775e7854b5dffbc5
2018-11-16 21:38:44 +01:00
jenkins-bot 261a7ba2fd Merge "Make jQuery.async loop synchronous" 2018-11-16 19:29:02 +00:00
libraryupgrader bd26ee1d93 build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: I91531d695dd6f6ee6fa376d4029d5292e0d79cbc
2018-11-16 14:43:05 +00:00
Ed Sanders f1c0cbc70f Make jQuery.async loop synchronous
Bug: T209699
Change-Id: I61b6bd2f428144d746ccfbaf6269d64926a9c4d7
2018-11-16 12:56:55 +00:00
jenkins-bot 40919abfaf Merge "Remove browser arrays" 2018-11-15 22:36:32 +00:00
Translation updater bot 9e71a9692e Localisation updates from https://translatewiki.net.
Change-Id: Ia8e30c7a9447b49699caa01af965b0f549cb0f28
2018-11-15 23:00:37 +01:00
Derk-Jan Hartman aaa454b618 Remove browser arrays
Follow-up to I189516917d805dff3819e742a9fd8ad96a161159

Change-Id: Ic2e5389cc565ef061f4f846ad628ee6ea1a8a9fb
2018-11-15 22:59:51 +01:00
Derk-Jan Hartman a686b7f580 LinkDialog: use placeholder instead of fake values
Use proper placeholder attribute instead of faking it with a value.
This predated even jquery.placeholder and is no longer needed.
Also fixes a bug where it was checking with the API for the existence
of the placeholder value.

Bug: T133716
Change-Id: I290ec48f6b1d250da28efffd7ebdb6b681c0227e
2018-11-15 07:06:20 +00:00
Derk-Jan Hartman daab3360c9 LinkDialog: fix size of background image
At the default line-height the background image tends to
get clipped. Set it to the same line-height as the adjacent label
and both the label and the icon are aligned and the icon won't be
cutoff

Bug: T193480
Change-Id: Id94ba02a305a5150ad5b266bb0e2bb01b8a637ac
2018-11-14 23:17:06 +01:00
jenkins-bot 07d219f2c5 Merge "Modules: Protect against loading modules twice" 2018-11-14 21:11:51 +00:00
jenkins-bot fa63708bd5 Merge "Toolbar: ignore modifications on readonly textarea" 2018-11-14 20:51:06 +00:00
Derk-Jan Hartman 0161e37e6e Modules: Protect against loading modules twice
Bug: T189029
Change-Id: Ie0dff9c1dfa8e3a0927f2915a9a237dff739289a
2018-11-14 20:24:15 +00:00
Derk-Jan Hartman 261c76d746 Toolbar: Add tiny hover effect to ooui icon buttons
Change-Id: If3f8eddb2ece0af34c5f42b264b53c7bf0ccb352
2018-11-14 19:52:32 +00:00
Derk-Jan Hartman c7e4545589 Toolbar: ignore modifications on readonly textarea
CodeMirror forces WikiEditor to load. While CodeMirror handles readonly
textareas, the WikiEditor toolbar doesn't. CodeMirror and
syntaxhighlighting is pretty useful in readonly actually,
so I'm making WikiEditor a tad more resistent against readonly mode.

Bug: T188817
Change-Id: I927a780e1aea86a19750387f530bad84b1ff5ef4
2018-11-14 19:02:58 +00:00
jenkins-bot db6c6f636b Merge "Remove obsolete aliases from closures" 2018-11-14 00:11:49 +00:00
Derk-Jan Hartman fd92d4b821 Toolbar: Allow groups to be multiline/wrap
Bug: T25943
Change-Id: I2db720449dfe9619de1f8e37fc99282191d932b1
2018-11-13 15:40:35 +01:00
Ed Sanders 4fa41179e8 Remove obsolete aliases from closures
Bug: T208951
Change-Id: I0b2993912de221e810414e46708c19be163922f6
2018-11-12 22:28:40 +00:00
Translation updater bot 1df03c03e0 Localisation updates from https://translatewiki.net.
Change-Id: I18b226d0d18405bbcb6ffd532ef552b5da5d1503
2018-11-12 22:13:02 +01:00
Translation updater bot eb86cca6b5 Localisation updates from https://translatewiki.net.
Change-Id: I48d455251e31ce6affeb647b10a87a2e8c34da5a
2018-11-11 22:34:01 +01:00
Translation updater bot 103f3955a0 Localisation updates from https://translatewiki.net.
Change-Id: I77b9df9c23d6a0c98b543b787e102b387c67e197
2018-11-10 22:28:35 +01:00
Translation updater bot eb71e7c026 Localisation updates from https://translatewiki.net.
Change-Id: I021981afc29ddb971e289fd170482b2465415fc0
2018-11-08 22:18:18 +01:00
Translation updater bot 2715bb64a7 Localisation updates from https://translatewiki.net.
Change-Id: I26e5719493381e4bc531e8f513d1f26b09c26c25
2018-11-07 22:22:38 +01:00
jenkins-bot e75c1a53b8 Merge "Re-label preference now that the 2006 wikitext editor doesn't exist" 2018-11-06 15:53:27 +00:00
Translation updater bot cdb4b00e7f Localisation updates from https://translatewiki.net.
Change-Id: I7ad3ff92722560dccc4fd71c34008f8fd3f502e7
2018-11-04 22:42:55 +01:00
jenkins-bot 225b8d7a5b Merge "Update EventLogging code for Edit->EditAttemptStep schema migration" 2018-10-29 19:25:42 +00:00
Roan Kattouw d700202f85 Update EventLogging code for Edit->EditAttemptStep schema migration
The schema itself is being renamed, and many of the field names are
different.

Bug: T207803
Depends-On: I2949c9782669b75cf17978698c8cef21fdee6dea
Change-Id: I07d9bc1530005914043911b7906c1602522c9162
2018-10-29 11:38:07 -07:00
Translation updater bot b0c239d66e Localisation updates from https://translatewiki.net.
Change-Id: If391146d2ab68a1e4dec177406332c1309e86f2c
2018-10-28 22:22:08 +01:00
Translation updater bot 5d429ebb96 Localisation updates from https://translatewiki.net.
Change-Id: Ia0dd943537ffe7062a64084847b838791fd87026
2018-10-26 22:24:18 +02:00
James D. Forrester 169d38fa75 Re-label preference now that the 2006 wikitext editor doesn't exist
Add the secondary label in a 'help' note to make it easier to identify
the different editors.

Bug: T32795
Change-Id: I6d17359166f58811ba99893ce4a4500a87deb827
2018-10-25 14:33:31 -07:00
jenkins-bot ddcc8b2430 Merge "Oversample Schema:Edit events when configured to do so" 2018-10-24 21:38:49 +00:00
jenkins-bot c31bffdb17 Merge "Use Schema:Edit sampling rate config from WikimediaEvents" 2018-10-24 21:37:24 +00:00
Roan Kattouw 55b89c1ede Oversample Schema:Edit events when configured to do so
Respect the config var exported by WikimediaEvents that, if set to true,
forces oversampling. When oversampling, all events are logged even if
they would have been sampled out. The isOversample property is set to
true if the event was oversampled and would not otherwise have been
logged.

Bug: T206543
Depends-On: I5fdf5fdd2dc0d99a0a0d7eb7ab2e3dce4798009b
Change-Id: I7e504884a888c4d080cd4762549b72489126ed65
2018-10-18 10:58:45 -07:00
Translation updater bot e6843e3240 Localisation updates from https://translatewiki.net.
Change-Id: Ia464840cae48dea76813ad69646c400a124e43eb
2018-10-17 23:44:38 +02:00
Roan Kattouw e54a4420ca Use Schema:Edit sampling rate config from WikimediaEvents
Instead of hard-coding the 6.25% sampling rate, allow it to be
controlled by the config variable in the WikimediaEvents extension
(which also defines the RL module for the Edit schema).

Also use sampling code from EventLogging so we can configure the
sampling rate as a number, rather than using a hex-digit based strategy.

Bug: T206543
Depends-On: I00383cec62f6c2a0137b329565b0ca84bfbb223f
Depends-On: Ib746fc708e7b752cebc5fd8d080e40819dfa34f3
Change-Id: I2956efc9294768742dd49dcb36770f0509e4090f
2018-10-17 14:30:03 -07:00
Translation updater bot 6d1cd8bab1 Localisation updates from https://translatewiki.net.
Change-Id: I02cd04958cf7ba12a62ba4d2f04bf2e46c3ab9fc
2018-10-16 22:17:37 +02:00
Gergő Tisza 1fc00749fb
Fix escaping
Follows up I2df3ec8c0.

Change-Id: Ic8f44dec0f24e2443055ef46cd0b4140c200a22b
2018-10-12 20:29:29 -07:00
James D. Forrester e75284e528
Fork autoMsg() with escaped autoSafeMsg(), replace where appropriate
The only use of raw HTML messages is in the help panel, which is the only user
of `layout: 'table'`, so we can replace all other callers.

Bug: T154891
Change-Id: I2df3ec8c05d4daaa094378354566356a822c081f
2018-10-12 01:27:52 -07:00