Commit graph

13 commits

Author SHA1 Message Date
Roan Kattouw d23d096281 Convert ext.wikiEditor module to packageFiles
This allows us to bundle the wgWikiEditorMagicWords and
mw.msg.wikiEditor(?!) config vars that were previously exported globally
in the startup module.

This code is old and crufty, so this is a somewhat minimal conversion:
* Use require() for jquery.wikiEditor.{dialogs,toolbar}.config.js,
  and for jquery.wikiEditor.{dialogs,toolbar}.js
* Don't attempt to convert jquery.wikiEditor.js to something
  require-based, instead just run it and let it set the $.wikiEditor and
  $.fn.wikiEditor globals
* Consolidate ext.wikiEditor.{dialogs,toolbars}.js into
   ext.wikiEditor.js

Bug: T222828
Change-Id: Ia75d685cbde786e8fceb6db36f2436b2beea1499
2019-08-05 22:24:56 +00:00
Timo Tijhof 14db0b965a Remove unused 'wgWikiEditorEnabledModules' var
This is an internal variable that hasn't been used since 2017
with commit be36244c70. It was kept for back-compat with
regards to caching, which as churned long since.

Bug: T219342
Change-Id: I7c71956e34c1d4312037f9a8d26f81125ab82577
2019-03-29 02:02:52 +00:00
James D. Forrester ebe89e3c7d Replace use of deprecated ResourceLoaderTestModules hook
Use the new extension.json attribute instead.

Bug: T214211
Change-Id: I79c45c6923fd19f6f9f068492b3bd6548161dd04
Depends-On: I27ecebe27d7aaebe6d1317bc5eaea9cca368b45d
2019-02-13 15:24:38 -08:00
Derick Alangi 44b1c8418d Remove "return true" legacy behavior from hook handler functions
Change-Id: I314261115be187d77c3e9f9f30585090eea4718e
2019-02-02 21:21:59 +01:00
jenkins-bot e75c1a53b8 Merge "Re-label preference now that the 2006 wikitext editor doesn't exist" 2018-11-06 15:53:27 +00:00
Roan Kattouw d700202f85 Update EventLogging code for Edit->EditAttemptStep schema migration
The schema itself is being renamed, and many of the field names are
different.

Bug: T207803
Depends-On: I2949c9782669b75cf17978698c8cef21fdee6dea
Change-Id: I07d9bc1530005914043911b7906c1602522c9162
2018-10-29 11:38:07 -07:00
James D. Forrester 169d38fa75 Re-label preference now that the 2006 wikitext editor doesn't exist
Add the secondary label in a 'help' note to make it easier to identify
the different editors.

Bug: T32795
Change-Id: I6d17359166f58811ba99893ce4a4500a87deb827
2018-10-25 14:33:31 -07:00
Roan Kattouw 55b89c1ede Oversample Schema:Edit events when configured to do so
Respect the config var exported by WikimediaEvents that, if set to true,
forces oversampling. When oversampling, all events are logged even if
they would have been sampled out. The isOversample property is set to
true if the event was oversampled and would not otherwise have been
logged.

Bug: T206543
Depends-On: I5fdf5fdd2dc0d99a0a0d7eb7ab2e3dce4798009b
Change-Id: I7e504884a888c4d080cd4762549b72489126ed65
2018-10-18 10:58:45 -07:00
Roan Kattouw e54a4420ca Use Schema:Edit sampling rate config from WikimediaEvents
Instead of hard-coding the 6.25% sampling rate, allow it to be
controlled by the config variable in the WikimediaEvents extension
(which also defines the RL module for the Edit schema).

Also use sampling code from EventLogging so we can configure the
sampling rate as a number, rather than using a hex-digit based strategy.

Bug: T206543
Depends-On: I00383cec62f6c2a0137b329565b0ca84bfbb223f
Depends-On: Ib746fc708e7b752cebc5fd8d080e40819dfa34f3
Change-Id: I2956efc9294768742dd49dcb36770f0509e4090f
2018-10-17 14:30:03 -07:00
James D. Forrester c59430d243 Follow-up 874f9bfb8d: Bump server-side Edit schema version here
We updated it in WikimediaEvents but not here. Whoops.

Bug: T203621
Change-Id: Ie84411bccd5322d6f228e8c905741368485b97d3
2018-09-14 17:22:14 -07:00
Derk-Jan Hartman 38a70500a0 Use ExtensionRegistry instead of class_exists
Bug: T183096
Change-Id: I2b02e89f20ecab9dda44ea9a78067a96fc04392c
2018-08-19 17:17:03 +02:00
Aryeh Gregor 30e00a3bf2 Don't use deprecated MagicWord static methods
Bug: T200247
Depends-On: Ie061fe90f9b9eca0cbf7e8199d9ca325c464867a
Change-Id: I8affa85bb9a55205ac69ca7803693e30c361b275
2018-07-31 20:42:31 +03:00
Kunal Mehta 5ae7c42382 Move WikiEditorHooks into includes/
Change-Id: Ifc4fb72e68d9a879b763061f1585cac47e9f756f
2018-02-16 14:07:54 -08:00