Commit graph

3236 commits

Author SHA1 Message Date
jdlrobson 9ac850b28a Dialog data attribute action is a DOMElement
After looking more closely at the code, I noticed that
dialogaction is set to e.target or this which is a
DOMElement, not a jQuery Object, thus it doesn't have
the trigger method which explains the error.

Follow up to 760f023f2

Bug: T261529
Change-Id: Ie5f58e33ad385f2abae19264bb2c3cd34a721788
2021-02-25 08:12:16 -08:00
Translation updater bot d0453472bb Localisation updates from https://translatewiki.net.
Change-Id: I720e23bde93d5f3224123fd10741b39ce7c5c3b7
2021-02-25 08:39:44 +01:00
Translation updater bot e1d40e5a34 Localisation updates from https://translatewiki.net.
Change-Id: Ia9031006ebbf952a5e0a8aaba0f4ffc974ae8133
2021-02-18 08:44:18 +01:00
Translation updater bot 954a204087 Localisation updates from https://translatewiki.net.
Change-Id: I387dac96d6c8b76ed0d2c6b5e7d1c929251bb03e
2021-02-15 10:07:02 +01:00
Translation updater bot ee7cd6bca8 Localisation updates from https://translatewiki.net.
Change-Id: Ie92f7c772997d5f743e11daae56a78e6f97afea4
2021-02-12 08:52:52 +01:00
Translation updater bot 558a84b8a1 Localisation updates from https://translatewiki.net.
Change-Id: Ied1b905c1ca0f60f68b3636b7557713fd85767c0
2021-02-11 08:40:52 +01:00
jdlrobson 760f023f21 TypeError: $button.trigger is not a function
This error is generating a large amount of logspam.
Add a check to avoid it, and DRY up.

The issue is caused by line 1182 setting dialogaction to false when
a dialog is closed. Presumably references to this data attribute
remain.

Bug: T261529
Change-Id: Ie75f737980dfcbcc4829def1e5a6894262d73b31
2021-02-10 21:36:27 +00:00
Translation updater bot 80b3582116 Localisation updates from https://translatewiki.net.
Change-Id: I81f1504fc8f99470867cb6a835ec8070e8d6f3c8
2021-02-08 08:46:39 +01:00
Translation updater bot d23f8ce603 Localisation updates from https://translatewiki.net.
Change-Id: I6c5d97b274ebdce417ce65ad6d34cef8e7ed7359
2021-02-03 08:40:10 +01:00
jenkins-bot 5791ee3d51 Merge "Update save failure logging for EditAttemptStep schema" 2021-02-01 18:17:59 +00:00
jenkins-bot 06f1004702 Merge "Logging init mechanism for new section direct navigation" 2021-02-01 17:08:50 +00:00
jenkins-bot ef5c29c5f1 Merge "Log the DiscussionTools a/b test bucket for relevant schemas" 2021-02-01 17:08:45 +00:00
Translation updater bot 6bc12c80d1 Localisation updates from https://translatewiki.net.
Change-Id: Ie45da71158ae8c7e68b9aa65862dcf759270b3d2
2021-02-01 08:49:15 +01:00
libraryupgrader 042acbf799 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 34.0.0 → 35.0.0
* mediawiki/minus-x: 1.1.0 → 1.1.1

npm:
* eslint-config-wikimedia: 0.18.0 → 0.18.1

Change-Id: If9f846e23998cac9cc2ea5d5a32b03b2b2372bf8
2021-01-30 19:47:49 +00:00
David Lynch 36a58b5599 Logging init mechanism for new section direct navigation
Support the `url-new` mechanism so we can distinguish between
new/existing sections in direct navigation.

Bug: T272544
Change-Id: I2c431592035c7ccedbbe612bc97f63141fc4dab7
Depends-On: I3cee7a3a4c4b646692dce4a1180c4ba18a61f4bc
2021-01-29 20:56:14 -06:00
David Lynch e052e46f94 Log the DiscussionTools a/b test bucket for relevant schemas
If someone is enrolled the DT a/b test, we want to know about their
editing here as well.

Bug: T273096
Change-Id: If2bb04011c8ca54e8c7ffd073e21bec45e92460c
2021-01-29 20:56:14 -06:00
jenkins-bot 50e3e34098 Merge "Use only the first item of various magic words" 2021-01-29 15:33:18 +00:00
Translation updater bot e199e6f0aa Localisation updates from https://translatewiki.net.
Change-Id: I9dcf0a12c5d9a6a3101755df749ba8bb9f4d3c7b
2021-01-29 08:39:08 +01:00
Reedy 4dcd3baab0 Use only the first item of various magic words
Bug: T273231
Change-Id: I1f88eb3e043cb95f939a7e38ddaa3e39a49523fa
Follows-Up: Ib03932d3d85a5540bea325f2717da3365756a90e
2021-01-29 02:57:01 +00:00
Translation updater bot b16eb935b2 Localisation updates from https://translatewiki.net.
Change-Id: I49661cebcc751ada927c4937b7fdc4c11fdca6d6
2021-01-28 08:37:36 +01:00
jenkins-bot 3aa618b801 Merge "Export crude public interface for WikiEditor" 2021-01-27 10:27:05 +00:00
Translation updater bot 688650820d Localisation updates from https://translatewiki.net.
Change-Id: I16b95bdcbe960918ef1ec92fe8d4b1a38215daab
2021-01-27 08:35:54 +01:00
libraryupgrader 2081766cb4 build: Updating eslint-config-wikimedia to 0.18.0
Additional changes:
* Added the "composer phan" command to conveniently run phan.
* Removing manual extensions for eslint.

Change-Id: I664a503f515018d3f4c0d37b03a03eb0711c0a3b
2021-01-27 01:50:16 +00:00
Translation updater bot f258c59d5e Localisation updates from https://translatewiki.net.
Change-Id: I0cb4848dde7297f553515ce3df0994c967854a89
2021-01-26 08:54:20 +01:00
Translation updater bot 2aca3fbac9 Localisation updates from https://translatewiki.net.
Change-Id: I5ad70a3b23a2e072f4dda33b37eabff7a9f7938d
2021-01-25 08:55:15 +01:00
jenkins-bot 4533cf2e79 Merge "Don't lowercase image caption/alt when prefilling image fields" 2021-01-23 02:14:37 +00:00
jenkins-bot 3a0ddc5fdc Merge "Parse alternative magic word translations when prefilling image fields" 2021-01-23 02:14:33 +00:00
jenkins-bot 9130745e3d Merge "Allow specifying alt-text in File dialog" 2021-01-23 02:14:31 +00:00
Bartosz Dziewoński d77a69f236 Don't lowercase image caption/alt when prefilling image fields
Judging by the presence of this bug, no one ever uses this feature.

Change-Id: I46a986dd83cf98a8b9f5dcb5bd4c3acb04a6cf5b
2021-01-22 21:23:44 +00:00
Bartosz Dziewoński dc93bf1b37 Parse alternative magic word translations when prefilling image fields
In some languages, image options like 'alt' or 'thumb' can have
multiple synonyms. They were only handled for English (and were
hard-coded).

Change-Id: Ib03932d3d85a5540bea325f2717da3365756a90e
2021-01-22 22:15:16 +01:00
Ammar Abdulhamid ab287ade14 Allow specifying alt-text in File dialog
* Also add expandable help message to explain the alt text field

Bug: T260006
Change-Id: If16ff742d7a8dee4917884e73e9c95bf76350773
2021-01-22 21:37:17 +01:00
Translation updater bot ffe3057902 Localisation updates from https://translatewiki.net.
Change-Id: I400c6a94ce9b35d1f90d88d4092cfea627e3538a
2021-01-22 08:31:45 +01:00
Niklas Laxström c10d08d87b Export crude public interface for WikiEditor
Bug: T250862
Change-Id: Iac8778f0d0a0150acc99569d84422bc9817dfcc7
2021-01-21 12:22:52 +00:00
Bartosz Dziewoński 334618d0b2 Update save failure logging for EditAttemptStep schema
* Use the error code from the API for 'save_failure_message', instead
  of the key of the localisation message shown to the user.

  Although this editor is not using the API, and doesn't use those
  error codes, we still want to use them in logging for consistency
  with all the other editing tools.

  We can easily generate the error codes from the Status we do have.

* Copy 'save_failure_type' map from VisualEditor.

Bug: T272162
Change-Id: Ia9eeea14e3d4a6a691f84628a27ffc0c3bf061c1
2021-01-15 20:17:25 +01:00
Translation updater bot d3af9e4079 Localisation updates from https://translatewiki.net.
Change-Id: I68352b6b47da1100d79fa64503264553942bd55f
2021-01-14 08:51:51 +01:00
Translation updater bot 00ea1d2906 Localisation updates from https://translatewiki.net.
Change-Id: I74964b2c9421c2f06dc987fd347bf3fb59f0ba6b
2021-01-11 08:35:47 +01:00
Translation updater bot 9ce48a86ca Localisation updates from https://translatewiki.net.
Change-Id: Ic1052893beff92a382271d29f781693d3c0f44a4
2021-01-08 08:56:44 +01:00
jenkins-bot 2b5e9073f1 Merge "Edit page normally lacks wgRevisionId, but has form field parentRevId" 2021-01-04 20:34:55 +00:00
Translation updater bot 287b58198e Localisation updates from https://translatewiki.net.
Change-Id: I0cd2434c96d41e969d87c7e22561318549a00574
2021-01-04 08:45:16 +01:00
Translation updater bot e664d97d5f Localisation updates from https://translatewiki.net.
Change-Id: Iaf80e5f3fc3e96a8fec15e2049e62c478a09f07e
2020-12-30 10:15:35 +01:00
Translation updater bot 33cf8b3f1d Localisation updates from https://translatewiki.net.
Change-Id: I53fd9a1ddfd327835c8867e10842d90ab26205d3
2020-12-28 10:40:31 +01:00
Translation updater bot 7d229e32a2 Localisation updates from https://translatewiki.net.
Change-Id: Ib89b865da0ec72c53b5b24de38d16e454d93c327
2020-12-22 08:33:15 +01:00
David Lynch fa2b80e22a Edit page normally lacks wgRevisionId, but has form field parentRevId
Bug: T230133
Change-Id: I5e3defe22aee58e36d662ef051ebfb3ff1b64dde
2020-12-21 12:27:46 -06:00
Translation updater bot 7946f494ec Localisation updates from https://translatewiki.net.
Change-Id: I9a63e099013b4db639b2580f07bfd5554e68f30d
2020-12-21 08:40:37 +01:00
libraryupgrader 8357aec78c build: Updating mediawiki/mediawiki-phan-config to 0.10.6
Change-Id: I4f139b027845a4a7993c8cec36062d825ee51ebd
2020-12-19 04:48:06 +00:00
Translation updater bot 5698e99e55 Localisation updates from https://translatewiki.net.
Change-Id: I38b6a30c0088c94c6175c422e38fb9e6a9101238
2020-12-16 08:31:01 +01:00
Translation updater bot 45c965e0cf Localisation updates from https://translatewiki.net.
Change-Id: Ieae096ff7e5623781fcd5869e3971a630e64f593
2020-12-15 08:37:32 +01:00
Translation updater bot 760b33034b Localisation updates from https://translatewiki.net.
Change-Id: I0d4704e33b71815b8537ed1bc4e5e3d54d23c5f8
2020-12-14 08:43:57 +01:00
libraryupgrader dc52e4ee3c build: Updating ini to 1.3.8
* https://npmjs.com/advisories/1589

Change-Id: Ie2a71e910f310a3d418ccca5473bb0160978a0f0
2020-12-12 03:27:47 +00:00
libraryupgrader 65e3611d9f build: Updating mediawiki/mediawiki-phan-config to 0.10.5
Change-Id: Ia4e1d5b0beb7aaabc13f88b941eefcc5904597f9
2020-12-09 09:27:22 +00:00