Commit graph

117 commits

Author SHA1 Message Date
James D. Forrester 4551332586 Replace use of old $wgVersion constant with MW_VERSION
Change-Id: I31e524694ca2e7399b235b89aeeb779a4d13811d
2020-05-13 15:02:38 -07:00
Reedy 9ff90afde4 Convert to manifest_version 2
Bug: T252470
Change-Id: I8e58023cb044c9000325a275d0ae7e2f44142414
2020-05-12 02:12:31 +01:00
pcoombe a822d1c197 Add caption when inserting table
Data tables should always include a caption for accessibility reasons.
So add a placeholder caption when using the "insert table" button.

Bug: T252350
Change-Id: I6773e2274007946de516ae34e841f66ad20ebc0c
2020-05-11 11:09:23 +01:00
Ed Sanders 8e9d306510 Create a toolbarReady hook for attaching toolbar tools
Using an event introduces a race condition where the extension
adding the listener has to do so before WikiEditor finishes loading.

Change-Id: I5a8dc6f8fd1b1939b5d98307b20ef1fd355cee99
2020-04-21 15:28:40 +01:00
Fomafix 47a7e21216 Lazy load the modules for the upload dialog
This reduces the initial loaded modules.

Also add the dependency on module 'oojs-ui-widgets' because
jquery.wikiEditor.toolbar.js uses OO.ui.ToggleButtonWidget.

Change-Id: I03d0f73fb77bb389dd4e5ad2aa15b3ff5a97e5f5
2020-03-03 06:25:51 +01:00
Ed Sanders 0df5223a20 Use WikimediaUI toolbar styling in Vector
Bug: T223155
Change-Id: I4730a78836e8db0b4116f09e07929d8b883c9fa4
2020-02-10 14:44:06 -08:00
Ed Sanders ef38bdfe2f Align toolbar styling with Apex
Also separate out Apex-specific styling into a separate file.

The current toolbar is already supposed to be aligned with Apex
so the visual changes here are minimal.

Bug: T223155
Change-Id: I7a0a21809018e0094d50992054523d20be3c5473
2020-02-04 17:16:37 -08:00
Derk-Jan Hartman 4906ff1c8c Remove usage of EditPageBeforeEditToolbar
As noted by Jack Phoenix in I07b0e0e030217d74f06bb2b6fc278bd2e28e34b5
the core toolbar has not been present since 1.32 and this hook is
therefore rather pointless.

Change-Id: Ibcf4400237dbf3b195e2bc6a8efee9f1b1527e6d
2020-01-25 17:18:42 +01:00
Timo Tijhof f1fdd893bb Remove use of jquery.ui module aliases
Bug: T219604
Change-Id: I33f4c65de2f4f615c69989d763cf8edcd8ea8f8e
2019-10-19 20:56:24 +01:00
jenkins-bot 9a25fc5557 Merge "Remove use of jquery.tabIndex (take 2)" 2019-10-16 21:49:54 +00:00
jenkins-bot 540785f413 Merge "Revert "Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js"" 2019-10-16 21:12:05 +00:00
Timo Tijhof b505eaed24 Remove use of jquery.tabIndex (take 2)
This was used for setting incremental tabindex attributes
on the <button> elements of the "Find and replace" dialog
as opened from the "Advanced" toolbar section. I was unable to
find a difference in behaviour with and without this code running.

Both with and without this, when tabbing from the first input
field in the dialog, the buttons are in the tab order after
the input fields (matching the visual rendering). Unclear
what this was doing.

This re-applies commit 81b08daa48, which was reverted (5f356b1a),
because I forgot to remove the calls in  dialogs.config.js.

Bug: T234581
Bug: T235701
Change-Id: Ic51074c3d2b2e9b9b050c9f42862519a3e78af16
2019-10-16 22:03:29 +01:00
Jforrester 5f356b1aca Revert "Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js"
This reverts commit 81b08daa48.

Bug: T235701
Change-Id: Iaad63b755aba5654ce6d684d4a5a88f732a6e797
2019-10-16 20:59:38 +00:00
jenkins-bot c5b154e599 Merge "Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js" 2019-10-12 02:13:30 +00:00
Timo Tijhof 81b08daa48 Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js
This was used for setting incremental tabindex attributes
on the <button> elements of the "Find and replace" dialog
as opened from the "Advanced" toolbar section.

I was unable to find a difference in behaviour with and without
this code running.

Both with and without this, when tabbing from the first input
field in the dialog, the buttons are in the tab order after
the input fields (matching the visual rendering). Unclear
what this was doing.

Bug: T234581
Change-Id: I5de97733091d0e123913f272b00784205d69267f
2019-10-11 22:51:20 +01:00
Timo Tijhof 7e5b71b04e mediawiki.RegExp (deprecated) -> mediawiki.util
Bug: T218339
Change-Id: Idd56fbd34648eeb42434848119b118375562cd14
2019-09-09 17:55:24 +00:00
Roan Kattouw d23d096281 Convert ext.wikiEditor module to packageFiles
This allows us to bundle the wgWikiEditorMagicWords and
mw.msg.wikiEditor(?!) config vars that were previously exported globally
in the startup module.

This code is old and crufty, so this is a somewhat minimal conversion:
* Use require() for jquery.wikiEditor.{dialogs,toolbar}.config.js,
  and for jquery.wikiEditor.{dialogs,toolbar}.js
* Don't attempt to convert jquery.wikiEditor.js to something
  require-based, instead just run it and let it set the $.wikiEditor and
  $.fn.wikiEditor globals
* Consolidate ext.wikiEditor.{dialogs,toolbars}.js into
   ext.wikiEditor.js

Bug: T222828
Change-Id: Ia75d685cbde786e8fceb6db36f2436b2beea1499
2019-08-05 22:24:56 +00:00
Fomafix 3a306ff7fb Use lightweight mw.util.getParamValue() instead of mw.Uri()
Change-Id: I27eea6544a7dfe503d0cac1e24228eca9834ca95
2019-07-17 17:41:23 +02:00
jenkins-bot 7c75285577 Merge "Search: Add option to search whole words" 2019-05-19 18:21:54 +00:00
Derk-Jan Hartman f501cdc9c6 Search: Add option to search whole words
Bug: T24478
Change-Id: Idb47ac392b0f8b1425053c6916db8f25c11c9762
2019-05-15 22:03:54 +02:00
Timo Tijhof 14db0b965a Remove unused 'wgWikiEditorEnabledModules' var
This is an internal variable that hasn't been used since 2017
with commit be36244c70. It was kept for back-compat with
regards to caching, which as churned long since.

Bug: T219342
Change-Id: I7c71956e34c1d4312037f9a8d26f81125ab82577
2019-03-29 02:02:52 +00:00
James D. Forrester ebe89e3c7d Replace use of deprecated ResourceLoaderTestModules hook
Use the new extension.json attribute instead.

Bug: T214211
Change-Id: I79c45c6923fd19f6f9f068492b3bd6548161dd04
Depends-On: I27ecebe27d7aaebe6d1317bc5eaea9cca368b45d
2019-02-13 15:24:38 -08:00
Timo Tijhof 5d873f27ab Remove deprecated ext.wikiEditor module aliases
Follows-up T165112, which most the WikiEditor code into a single
module bundle (given they were only ever loaded together).

It left behind some aliases for back-compat to allow for user
migration. Once we've checked with mwgrep and get satisfactory
results, we should finally remove these to lighten the startup
registry.

Bug: T165112
Bug: T202154
Change-Id: I207ebc0f9f9c2beb81f4dfe726f090ee900a1c57
2019-01-18 18:24:44 -08:00
Ed Sanders d1675f275c Use mw.Title.wantSignaturesNamespace
This bumps the extension to requiring the 1.33.x releases of MediaWiki,
which are currently in alpha.

Change-Id: I55f77294d271c81f510ce54181a24435b840d3d2
Depends-On: Ib2faa22c429096d545ddb829a6b4025427ad6071
2018-11-27 09:46:52 -08:00
Derk-Jan Hartman 0089645a46 LinkDialog: Switch to jquery.throttle-debounce plugin
Change-Id: Iebca0398d6bc2939a0904c4cd23395d3207cfea5
2018-11-17 12:07:39 +00:00
Ed Sanders f1c0cbc70f Make jQuery.async loop synchronous
Bug: T209699
Change-Id: I61b6bd2f428144d746ccfbaf6269d64926a9c4d7
2018-11-16 12:56:55 +00:00
James D. Forrester 57499f670e Mark some messages as raw HTML
Bug: T200997
Change-Id: Ifb56bf9cd1952da6eede4e52f19a029f0bc09feb
2018-09-05 14:48:24 -07:00
jenkins-bot f31e9527b2 Merge "Toolbar: Add a new 'toggle' tool type; declare as v0.5.2" 2018-08-17 19:08:42 +00:00
Derk-Jan Hartman bfbc794c5b Toolbar: Add a new 'toggle' tool type; declare as v0.5.2
A new toggle tooltype which makes use of ToggleButtonWidget in order
to provide proper accessibility for all buttons that require on/off
state

Bug: T198781
Change-Id: I8b7fd41571a48fa4f6560790d94bb966972e740f
2018-08-17 11:19:32 -07:00
James D. Forrester 3af0239cb5 Update usage of 'book' OOUI icon to use from 'editing-citation' pack
This moved in OOUI 0.27.0, which was merged into MediaWiki 1.32.0+ in
fc88eea; the old alias is about to be removed from OOUI, so this will
stop it breaking.

Bug: T194104
Depends-On: I2acf232fd172d176b305d65d88db5b7bbfe34b88
Depends-On: I8a0426fc288a499e40f02f1da7a9f1b09e6dbd5f
Change-Id: I1a1409de15559bd614f7d351cdc1df0753b9df5d
2018-08-14 20:26:35 +00:00
Kunal Mehta 6eee7fd08b Set extension type to editor
Change-Id: Ie15520d059eca7b25247f97a6f687f6059783213
2018-04-13 22:07:50 -07:00
Ed Sanders 72e48c26e0 Convert remaining tools to OOUI
Replaces the insert and advanced-insert groups, which
are currently multi-colour icons.

Drops the button-sprite + offset mode, according to
mwgrep there are no other users of this.

Bug: T191031
Bug: T143508
Change-Id: I7032f98908a591ea5c9d3dbbb7616e2c10bbfc80
2018-04-11 15:50:23 +01:00
Ed Sanders 335f189460 Use OOUI icons for advanced format & size tools
Bug: T191031
Change-Id: Ifb6c166ecfe082414677420939106d55a5715bb2
2018-03-29 15:53:15 +01:00
Kunal Mehta 5ae7c42382 Move WikiEditorHooks into includes/
Change-Id: Ifc4fb72e68d9a879b763061f1585cac47e9f756f
2018-02-16 14:07:54 -08:00
Jayprakash12345 e12ffc0094 Use SPDX 3.0 license identifier
Bug: T183858
Change-Id: Ib1cdce9e8f51ce4008bacad222d1dc592bbafa16
2018-01-29 05:42:06 +00:00
Ed Sanders efde69f460 Emit deprecation warnings when old modules are used
Bug: T184194
Depends-On: If22fccbb43c5b05db2a666d61ae8864ee9815e7d
Change-Id: If5649ab48ebbf47e9981ec010bb1e5ce668c5487
2018-01-09 00:14:05 +00:00
Ed Sanders 2e7f1f66ed Follow-up I51745e8: Make all old modules aliases of 'ext.wikiEditor'
Many of these modules are depended on in the wild in
user scripts etc. so make them deprecated aliases.

Bug: T165112
Change-Id: I00b888fa55e1e16a490cda22d59692564714dd46
2018-01-04 12:01:26 +00:00
Ed Sanders 17cf175e78 Save/restore selection in all browsers
Previously this wasn't required due to an iFrame mode.

Change-Id: Ib89af27d5ab6b9b1b05046b32b05ce368ff47a5f
2018-01-02 21:46:31 +00:00
James D. Forrester 6f35dcc39c Merge all the non-styles-only ResourceLoader modules into one
These were always jointly loaded, so they just bloated the module table
to no benefit.

Bug: T165112
Change-Id: I51745e84d6b840a18d84385dfb5ea4f96ada311d
2018-01-02 21:41:42 +00:00
James D. Forrester be36244c70 Radically simplify this extension now there's only one config option
On or off. Pick your apples.

Change-Id: I7677f0b597c33f236192aea1aaa347a36216fbb7
2018-01-02 21:25:16 +00:00
James D. Forrester 73a84dd453 Follow-up 781504057a: Remove the 'dialogs' config object, no longer read
Change-Id: Ife28707368d9c7e058df25f1673aeed75522757a
2018-01-02 21:20:14 +00:00
James D. Forrester 77cea2697c Drop the never-finished "Labs" publish and preview features
These features were ideas in the Usability Initiative but were never
finished to the level that they would be deployed on Wikimedia wikis
and have been marked as "going to be removed" for years. Now is time
to act on that promise.

Change-Id: Ia1eb91d2dfb1979518d97badc1477146b4606f7c
2018-01-02 21:00:44 +00:00
Fomafix dc8bf8ce0a Rename PHP files to match class names
This avoids the exclusion of the rule
MediaWiki.Files.ClassMatchesFilename.NotMatch in .phpcs.xml.

Change-Id: Ia6fdbe9e9ba726d8a6b4d8168d298820e3efc1d2
2017-12-15 11:54:04 +01:00
Fomafix d89d7b7c16 Add "requires": { "MediaWiki": ">= 1.28.0" }
At least the change fe7e2a790c requires
MediaWiki 1.28 or higher.

Change-Id: I6839feeb1ab742868c27e746536877acbb3a862c
2017-12-01 12:15:37 +01:00
Ed Sanders 781504057a Make toolbar and dialog part of the core module
Bug: T163793
Change-Id: Ia6d02b51d4e04f148d836827640ff132366c4bee
2017-05-03 11:54:23 -07:00
SamanthaNguyen 105f31186b Remove deprecated PHP entry point
Bug: T140007
Change-Id: I514be311a359cffd36e404bff3df2c5de05e3b21
2017-04-15 08:11:24 +00:00
Derk-Jan Hartman 10583ec1a7 Avoid flash of content when hiding editHelp and the pipe separator
Bug: T120408
Change-Id: I651ea3d2b891ce347a51be9b3bc3e34351bc53dc
2016-05-25 11:26:13 +00:00
James D. Forrester d7a6475f98 extension.json: Remove call to non-existent wikieditor-toolbar-tool-file-pre i18n
This was present right from the start of this repo (in WikiEditor.php back
then) and I can't quite see where it stopped being a thing, except that it
pre-dates the conversion to en.json.

Change-Id: Ifeebb7dcf511f73f74934ee88a7a007dfdbcc803
2015-11-12 18:05:00 -08:00
James D. Forrester 31d8192cda extension.json: Remove calls to non-existent wikieditor-toolbar-help-content-heading1-*
No idea where these came from; they weren't present in I76e2a685 and yet
appeared in Id90e104 despite that being an apparent script-conversion of
the former.

Bug: T118541
Change-Id: Iac18c3c7ef8b1552313c2bd9f5b8fdc4cb8789b6
2015-11-12 18:04:54 -08:00
James D. Forrester ad1c8d71e6 extension.json: Remove calls to non-existent wikieditor-toolbar-characters-*
These were moved to core in Ifd0ed24 as special-characters-* but were not
removed from here, leading to a lot of failed message loads.

Bug: T118541
Change-Id: I8ccbbbf98177656284712134f3238a9e4482d32d
2015-11-12 18:04:24 -08:00
Prateek Saxena 5ea5952cd1 Use mw.Upload.Dialog to upload and insert file
Bug: T115748
Change-Id: I2427cd959f0d9b6872866e120e7bd0e7e298ec27
2015-10-23 16:54:24 +00:00
Kunal Mehta 3d7d4f85ad Set $wgWikiEditorFeatures in extension.json
We can do this now using a merge strategy of "array_plus_2d".

Change-Id: Ib1536633424bad46ff7861bc145025418af0286a
2015-09-24 21:20:40 -07:00
Schnark 6602d905ee WikiEditor: Move HTML for dialogs to separate files
Move the HTML for the dialogs to separate template files,
using the template mechanism from core.
It is still possible to specify the HTML directly as before,
to be used in gadgets etc.

Change-Id: Ia7ad5aaa9cac429d1c9d706bdf6760e3eda358bc
2015-08-14 13:07:27 +00:00
This, that and the other 52d3e279a1 Replace hidesig module with a more robust implementation
Per T42972, the current hidesig implementation is broken, and only
hides the signature button in namespace 0 regardless of the value of
$wgContentNamespaces.

Seeing as the old implementation of hidesig was broken, I don't really
think backward compatibility with old configurations is a useful
concern here. In particular, hiding of the signature button is no longer
able to be configured in Special:Preferences (why such a trivial pref was
ever able to be exposed to users, I don't know).

Bug: T59727
Change-Id: I596fd435bc9be8c37da43177c1bea90ebff0b2fe
2015-08-05 13:59:00 +10:00
Kunal Mehta 592728483e Set license-name
Change-Id: I197ab648c3e1bdcac8b2dbc6f6ed985b7fd296c7
2015-07-22 22:06:55 -07:00
Schnark 27353c44b7 WikiEditor: Improve help section
* Internal links: Show simple example first
* References: Show use of unnamed references
* Discussion: Use --~~~~ for consistency with what the toolbar button inserts

Bug: T26128
Change-Id: I08de0ad416727447eccad914c2ade3a93e5a8ae2
2015-07-20 07:42:35 +00:00
Fomafix b365425f76 Replace deprecated 'jquery.mwExtension' by 'mediawiki.RegExp'
Replace $.escapeRE from 'jquery.mwExtension' by
mw.RegExp.escape from 'mediawiki.RegExp'.

This change requires MediaWiki 1.26+

Bug: T103993
Change-Id: I5fc19e1313fc6a06726981e0365cea6d00abb5f3
2015-06-26 15:10:20 +00:00
Derk-Jan Hartman e71796a9fd Remove reference to non-existing module
The ext.wikiEditor.init module was removed in 596a790d.

Change-Id: Iaed58f621bc02326630559a389cd1021408e418d
2015-06-24 23:16:32 +00:00
Fomafix edbee613fc Support fallback languages for icons
Use mw.language.getFallbackLanguageChain() to get the
fallback language chain. This chain currently always contains 'en'
as last element. Remove the last element to prevent a fallback to 'en'.

Reimplement autoIconOrOffset to correctly prefer sprite before icon.

Bug: T87247
Change-Id: I452dd45d20ea4dd542d63274b7aad0272e20ea12
2015-06-21 15:42:18 +00:00
Kunal Mehta 6080404f7d Set manifest_version in extension.json
Bug: T100745
Change-Id: I002981d1b755116757a4789fd2f8d198200ab7fc
2015-05-28 20:38:52 -07:00
Gilles Dubuc 849cbf2173 Explicitly define module position
Style modules currently added through addModuleStyles default
to being in the head ("top" position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to "bottom",
existing module positions have to be defined explicitly.

Bug: T97410
Change-Id: I8dbee3e4edf673341e7eb49f360e83e4dac54b17
2015-05-26 12:24:31 +02:00
Kunal Mehta 9de4e8cc00 Empty PHP entry point in favor of extension.json
Extension registration currently doesn't support merging 2d arrays
(T99257), so set it as an explicit global for now in a callback.

Change-Id: If7604a7ed8ec0f940c4a4d2988fcecc383303e1d
2015-05-19 20:48:10 -07:00
Kunal Mehta a5032b1336 Sync extension.json with WikiEditor.php
* 3cb4714e15 "Bump version to 0.5.0 to reflect massive updates in
last year"
* c9c189fd9d "Add dependency on mw.user"

Change-Id: Ic17a7f6a1bf97c955b79c6500ddbec38201aa650
2015-05-19 20:36:36 -07:00
Alex Monk 596a790d00 Try to unbreak WikiEditor modules
Some very weird issues going on involving multiple wikiEditor instances being
set up on the same textarea element. It's probably a race condition of some
sort and I'm hoping that restoring the modules like this will fix it.

Bug: T93384
Change-Id: I44c9c013993220ab709893d239614552d7b25d46
2015-04-07 19:51:58 +01:00
Timo Tijhof 8e78850a3a Don't force a separate http request for ext.wikiEditor.init
Follows-up 74da530f2, which introduced a separate HTTP request
on all pages just for the 665 bytes (compressed) of ext.wikiEditor.init.

Have it join the main load queue instead.

Change-Id: I9e0ce994e632c64f3c781f45ea44582c0a943c65
2015-03-31 20:24:06 +00:00
Alex Monk fb4f71a46b Move WikiEditor's special character data and messages out to core
Core part done in If9c5cdbe

Bug: T91608
Change-Id: Ifd0ed245ca9d1209b3dad5334f3fcfca428ceeec
2015-03-27 22:46:24 +00:00
Kunal Mehta 7466b7414d Add extension.json
Bug: T87993
Change-Id: Ib58cd4425bef52971c577f41f96fb0ea425d2e7d
2015-03-25 22:42:30 +00:00