Commit graph

90 commits

Author SHA1 Message Date
Roman Stolar b76f02e580 Replace usage of ConfirmEdit_ActivateCaptcha random properties.
Use CacheKeyHelper to get a status from SimpleCaptcha instead of it.

Bug: T275710
Depends-On: I7942ccd6b58584f436f872bf7c9deb63ab84482a
Change-Id: Id35ef3bcf30ddc0581c79cc10fa80e54d5352758
2021-11-11 17:11:27 +02:00
Fomafix 05f15dc79f Merge "Use Html::hidden instead of Xml::element" 2021-11-07 17:46:29 +00:00
jenkins-bot c0967dbe3a Merge "Don't add logging-related form inputs if not required" 2021-11-07 13:55:27 +00:00
Fomafix 758d0fb84a Use Html::hidden instead of Xml::element
This change replaces in the HTML

 <input type="hidden" name="wikieditorJavascriptSupport" id="wikieditorJavascriptSupport" value="" />

by

 <input id="wikieditorJavascriptSupport" type="hidden" name="wikieditorJavascriptSupport"/>

but the behavior is still the same.

Change-Id: Icc9b9c9480be3b220148466d3f93746e14de280a
2021-11-05 18:18:35 +00:00
Fomafix fae34607a7 Replace WebRequest::getVal by WebRequest::getRawVal
The UTF-8 normalization of getVal is not needed here.

Also explicit check for !== null instead of truthy because in PHP is
"0" != true.

Change-Id: I77a8a2c149045f677ff2a1f0e42d9ca9dccde321
2021-11-05 17:57:52 +00:00
Sam Wilson d23389cd06 Avoid User::getEditCount() and ::getOption()
The latter is deprecated, and the former is just a wrapper for
UserEditTracker::getUserEditCount().

Bug: T290521
Change-Id: Id3f2b9a007fe299d74d5957cbd3e31b11adb2790
2021-11-05 11:52:00 +08:00
Sam Wilson b980affad6 Don't add logging-related form inputs if not required
Change-Id: I71d7f9b741cb60d0bbb8f0fbd6e8ac0967ee1492
2021-11-03 13:40:19 +08:00
Sam Wilson 0744773321 Fix excluded phpcs rules
Change-Id: Ie0d0a00e2a12dc50bd2ed9ba00b8e7f339227a56
2021-11-02 13:48:27 +08:00
David Lynch 385903a3f0 PHP VisualEditorFeatureUse logging: properly record session id
EditAttemptStep and VisualEditorFeatureUse have this one very annoying
inconsistency.

Bug: T281409
Depends-On: I96e07e10943d330efcf47e0a2989ea3b73bae428
Change-Id: I3bddd3096625466fc5b6c88b64a570a389b87a05
2021-05-12 19:46:36 +00:00
David Lynch cb1c5d49aa Log whether Javascript was supported on saveSuccess
Adds a hidden field to the edit page form, with JS that will set its
value. Server-side then checks for that value and logs whether it was
correctly set.

Bug: T263505
Change-Id: I8be06385aa6d97e5536cfc252d34297e1c000a32
2021-04-30 17:45:40 -05:00
jenkins-bot 5791ee3d51 Merge "Update save failure logging for EditAttemptStep schema" 2021-02-01 18:17:59 +00:00
David Lynch 36a58b5599 Logging init mechanism for new section direct navigation
Support the `url-new` mechanism so we can distinguish between
new/existing sections in direct navigation.

Bug: T272544
Change-Id: I2c431592035c7ccedbbe612bc97f63141fc4dab7
Depends-On: I3cee7a3a4c4b646692dce4a1180c4ba18a61f4bc
2021-01-29 20:56:14 -06:00
David Lynch e052e46f94 Log the DiscussionTools a/b test bucket for relevant schemas
If someone is enrolled the DT a/b test, we want to know about their
editing here as well.

Bug: T273096
Change-Id: If2bb04011c8ca54e8c7ffd073e21bec45e92460c
2021-01-29 20:56:14 -06:00
Bartosz Dziewoński dc93bf1b37 Parse alternative magic word translations when prefilling image fields
In some languages, image options like 'alt' or 'thumb' can have
multiple synonyms. They were only handled for English (and were
hard-coded).

Change-Id: Ib03932d3d85a5540bea325f2717da3365756a90e
2021-01-22 22:15:16 +01:00
Ammar Abdulhamid ab287ade14 Allow specifying alt-text in File dialog
* Also add expandable help message to explain the alt text field

Bug: T260006
Change-Id: If16ff742d7a8dee4917884e73e9c95bf76350773
2021-01-22 21:37:17 +01:00
Bartosz Dziewoński 334618d0b2 Update save failure logging for EditAttemptStep schema
* Use the error code from the API for 'save_failure_message', instead
  of the key of the localisation message shown to the user.

  Although this editor is not using the API, and doesn't use those
  error codes, we still want to use them in logging for consistency
  with all the other editing tools.

  We can easily generate the error codes from the Status we do have.

* Copy 'save_failure_type' map from VisualEditor.

Bug: T272162
Change-Id: Ia9eeea14e3d4a6a691f84628a27ffc0c3bf061c1
2021-01-15 20:17:25 +01:00
jenkins-bot b2f709e5ff Merge "Replace use of old $wgVersion constant with MW_VERSION" 2020-05-13 22:16:53 +00:00
James D. Forrester 4551332586 Replace use of old $wgVersion constant with MW_VERSION
Change-Id: I31e524694ca2e7399b235b89aeeb779a4d13811d
2020-05-13 15:02:38 -07:00
BAGArt e366cc041f Use WikiPage::exists instead hard-deprecated Article::exists
Bug: T251278
Change-Id: Ib617a144279e63c2905d6a0c1048bba65a19115c
2020-04-28 19:20:18 +03:00
Reedy d5d3104a41 WikimediaEventHooks was namespaced
Change-Id: Ic33ec8f08b6fc755e4749e34f734831b8f519be1
2020-04-20 00:24:13 +01:00
DannyS712 d43e91726a Remove use of WikiPage::getRevision
Bug: T249393
Change-Id: I26dc2f750bc1a6315865c5bbfab54799c6b18486
2020-04-07 23:37:53 +00:00
Umherirrender 8af7b2df71 Improve param docs
Change-Id: I0fa1d6aef74f434306d665f39085cd41f710bed1
2020-02-29 22:18:42 +01:00
Derk-Jan Hartman 4906ff1c8c Remove usage of EditPageBeforeEditToolbar
As noted by Jack Phoenix in I07b0e0e030217d74f06bb2b6fc278bd2e28e34b5
the core toolbar has not been present since 1.32 and this hook is
therefore rather pointless.

Change-Id: Ibcf4400237dbf3b195e2bc6a8efee9f1b1527e6d
2020-01-25 17:18:42 +01:00
James D. Forrester d47d0c41b1 Drop back-compat. for MagicWordFactory, this extension requires 1.34+ anyway
Change-Id: I159c168642b3c7315da2de44fb191845c53b399c
2020-01-09 14:26:25 -08:00
Roan Kattouw 253adb8fe8 EditAttemptStep: Allow session ID to be overridden through query string
The editingStatsId POST data parameter was already used to propagate the
session ID within a session; also allow it to be read on GET requests,
to allow the initial session ID to be overridden.

Similarly, propagate the oversampling state and allow it to be set in
the query string using ?editingStatsOversample=1 .

Bug: T238249
Change-Id: Ib4586607b4acb69bdfbd6a8de0f320b90969209a
2019-11-14 11:11:01 -08:00
Umherirrender 13661d374b build: Updating mediawiki/mediawiki-phan-config to 0.8.0
Bug: T235049
Change-Id: I4b5653d9ada66f3458f588e1db9b6da0802348e5
2019-11-05 20:24:04 +01:00
Bartosz Dziewoński d80d4275eb Update SpamBlacklist error logging
The error message key has changed in I4ca8e67e03726696a428093cc9fb547a6daa1492.

Bug: T232687
Change-Id: Id2154bae7ce2f33df63fcf9f7545fb93d38b656e
2019-09-13 01:11:16 +02:00
Roan Kattouw d23d096281 Convert ext.wikiEditor module to packageFiles
This allows us to bundle the wgWikiEditorMagicWords and
mw.msg.wikiEditor(?!) config vars that were previously exported globally
in the startup module.

This code is old and crufty, so this is a somewhat minimal conversion:
* Use require() for jquery.wikiEditor.{dialogs,toolbar}.config.js,
  and for jquery.wikiEditor.{dialogs,toolbar}.js
* Don't attempt to convert jquery.wikiEditor.js to something
  require-based, instead just run it and let it set the $.wikiEditor and
  $.fn.wikiEditor globals
* Consolidate ext.wikiEditor.{dialogs,toolbars}.js into
   ext.wikiEditor.js

Bug: T222828
Change-Id: Ia75d685cbde786e8fceb6db36f2436b2beea1499
2019-08-05 22:24:56 +00:00
Timo Tijhof 14db0b965a Remove unused 'wgWikiEditorEnabledModules' var
This is an internal variable that hasn't been used since 2017
with commit be36244c70. It was kept for back-compat with
regards to caching, which as churned long since.

Bug: T219342
Change-Id: I7c71956e34c1d4312037f9a8d26f81125ab82577
2019-03-29 02:02:52 +00:00
James D. Forrester ebe89e3c7d Replace use of deprecated ResourceLoaderTestModules hook
Use the new extension.json attribute instead.

Bug: T214211
Change-Id: I79c45c6923fd19f6f9f068492b3bd6548161dd04
Depends-On: I27ecebe27d7aaebe6d1317bc5eaea9cca368b45d
2019-02-13 15:24:38 -08:00
Derick Alangi 44b1c8418d Remove "return true" legacy behavior from hook handler functions
Change-Id: I314261115be187d77c3e9f9f30585090eea4718e
2019-02-02 21:21:59 +01:00
jenkins-bot e75c1a53b8 Merge "Re-label preference now that the 2006 wikitext editor doesn't exist" 2018-11-06 15:53:27 +00:00
Roan Kattouw d700202f85 Update EventLogging code for Edit->EditAttemptStep schema migration
The schema itself is being renamed, and many of the field names are
different.

Bug: T207803
Depends-On: I2949c9782669b75cf17978698c8cef21fdee6dea
Change-Id: I07d9bc1530005914043911b7906c1602522c9162
2018-10-29 11:38:07 -07:00
James D. Forrester 169d38fa75 Re-label preference now that the 2006 wikitext editor doesn't exist
Add the secondary label in a 'help' note to make it easier to identify
the different editors.

Bug: T32795
Change-Id: I6d17359166f58811ba99893ce4a4500a87deb827
2018-10-25 14:33:31 -07:00
Roan Kattouw 55b89c1ede Oversample Schema:Edit events when configured to do so
Respect the config var exported by WikimediaEvents that, if set to true,
forces oversampling. When oversampling, all events are logged even if
they would have been sampled out. The isOversample property is set to
true if the event was oversampled and would not otherwise have been
logged.

Bug: T206543
Depends-On: I5fdf5fdd2dc0d99a0a0d7eb7ab2e3dce4798009b
Change-Id: I7e504884a888c4d080cd4762549b72489126ed65
2018-10-18 10:58:45 -07:00
Roan Kattouw e54a4420ca Use Schema:Edit sampling rate config from WikimediaEvents
Instead of hard-coding the 6.25% sampling rate, allow it to be
controlled by the config variable in the WikimediaEvents extension
(which also defines the RL module for the Edit schema).

Also use sampling code from EventLogging so we can configure the
sampling rate as a number, rather than using a hex-digit based strategy.

Bug: T206543
Depends-On: I00383cec62f6c2a0137b329565b0ca84bfbb223f
Depends-On: Ib746fc708e7b752cebc5fd8d080e40819dfa34f3
Change-Id: I2956efc9294768742dd49dcb36770f0509e4090f
2018-10-17 14:30:03 -07:00
James D. Forrester c59430d243 Follow-up 874f9bfb8d: Bump server-side Edit schema version here
We updated it in WikimediaEvents but not here. Whoops.

Bug: T203621
Change-Id: Ie84411bccd5322d6f228e8c905741368485b97d3
2018-09-14 17:22:14 -07:00
Derk-Jan Hartman 38a70500a0 Use ExtensionRegistry instead of class_exists
Bug: T183096
Change-Id: I2b02e89f20ecab9dda44ea9a78067a96fc04392c
2018-08-19 17:17:03 +02:00
Aryeh Gregor 30e00a3bf2 Don't use deprecated MagicWord static methods
Bug: T200247
Depends-On: Ie061fe90f9b9eca0cbf7e8199d9ca325c464867a
Change-Id: I8affa85bb9a55205ac69ca7803693e30c361b275
2018-07-31 20:42:31 +03:00
Kunal Mehta 5ae7c42382 Move WikiEditorHooks into includes/
Change-Id: Ifc4fb72e68d9a879b763061f1585cac47e9f756f
2018-02-16 14:07:54 -08:00