wikimedia/mediawiki-extensions-WikiEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/WikiEditor synced 2024-11-24 08:14:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a configuration variable for disabling tracking clicks on the toolbar buttons

Browse source
This commit is contained in:
Roan Kattouw 2012-02-23 22:29:37 +00:00
parent 462c74edd9
commit f26acc15c7
Notes: Roan Kattouw 2012-02-23 22:29:37 +00:00 
https://mediawiki.org/wiki/Special:Code/MediaWiki/112255
3 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
WikiEditor.hooks.php
View file

@ -29,6 +29,9 @@ class WikiEditorHooks {
'modules' => array( 'modules' => array(
'ext.wikiEditor.toolbar', 'ext.wikiEditor.toolbar',
), ),
'configurations' => array(
'wgWikiEditorToolbarClickTracking',
),
), ),
'dialogs' => array( 'dialogs' => array(
'preferences' => array( 'preferences' => array(

4
WikiEditor.php
View file

@ -46,6 +46,10 @@ $wgWikiEditorFeatures = array(
); );
// If set to true and the ClickTracking extension is installed, track clicks
// on the toolbar buttons
$wgWikiEditorToolbarClickTracking = false;
/* Setup */ /* Setup */
$wgExtensionCredits['other'][] = array( $wgExtensionCredits['other'][] = array(

6
modules/jquery.wikiEditor.toolbar.js
View file

@ -238,7 +238,7 @@ fn: {
doAction : function( context, action, source ) { doAction : function( context, action, source ) {
// Verify that this has been called from a source that's within the toolbar // Verify that this has been called from a source that's within the toolbar
// 'trackAction' defined in click tracking // 'trackAction' defined in click tracking
if ( $.trackAction !== undefined && source.closest( '.wikiEditor-ui-toolbar' ).size() ) { if ( mw.config.get( 'wgWikiEditorToolbarClickTracking' ) && $.trackAction !== undefined && source.closest( '.wikiEditor-ui-toolbar' ).size() ) {
// Build a unique id for this action by tracking the parent rel attributes up to the toolbar level // Build a unique id for this action by tracking the parent rel attributes up to the toolbar level
var rels = []; var rels = [];
var step = source; var step = source;
@ -461,7 +461,7 @@ fn: {
{ expires: 30, path: '/' } { expires: 30, path: '/' }
); );
// Click tracking // Click tracking
if ( $.trackAction !== undefined){ if ( mw.config.get( 'wgWikiEditorToolbarClickTracking' ) && $.trackAction !== undefined ) {
$.trackAction(section + '.' + $(this).attr('rel')); $.trackAction(section + '.' + $(this).attr('rel'));
} }
context.fn.restoreCursorAndScrollTop(); context.fn.restoreCursorAndScrollTop();
@ -640,7 +640,7 @@ fn: {
} ); } );
} }
// Click tracking // Click tracking
if ( $.trackAction !== undefined ) { if ( mw.config.get( 'wgWikiEditorToolbarClickTracking' ) && $.trackAction !== undefined ) {
$.trackAction( $section.attr('rel') + '.' + ( show ? 'show': 'hide' ) ); $.trackAction( $section.attr('rel') + '.' + ( show ? 'show': 'hide' ) );
} }
// Save the currently visible section // Save the currently visible section