wikimedia/mediawiki-extensions-WikiEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/WikiEditor synced 2024-09-23 10:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove loading spinner

Browse source 
Since e8d37102 the loading spinner is not visible, because all actions
relating to it are in the same render step of the browser.

The loading occurs fast enough now, that we also don't want to show an
intermediate spinner.

Change-Id: Id2a3584deed2ecde807d8f354341dd6868b10009
This commit is contained in:
Fomafix 2015-12-13 12:27:58 +00:00 committed by TheDJ
parent f50c6d0bb7
commit ce96b0c72e
3 changed files with 0 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
modules/images/toolbar/loading-small.gif
View file

Binary file not shown.
Side by side

Before

Width:  |  Height:  |  Size: 3.3 KiB

2
modules/jquery.wikiEditor.toolbar.js
View file

@ -447,10 +447,8 @@ $.wikiEditor.modules.toolbar = {
rel: id rel: id
} ); } );
if ( deferLoad ) { if ( deferLoad ) {
$page.addClass( 'loading' ).append( $( '<div>' ).addClass( 'spinner' ) );
$page.bind( 'loadPage', function () { $page.bind( 'loadPage', function () {
$.wikiEditor.modules.toolbar.fn.reallyBuildPage( context, id, page, $page ); $.wikiEditor.modules.toolbar.fn.reallyBuildPage( context, id, page, $page );
$page.removeClass( 'loading' );
} ); } );
} else { } else {
$.wikiEditor.modules.toolbar.fn.reallyBuildPage( context, id, page, $page ); $.wikiEditor.modules.toolbar.fn.reallyBuildPage( context, id, page, $page );

25
modules/jquery.wikiEditor.toolbar.less
View file

@ -32,27 +32,6 @@
.section-hidden { .section-hidden {
display: none; display: none;
} }
/* Gets overridden when the section div is in class loading - see below */
div {
.spinner {
display: none;
}
}
.loading {
.spinner {
.background-image('images/toolbar/loading.gif');
background-position: left center;
background-repeat: no-repeat;
color: #666;
display: block;
float: left;
height: 32px;
margin-left: 0.5em;
padding-left: 32px;
}
}
} }
/* Top Level Containers */ /* Top Level Containers */
@ -91,10 +70,6 @@
text-decoration: none; text-decoration: none;
} }
} }
a.loading {
.background-image('images/toolbar/loading-small.gif');
}
} }
} }