From 908e7cc56c4ef5db2ab0d213b2dbd8c8034a0da7 Mon Sep 17 00:00:00 2001 From: Mwalker Date: Fri, 25 Apr 2014 20:10:09 +0000 Subject: [PATCH] Revert "Preserve textarea state when building WikiEditor UI" Sadly this caused bug 64289; so we're going to revert this for now; then redeploy this and Ib97f47ef1d66420682bd429c9c12e66c3392e77d in one of the swats next week. This reverts commit effd98be7ebaa1f6f0d2c5b524c96ed6e0839a32. Change-Id: Idde3e51e894f8c92f47fb06f0cf08d01e82ccb48 --- modules/jquery.wikiEditor.js | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/modules/jquery.wikiEditor.js b/modules/jquery.wikiEditor.js index 0b874098..c414e192 100644 --- a/modules/jquery.wikiEditor.js +++ b/modules/jquery.wikiEditor.js @@ -486,9 +486,6 @@ if ( !context || typeof context === 'undefined' ) { .append( $( '' + mediaWiki.msg( 'wikieditor-loading' ) + '' ) .css( 'marginTop', context.$textarea.height() / 2 ) ); */ - /* Preserving cursor and focus state, which will get lost due to wrapAll */ - var hasFocus = context.$textarea.is( ':focus' ), - cursorPos = context.$textarea.textSelection( 'getCaretPosition', { startAndEnd: true } ); // Encapsulate the textarea with some containers for layout context.$textarea /* Disabling our loading div for now @@ -500,14 +497,6 @@ if ( !context || typeof context === 'undefined' ) { .wrapAll( $( '
' ).addClass( 'wikiEditor-ui-left' ) ) .wrapAll( $( '
' ).addClass( 'wikiEditor-ui-bottom' ) ) .wrapAll( $( '
' ).addClass( 'wikiEditor-ui-text' ) ); - // Restore scroll position after this wrapAll (tracked by mediawiki.action.edit) - context.$textarea.prop( 'scrollTop', $( '#wpScrolltop' ).val() ); - // Restore focus and cursor if needed - if ( hasFocus ) { - context.$textarea.focus(); - context.$textarea.textSelection( 'setSelection', { start: cursorPos[0], end: cursorPos[1] } ); - } - // Get references to some of the newly created containers context.$ui = context.$textarea.parent().parent().parent().parent().parent(); context.$wikitext = context.$textarea.parent().parent().parent().parent();