wikimedia/mediawiki-extensions-WikiEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/WikiEditor synced 2024-11-15 03:35:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use jQuery.textSelection API for compat with CodeMirror extension

Browse source 
We were already using it for almost all interactions with the editing
area, except for this code which restores the selection after closing
a dialog.

Bug: T254612
Change-Id: I26d22d9c5d64fe8c861405e65cd4464c349aeac9
This commit is contained in:
Bartosz Dziewoński 2020-06-08 19:47:08 +02:00
parent 6703fdefae
commit 036b7c28a3
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
modules/jquery.wikiEditor.js
View file

@ -448,10 +448,7 @@
saveSelection: function () { saveSelection: function () {
context.$focusedElem = $( ':focus' ); context.$focusedElem = $( ':focus' );
context.$textarea.trigger( 'focus' ); context.$textarea.trigger( 'focus' );
context.savedSelection = { context.savedSelection = context.$textarea.textSelection( 'getCaretPosition', { startAndEnd: true } );
selectionStart: context.$textarea[ 0 ].selectionStart,
selectionEnd: context.$textarea[ 0 ].selectionEnd
};
}, },
/** /**
@ -460,7 +457,7 @@
restoreSelection: function () { restoreSelection: function () {
if ( context.savedSelection ) { if ( context.savedSelection ) {
context.$textarea.trigger( 'focus' ); context.$textarea.trigger( 'focus' );
context.$textarea[ 0 ].setSelectionRange( context.savedSelection.selectionStart, context.savedSelection.selectionEnd ); context.$textarea.textSelection( 'setSelection', { start: context.savedSelection[ 0 ], end: context.savedSelection[ 1 ] } );
context.savedSelection = null; context.savedSelection = null;
} }
if ( context.$focusedElem ) { if ( context.$focusedElem ) {