mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-12-12 14:35:28 +00:00
fda2729ebc
The EventLogging extension no longer uses these internal modules. They were phased out as part of last year's "lightweight EventLogging" project (detailed at T187207). Migration notes at T205744. VisualEditor has migrated already, mostly. It still depended on the existence of these module names for some condition guards. * The subscriber for 'mwTimingHandler' was guarded by 'schema.EditAttemptStep', but did not emit events of that schema. What 'mwTimingHandler' really needs is the '*SamplingRate' variable for its call to 'inSample()'. This previously worked because the variable and the schema are both provided by the WikimediaEvents extension. * The subscriber for 'activityHandler' had a separate schema guard. This might suggest an intent for the code to silently degrade if WikimediaEvents were to be changed to no longer supply the second schema, or for the code to work for third-parties without WikimediaEvents if they register only the schema. However, this subscriber too calls 'inSample()' and needs those variables. I've assumed for now that it is okay for these to all be guarded together. Even if the schemas were to be removed and we were to forget updating this code, the new EventLogging client degrades gracefully from this (no errors). Bug: T221281 Change-Id: I260c25752c3becfe6e499813197fbf7a3dba88c3 |
||
|---|---|---|
| .. | ||
| ce | ||
| dm | ||
| init | ||
| tests | ||
| themes | ||
| ui | ||
| ve.MWutils.js | ||