mediawiki-extensions-Visual.../modules/ve-mw/tests/ui/widgets/ve.ui.MWTransclusionOutlineTemplateWidget.test.js
Thiemo Kreuz 06cf00f4c6 Rename and document select/focus events in template dialog
I tried hard to come up with the best possible names. Some of the
criteria I used:
* Longer and more unique is better. This makes it much easier to
  e.g. search for the event name.
* The term "part" should only be used for top-level parts. While
  template parameters have a unique id, they are not a subclass
  of …TransclusionPartModel and therefor not "parts".
* BookletLayout manages "pages" via "page names".
  * The page names of top-level parts are identical with the part
    id, see ve.ui.MWTemplateDialog.getPageFromPart.
  * The page names of parameters are identical with the parameter
    model id, see ve.ui.MWTemplateDialog.onAddParameter.

Some code knows parameter ids, but not what pages are. Other code
knows page names, but not what parameters are. The transition
currently happens in the …OutlineContainerWidget. We might want
to move this point up to the …TemplateDialog. But I would argue
this is good enough for now and can be changed later, if needed.

Bug: T285323
Change-Id: Iab2805b3203988db400b67c8d00e48905fdc53dc
2021-09-01 16:23:59 +00:00

121 lines
4.2 KiB
JavaScript

QUnit.module( 've.ui.MWTransclusionOutlineTemplateWidget' );
QUnit.test( 'Constructor', ( assert ) => {
const transclusion = new ve.dm.MWTransclusionModel(),
template = new ve.dm.MWTemplateModel( transclusion, { wt: 'Example' } ),
widget = new ve.ui.MWTransclusionOutlineTemplateWidget( template );
assert.strictEqual( widget.getData(), 'part_0' );
assert.strictEqual(
widget.$element.find( '.ve-ui-mwTransclusionOutlineButtonWidget' ).text(),
'Example'
);
assert.notOk( widget.searchWidget.isVisible() );
assert.notOk( widget.infoWidget.isVisible() );
} );
QUnit.test( 'insertCheckboxAtCanonicalPosition()', ( assert ) => {
function assertOrder( widget, expected ) {
assert.deepEqual( widget.parameters.items.map( ( item ) => item.data ), expected );
}
const transclusion = new ve.dm.MWTransclusionModel(),
template = ve.dm.MWTemplateModel.newFromData( transclusion, {
target: {},
params: { b: {}, e: {} }
} );
template.getSpec().setTemplateData( {
params: {
e: { deprecated: true },
h: { deprecated: true },
g: {}
},
paramOrder: [ 'g', 'h', 'e' ]
} );
const widget = new ve.ui.MWTransclusionOutlineTemplateWidget( template );
// Expected order on construction time is:
// - Documented params in paramOrder (g, h, e), excluding unused deprected params (- h)
// - Undocumented params currently used in the template (+ b)
assertOrder( widget, [ 'g', 'e', 'b' ] );
let insertAt = widget.findCanonicalPosition( 'h' );
// Most minimal mock instead of an actual ve.ui.MWTransclusionOutlineParameterWidget
widget.parameters.addItems( [ new OO.ui.Widget( { data: 'h' } ) ], insertAt );
// Deprecated param appears at it's canonical position via paramOrder
assert.strictEqual( insertAt, 1 );
assertOrder( widget, [ 'g', 'h', 'e', 'b' ] );
const newParam = new ve.dm.MWParameterModel( template, 'a1' );
// This fires an "add" event the widget listens to, i.e. this covers onAddParameter() as well
template.addParameter( newParam );
assertOrder( widget, [ 'g', 'h', 'e', 'a1', 'b' ] );
// Removing the param doesn't remove it's checkbox item from the widget
template.removeParameter( newParam );
assertOrder( widget, [ 'g', 'h', 'e', 'a1', 'b' ] );
// This is effectively the same as above: teach the spec a new param without adding it to the
// template. This doesn't fire events, which allows us to test the private method in isolation.
template.getSpec().seenParameterNames.a2 = true;
insertAt = widget.findCanonicalPosition( 'a2' );
// Most minimal mock instead of an actual ve.ui.MWTransclusionOutlineParameterWidget
widget.parameters.addItems( [ new OO.ui.Widget( { data: 'a2' } ) ], insertAt );
assert.strictEqual( insertAt, 4 );
assertOrder( widget, [ 'g', 'h', 'e', 'a1', 'a2', 'b' ] );
} );
QUnit.test( 'filterParameters() on an empty template', ( assert ) => {
const transclusion = new ve.dm.MWTransclusionModel(),
template = new ve.dm.MWTemplateModel( transclusion, {} ),
widget = new ve.ui.MWTransclusionOutlineTemplateWidget( template );
let eventsFired = 0;
widget.connect( this, {
filterParametersById: ( visibility ) => {
assert.deepEqual( visibility, {} );
eventsFired++;
}
} );
widget.filterParameters( '' );
assert.ok( widget.infoWidget.isVisible() );
assert.strictEqual( eventsFired, 1 );
} );
QUnit.test( 'filterParameters() considers everything from the spec', ( assert ) => {
const transclusion = new ve.dm.MWTransclusionModel(),
template = ve.dm.MWTemplateModel.newFromData( transclusion, {
target: {},
params: { a: {}, b: {}, c: {}, d: {}, e: {} }
} ),
widget = new ve.ui.MWTransclusionOutlineTemplateWidget( template );
template.getSpec().setTemplateData( {
params: {
c: { label: 'Contains a' },
d: { description: 'Contains a' },
e: { aliases: [ 'Contains a' ] },
f: { label: 'Also contains a, but is not used in the template' }
}
} );
let eventsFired = 0;
widget.connect( this, {
filterParametersById: ( visibility ) => {
assert.deepEqual( visibility, {
'part_0/a': true,
'part_0/b': false,
'part_0/c': true,
'part_0/d': true,
'part_0/e': true
} );
eventsFired++;
}
} );
assert.ok( widget.searchWidget.isVisible() );
widget.filterParameters( ' A ' );
assert.notOk( widget.infoWidget.isVisible() );
assert.strictEqual( eventsFired, 1 );
} );