mediawiki-extensions-Visual.../modules/ve-mw/init/targets
Roan Kattouw dad06ef495 Followup 1c04d32d: release saveDialog reference even if closed
It's good that we're not trying to close the save dialog
if it's not open, but we still need to release our reference
to it in that case, otherwise trying to open the save dialog
in a new incarnation of the editor will fail.

If you opened VE, opened the save dialog, closed it,
went back to read mode, opened VE again, and tried to open the
save dialog again, it would fail because it tried to open
the cached reference to the previous editor's save dialog.

Bonus: prevent JS errors in this case by only attaching an
onClose handler if the dialog actually opened successfully.
If opening the dialog failed, the callback parameter isn't
a promise but an OO.ui.Error, and calling .always() causes
a JS error.

Change-Id: I62d6d3e7cd3df2c29a0c99e2e23bf1aac5187a12
2014-12-08 14:49:39 -08:00
..
ve.init.mw.MobileViewTarget.js Change command list from whitelist to blacklist 2014-11-24 18:28:37 +00:00
ve.init.mw.ViewPageTarget.init.js Fix call to mw.log.warning 2014-12-03 23:35:51 +00:00
ve.init.mw.ViewPageTarget.js Followup 1c04d32d: release saveDialog reference even if closed 2014-12-08 14:49:39 -08:00