mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-24 06:24:08 +00:00
678990cc1e
HtmlOutputRendererHelper will throw HttpErrors when parsoid reports an error. We catch these in ApiParsoidTrait, and convert them to action API error responses. When doing so, we should preserve the additional error data included in the HttpError. Bug: T356157 Change-Id: I8c89468c59314069025537e6807ccbc46dbe13c6
226 lines
6.8 KiB
PHP
226 lines
6.8 KiB
PHP
<?php
|
|
/**
|
|
* Helper functions for contacting Parsoid/RESTBase from the action API.
|
|
*
|
|
* @file
|
|
* @ingroup Extensions
|
|
* @copyright 2011-2020 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license MIT
|
|
*/
|
|
|
|
namespace MediaWiki\Extension\VisualEditor;
|
|
|
|
use ApiUsageException;
|
|
use Language;
|
|
use Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface;
|
|
use MediaWiki\MediaWikiServices;
|
|
use MediaWiki\Rest\HttpException;
|
|
use MediaWiki\Rest\LocalizedHttpException;
|
|
use MediaWiki\Revision\RevisionRecord;
|
|
use MediaWiki\Title\Title;
|
|
use Message;
|
|
use NullStatsdDataFactory;
|
|
use PrefixingStatsdDataFactoryProxy;
|
|
use Psr\Log\LoggerInterface;
|
|
use Psr\Log\NullLogger;
|
|
use Throwable;
|
|
use WebRequest;
|
|
|
|
trait ApiParsoidTrait {
|
|
|
|
private ?LoggerInterface $logger = null;
|
|
private ?StatsdDataFactoryInterface $stats = null;
|
|
|
|
/**
|
|
* @return LoggerInterface
|
|
*/
|
|
protected function getLogger(): LoggerInterface {
|
|
return $this->logger ?: new NullLogger();
|
|
}
|
|
|
|
/**
|
|
* @param LoggerInterface $logger
|
|
*/
|
|
protected function setLogger( LoggerInterface $logger ) {
|
|
$this->logger = $logger;
|
|
}
|
|
|
|
/**
|
|
* @return StatsdDataFactoryInterface
|
|
*/
|
|
protected function getStats(): StatsdDataFactoryInterface {
|
|
return $this->stats ?: new NullStatsdDataFactory();
|
|
}
|
|
|
|
/**
|
|
* @param StatsdDataFactoryInterface $stats
|
|
*/
|
|
protected function setStats( StatsdDataFactoryInterface $stats ) {
|
|
$this->stats = new PrefixingStatsdDataFactoryProxy( $stats, 'VE' );
|
|
}
|
|
|
|
/**
|
|
* @return float Return a start time for use with statsRecordTiming()
|
|
*/
|
|
private function statsGetStartTime(): float {
|
|
return microtime( true );
|
|
}
|
|
|
|
/**
|
|
* @param string $key
|
|
* @param float $startTime from statsGetStartTime()
|
|
*/
|
|
private function statsRecordTiming( string $key, float $startTime ) {
|
|
$duration = ( microtime( true ) - $startTime ) * 1000;
|
|
$this->getStats()->timing( $key, $duration );
|
|
}
|
|
|
|
/**
|
|
* @param HttpException $ex
|
|
* @return never
|
|
* @throws ApiUsageException
|
|
*/
|
|
private function dieWithRestHttpException( HttpException $ex ) {
|
|
if ( $ex instanceof LocalizedHttpException ) {
|
|
$converter = new \MediaWiki\Message\Converter();
|
|
$msg = $converter->convertMessageValue( $ex->getMessageValue() );
|
|
$this->dieWithError( $msg, null, $ex->getErrorData() );
|
|
} else {
|
|
$this->dieWithException( $ex, [ 'data' => $ex->getErrorData() ] );
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Request page HTML from Parsoid.
|
|
*
|
|
* @param RevisionRecord $revision Page revision
|
|
* @return array An array mimicking a RESTbase server's response, with keys: 'headers' and 'body'
|
|
* @phan-return array{body:string,headers:array<string,string>}
|
|
* @throws ApiUsageException
|
|
*/
|
|
protected function requestRestbasePageHtml( RevisionRecord $revision ): array {
|
|
$title = Title::newFromLinkTarget( $revision->getPageAsLinkTarget() );
|
|
$lang = self::getPageLanguage( $title );
|
|
|
|
$startTime = $this->statsGetStartTime();
|
|
try {
|
|
$response = $this->getParsoidClient()->getPageHtml( $revision, $lang );
|
|
} catch ( HttpException $ex ) {
|
|
$this->dieWithRestHttpException( $ex );
|
|
}
|
|
$this->statsRecordTiming( 'ApiVisualEditor.ParsoidClient.getPageHtml', $startTime );
|
|
|
|
return $response;
|
|
}
|
|
|
|
/**
|
|
* Transform HTML to wikitext with Parsoid.
|
|
*
|
|
* @param Title $title The title of the page
|
|
* @param string $html The HTML of the page to be transformed
|
|
* @param int|null $oldid What oldid revision, if any, to base the request from (default: `null`)
|
|
* @param string|null $etag The ETag to set in the HTTP request header
|
|
* @return array An array mimicking a RESTbase server's response, with keys: 'headers' and 'body'
|
|
* @phan-return array{body:string,headers:array<string,string>}
|
|
* @throws ApiUsageException
|
|
*/
|
|
protected function transformHTML(
|
|
Title $title, string $html, int $oldid = null, string $etag = null
|
|
): array {
|
|
$lang = self::getPageLanguage( $title );
|
|
|
|
$startTime = $this->statsGetStartTime();
|
|
try {
|
|
$response = $this->getParsoidClient()->transformHTML( $title, $lang, $html, $oldid, $etag );
|
|
} catch ( HttpException $ex ) {
|
|
$this->dieWithRestHttpException( $ex );
|
|
}
|
|
$this->statsRecordTiming( 'ApiVisualEditor.ParsoidClient.transformHTML', $startTime );
|
|
|
|
return $response;
|
|
}
|
|
|
|
/**
|
|
* Transform wikitext to HTML with Parsoid.
|
|
*
|
|
* @param Title $title The title of the page to use as the parsing context
|
|
* @param string $wikitext The wikitext fragment to parse
|
|
* @param bool $bodyOnly Whether to provide only the contents of the `<body>` tag
|
|
* @param int|null $oldid What oldid revision, if any, to base the request from (default: `null`)
|
|
* @param bool $stash Whether to stash the result in the server-side cache (default: `false`)
|
|
* @return array An array mimicking a RESTbase server's response, with keys: 'headers' and 'body'
|
|
* @phan-return array{body:string,headers:array<string,string>}
|
|
* @throws ApiUsageException
|
|
*/
|
|
protected function transformWikitext(
|
|
Title $title, string $wikitext, bool $bodyOnly, int $oldid = null, bool $stash = false
|
|
): array {
|
|
$lang = self::getPageLanguage( $title );
|
|
|
|
$startTime = $this->statsGetStartTime();
|
|
try {
|
|
$response = $this->getParsoidClient()->transformWikitext(
|
|
$title,
|
|
$lang,
|
|
$wikitext,
|
|
$bodyOnly,
|
|
$oldid,
|
|
$stash
|
|
);
|
|
} catch ( HttpException $ex ) {
|
|
$this->dieWithRestHttpException( $ex );
|
|
}
|
|
$this->statsRecordTiming( 'ApiVisualEditor.ParsoidClient.transformWikitext', $startTime );
|
|
|
|
return $response;
|
|
}
|
|
|
|
/**
|
|
* Get the page language from a title, using the content language as fallback on special pages
|
|
*
|
|
* @param Title $title
|
|
* @return Language Content language
|
|
*/
|
|
public static function getPageLanguage( Title $title ): Language {
|
|
if ( $title->isSpecial( 'CollabPad' ) ) {
|
|
// Use the site language for CollabPad, as getPageLanguage just
|
|
// returns the interface language for special pages.
|
|
// TODO: Let the user change the document language on multi-lingual sites.
|
|
return MediaWikiServices::getInstance()->getContentLanguage();
|
|
} else {
|
|
return $title->getPageLanguage();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @see VisualEditorParsoidClientFactory
|
|
* @return ParsoidClient
|
|
*/
|
|
abstract protected function getParsoidClient(): ParsoidClient;
|
|
|
|
/**
|
|
* @see ApiBase
|
|
* @param string|array|Message $msg See ApiErrorFormatter::addError()
|
|
* @param string|null $code See ApiErrorFormatter::addError()
|
|
* @param array|null $data See ApiErrorFormatter::addError()
|
|
* @param int|null $httpCode HTTP error code to use
|
|
* @return never
|
|
* @throws ApiUsageException
|
|
*/
|
|
abstract public function dieWithError( $msg, $code = null, $data = null, $httpCode = null );
|
|
|
|
/**
|
|
* @see ApiBase
|
|
* @param Throwable $exception See ApiErrorFormatter::getMessageFromException()
|
|
* @param array $options See ApiErrorFormatter::getMessageFromException()
|
|
* @return never
|
|
*/
|
|
abstract public function dieWithException( Throwable $exception, array $options = [] );
|
|
|
|
/**
|
|
* @see ContextSource
|
|
* @return WebRequest
|
|
*/
|
|
abstract public function getRequest();
|
|
}
|