mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-29 08:34:54 +00:00
9e6451d40c
There are two ways dialogs determine if they are inserting or updating. 1. They evaluate whether the dialog is inserting or not and set a boolean flag, used later to steer the saving code 2. They evaluate whether the dialog is inserting or not and, if not, store the node to be updated in a property, used later to steer the saving code In the reference list dialog, setup used strategy 1, and teardown used strategy 2. We've now normalized to use strategy 2 in both methods, which fixes this bug. Bug: 61885 Change-Id: I1b077b2aef4121328bce2b373874dd7373e405a1
164 lines
3.9 KiB
JavaScript
164 lines
3.9 KiB
JavaScript
/*!
|
|
* VisualEditor user interface MWReferenceListDialog class.
|
|
*
|
|
* @copyright 2011-2014 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
/**
|
|
* Dialog for inserting and editing MediaWiki reference lists.
|
|
*
|
|
* @class
|
|
* @extends ve.ui.Dialog
|
|
*
|
|
* @constructor
|
|
* @param {Object} [config] Configuration options
|
|
*/
|
|
ve.ui.MWReferenceListDialog = function VeUiMWReferenceListDialog( config ) {
|
|
// Configuration initialization
|
|
config = ve.extendObject( { 'size': 'small' }, config );
|
|
|
|
// Parent constructor
|
|
ve.ui.Dialog.call( this, config );
|
|
|
|
// Properties
|
|
this.node = null;
|
|
};
|
|
|
|
/* Inheritance */
|
|
|
|
OO.inheritClass( ve.ui.MWReferenceListDialog, ve.ui.Dialog );
|
|
|
|
/* Static Properties */
|
|
|
|
ve.ui.MWReferenceListDialog.static.name = 'referenceList';
|
|
|
|
ve.ui.MWReferenceListDialog.static.title =
|
|
OO.ui.deferMsg( 'visualeditor-dialog-referencelist-title' );
|
|
|
|
ve.ui.MWReferenceListDialog.static.icon = 'references';
|
|
|
|
/* Methods */
|
|
|
|
/**
|
|
* @inheritdoc
|
|
*/
|
|
ve.ui.MWReferenceListDialog.prototype.initialize = function () {
|
|
// Parent method
|
|
ve.ui.Dialog.prototype.initialize.call( this );
|
|
|
|
// Properties
|
|
this.editPanel = new OO.ui.PanelLayout( {
|
|
'$': this.$, 'scrollable': true, 'padded': true
|
|
} );
|
|
this.optionsFieldset = new OO.ui.FieldsetLayout( {
|
|
'$': this.$
|
|
} );
|
|
|
|
this.groupInput = new OO.ui.TextInputWidget( {
|
|
'$': this.$,
|
|
'placeholder': ve.msg( 'visualeditor-dialog-reference-options-group-placeholder' )
|
|
} );
|
|
this.groupField = new OO.ui.FieldLayout( this.groupInput, {
|
|
'$': this.$,
|
|
'align': 'top',
|
|
'label': ve.msg( 'visualeditor-dialog-reference-options-group-label' )
|
|
} );
|
|
|
|
this.applyButton = new OO.ui.ButtonWidget( {
|
|
'$': this.$,
|
|
'flags': ['primary']
|
|
} );
|
|
|
|
// Events
|
|
this.applyButton.connect( this, { 'click': [ 'close', { 'action': 'apply' } ] } );
|
|
|
|
// Initialization
|
|
this.optionsFieldset.addItems( [ this.groupField ] );
|
|
this.editPanel.$element.append( this.optionsFieldset.$element );
|
|
this.$body.append( this.editPanel.$element );
|
|
this.$foot.append( this.applyButton.$element );
|
|
};
|
|
|
|
/**
|
|
* @inheritdoc
|
|
*/
|
|
ve.ui.MWReferenceListDialog.prototype.setup = function ( data ) {
|
|
// Parent method
|
|
ve.ui.Dialog.prototype.setup.call( this, data );
|
|
|
|
var node, refGroup;
|
|
|
|
// Prepopulate from existing node if we're editing a node
|
|
// instead of inserting a new one
|
|
node = this.getFragment().getSelectedNode();
|
|
if ( node instanceof ve.dm.MWReferenceListNode ) {
|
|
refGroup = node.getAttribute( 'refGroup' );
|
|
this.node = node;
|
|
} else {
|
|
refGroup = '';
|
|
this.node = null;
|
|
}
|
|
|
|
this.groupInput.setValue( refGroup );
|
|
this.applyButton.setLabel ( ve.msg (
|
|
this.node ?
|
|
'visualeditor-dialog-action-apply' :
|
|
'visualeditor-dialog-referencelist-insert-button'
|
|
) );
|
|
};
|
|
|
|
/**
|
|
* @inheritdoc
|
|
*/
|
|
ve.ui.MWReferenceListDialog.prototype.teardown = function ( data ) {
|
|
var refGroup, listGroup, oldListGroup, attrChanges, doc,
|
|
surfaceModel = this.getFragment().getSurface();
|
|
|
|
// Data initialization
|
|
data = data || {};
|
|
|
|
// Save changes
|
|
if ( data.action === 'apply' ) {
|
|
refGroup = this.groupInput.getValue();
|
|
listGroup = 'mwReference/' + refGroup;
|
|
|
|
if ( this.node ) {
|
|
// Edit existing model
|
|
doc = surfaceModel.getDocument();
|
|
oldListGroup = this.node.getAttribute( 'listGroup' );
|
|
|
|
if ( listGroup !== oldListGroup ) {
|
|
attrChanges = {
|
|
listGroup: listGroup,
|
|
refGroup: refGroup
|
|
};
|
|
surfaceModel.change(
|
|
ve.dm.Transaction.newFromAttributeChanges(
|
|
doc, this.node.getOuterRange().start, attrChanges
|
|
)
|
|
);
|
|
}
|
|
} else {
|
|
// Create new model
|
|
surfaceModel.getFragment().collapseRangeToEnd().insertContent( [
|
|
{
|
|
'type': 'mwReferenceList',
|
|
'attributes': {
|
|
'listGroup': listGroup,
|
|
'refGroup': refGroup
|
|
}
|
|
},
|
|
{ 'type': '/mwReferenceList' }
|
|
] ).collapseRangeToEnd().select();
|
|
}
|
|
}
|
|
|
|
// Parent method
|
|
ve.ui.Dialog.prototype.teardown.call( this, data );
|
|
};
|
|
|
|
/* Registration */
|
|
|
|
ve.ui.dialogFactory.register( ve.ui.MWReferenceListDialog );
|