mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-15 10:35:48 +00:00
83e1888275
Annotations' attributes might contain DOM elements, which cause infinite recursion in ve.compare(). Annotation classes can protect against this by overriding getHashObject() to summarize DOM nodes, but that doesn't help if that's not respected everywhere. Instead, compare the hash objects, those are safe. This does not appear to be a problem in practice, currently, because the nowiki annotation is experimental, oo.compare() now short-circuits if a === b, and because of optimizations in openAndCloseAnnotations() which lead to the relevant compareToForSerialization() code path being taken very rarely. Bug: 51948 Change-Id: If1bcc3eee4fd14d107db1935d89dcc5516643b53 |
||
---|---|---|
.. | ||
jquery | ||
oojs | ||
qunit | ||
rangy | ||
unicodejs | ||
ve | ||
ve-mw |