mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-26 07:15:32 +00:00
d487b44dd0
Symptoms: * When adding a template with required parameters, the last parameter is initially focused * Parameters and parts appear out of order, and adding/remove/moving them shows them in almost random placement Diagnoses: * Parameters are auto-focused when added, and parameters are auto-added in forward order * TransclusionModel's process method had a bug in which the code to derive an offset from the item being removed would not be reachable due to an inverted logic statement Prognosis: * Fatal, with a 10% chance of survival Treatment: * Set focus on the first parameter after auto-adding required parameters to a template * Invert the logic in TransclusionModel's process method, so that if the index IS undefined we will proceed to define it Change-Id: I299053b63045ec933747831f1b4aa63493760f8b
89 lines
2.9 KiB
JavaScript
89 lines
2.9 KiB
JavaScript
/*!
|
|
* VisualEditor user interface MWTemplatePlaceholderPage class.
|
|
*
|
|
* @copyright 2011-2014 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
/**
|
|
* MediaWiki transclusion dialog placeholder page.
|
|
*
|
|
* @class
|
|
* @extends OO.ui.PageLayout
|
|
*
|
|
* @constructor
|
|
* @param {ve.dm.MWTemplatePlaceholderModel} placeholder Template placeholder
|
|
* @param {string} name Unique symbolic name of page
|
|
* @param {Object} [config] Configuration options
|
|
*/
|
|
ve.ui.MWTemplatePlaceholderPage = function VeUiMWTemplatePlaceholder( placeholder, name, config ) {
|
|
// Configuration initialization
|
|
config = ve.extendObject( { 'icon': 'template', 'movable': true }, config );
|
|
|
|
// Parent constructor
|
|
OO.ui.PageLayout.call( this, name, config );
|
|
|
|
// Properties
|
|
this.placeholder = placeholder;
|
|
this.label = this.$( '<span>' )
|
|
.addClass( 've-ui-mwTransclusionDialog-placeholder-label' )
|
|
.text( ve.msg( 'visualeditor-dialog-transclusion-placeholder' ) );
|
|
this.addTemplateInput = new ve.ui.MWTitleInputWidget( {
|
|
'$': this.$, '$overlay': this.$overlay, 'namespace': 10
|
|
} )
|
|
.connect( this, {
|
|
'change': 'onTemplateInputChange',
|
|
'enter': 'onAddTemplate'
|
|
} );
|
|
this.addTemplateButton = new OO.ui.ButtonWidget( {
|
|
'$': this.$,
|
|
'label': ve.msg( 'visualeditor-dialog-transclusion-add-template' ),
|
|
'flags': ['constructive'],
|
|
'disabled': true
|
|
} )
|
|
.connect( this, { 'click': 'onAddTemplate' } );
|
|
this.removeButton = new OO.ui.ButtonWidget( {
|
|
'$': this.$,
|
|
'frameless': true,
|
|
'icon': 'remove',
|
|
'title': ve.msg( 'visualeditor-dialog-transclusion-remove-template' ),
|
|
'flags': ['destructive'],
|
|
'classes': [ 've-ui-mwTransclusionDialog-removeButton' ]
|
|
} )
|
|
.connect( this, { 'click': 'onRemoveButtonClick' } );
|
|
this.addTemplateFieldset = new OO.ui.FieldsetLayout( {
|
|
'$': this.$,
|
|
'label': ve.msg( 'visualeditor-dialog-transclusion-placeholder' ),
|
|
'icon': 'template',
|
|
'classes': [ 've-ui-mwTransclusionDialog-addTemplateFieldset' ],
|
|
'$content': this.addTemplateInput.$element.add( this.addTemplateButton.$element )
|
|
} );
|
|
|
|
// Initialization
|
|
this.$element.append( this.addTemplateFieldset.$element, this.removeButton.$element );
|
|
};
|
|
|
|
/* Inheritance */
|
|
|
|
OO.inheritClass( ve.ui.MWTemplatePlaceholderPage, OO.ui.PageLayout );
|
|
|
|
/* Methods */
|
|
|
|
ve.ui.MWTemplatePlaceholderPage.prototype.onAddTemplate = function () {
|
|
var transclusion = this.placeholder.getTransclusion(),
|
|
part = ve.dm.MWTemplateModel.newFromName( transclusion, this.addTemplateInput.getValue() );
|
|
|
|
transclusion.replacePart( this.placeholder, part );
|
|
this.addTemplateInput.pushPending();
|
|
this.addTemplateButton.setDisabled( true );
|
|
this.removeButton.setDisabled( true );
|
|
};
|
|
|
|
ve.ui.MWTemplatePlaceholderPage.prototype.onTemplateInputChange = function ( value ) {
|
|
this.addTemplateButton.setDisabled( value === '' );
|
|
};
|
|
|
|
ve.ui.MWTemplatePlaceholderPage.prototype.onRemoveButtonClick = function () {
|
|
this.placeholder.remove();
|
|
};
|