mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-09-27 04:06:51 +00:00
a51fbbb300
Problem: When the toolbar is created twice with the same config object, the second time around the tools are still bound to the old surface Reason: The tool config is overwritten such that symbolic names of tools are replaced with instances of tools, bound to a specific surface. The second time around, the creation fails (silently in a try-catch) and then the already translated list of tools is used to create a new toolbar filled with old tools still bound to the wrong surface. Solution: Leave the config object alone, and instead build a new list of tool instances while iterating through tool names. Bonus: Don't fail silently. Using a try-catch to detect whether a requested tool is supported masks other errors, and is evil. Instead, just do a lookup and skip tools in which the lookup's result is falsey. Change-Id: Ic43ec29173e556592bb3db9399ff83787e0a6857
106 lines
2.5 KiB
JavaScript
106 lines
2.5 KiB
JavaScript
/*!
|
|
* VisualEditor UserInterface Toolbar class.
|
|
*
|
|
* @copyright 2011-2013 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
/**
|
|
* UserInterface toolbar.
|
|
*
|
|
* @class
|
|
* @extends ve.Element
|
|
* @mixins ve.EventEmitter
|
|
*
|
|
* @constructor
|
|
* @param {Object} [config] Config options
|
|
* @cfg {boolean} [actions] Add an actions section opposite to the tools
|
|
* @cfg {boolean} [shadow] Add a shadow below the toolbar
|
|
*/
|
|
ve.ui.Toolbar = function VeUiToolbar( options ) {
|
|
// Configuration initialization
|
|
options = options || {};
|
|
|
|
// Parent constructor
|
|
ve.Element.call( this, options );
|
|
|
|
// Mixin constructors
|
|
ve.EventEmitter.call( this );
|
|
|
|
// Properties
|
|
this.$bar = this.$$( '<div>' );
|
|
this.$tools = this.$$( '<div>' );
|
|
this.$actions = this.$$( '<div>' );
|
|
this.initialized = false;
|
|
|
|
// Events
|
|
this.$
|
|
.add( this.$bar ).add( this.$tools ).add( this.$actions )
|
|
.on( 'mousedown', false );
|
|
|
|
// Initialization
|
|
this.$tools.addClass( 've-ui-toolbar-tools' );
|
|
this.$bar.addClass( 've-ui-toolbar-bar' ).append( this.$tools );
|
|
if ( options.actions ) {
|
|
this.$actions.addClass( 've-ui-toolbar-actions' );
|
|
this.$bar.append( this.$actions );
|
|
}
|
|
this.$bar.append( '<div style="clear:both"></div>' );
|
|
if ( options.shadow ) {
|
|
this.$bar.append( '<div class="ve-ui-toolbar-shadow"></div>' );
|
|
}
|
|
this.$.addClass( 've-ui-toolbar' ).append( this.$bar );
|
|
};
|
|
|
|
/* Inheritance */
|
|
|
|
ve.inheritClass( ve.ui.Toolbar, ve.Element );
|
|
|
|
ve.mixinClass( ve.ui.Toolbar, ve.EventEmitter );
|
|
|
|
/* Methods */
|
|
|
|
/**
|
|
* Initialize all tools and groups.
|
|
*
|
|
* @method
|
|
* @param {Object[]} config List of tool group configurations
|
|
*/
|
|
ve.ui.Toolbar.prototype.setup = function ( config ) {
|
|
var i, j, group, items, tools;
|
|
|
|
for ( i = 0; i < config.length; i++ ) {
|
|
items = config[i].items;
|
|
tools = [];
|
|
group = new ve.ui.ToolGroup( this, { '$$': this.$$ } );
|
|
|
|
// Add tools
|
|
for ( j = 0; j < items.length; j++ ) {
|
|
if ( ve.ui.toolFactory.lookup( items[j] ) ) {
|
|
tools.push( ve.ui.toolFactory.create( items[j], this ) );
|
|
}
|
|
}
|
|
group.addItems( tools );
|
|
|
|
// Append group
|
|
this.$tools.append( group.$ );
|
|
}
|
|
};
|
|
|
|
/**
|
|
* Sets up handles and preloads required information for the toolbar to work.
|
|
* This must be called immediately after it is attached to a visible document.
|
|
*/
|
|
ve.ui.Toolbar.prototype.initialize = function () {
|
|
this.initialized = true;
|
|
};
|
|
|
|
/**
|
|
* Destroys toolbar, removing event handlers and DOM elements.
|
|
*
|
|
* Call this whenever you are done using a toolbar.
|
|
*/
|
|
ve.ui.Toolbar.prototype.destroy = function () {
|
|
this.$.remove();
|
|
};
|