mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-15 18:39:52 +00:00
a15b2f77f2
Add some missing constructor names and rename the ones with a lowercase 'v'. I previously changed Object.create and others to using hasOwn, but that turned out to be useless. The thought at the time was to only use the native one if it really is a native one (and not a polyfill from another script), however in then hasOwn is only relevant on prototypes and when negated. For static members it would be an own-property either way. Follows-up: * Id6783fcfc35a896db088ff424ff9faaabcaff716 (metanode) * Iab763954fb8cf375900d7a9a92dec1c755d5407e (object-management) Change-Id: Ia6ef597e5e5453277472dfc23f25d2878b68b7f6
53 lines
1.4 KiB
JavaScript
53 lines
1.4 KiB
JavaScript
/**
|
|
* VisualEditor Factory tests.
|
|
*
|
|
* @copyright 2011-2012 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
QUnit.module( 've.Factory' );
|
|
|
|
/* Stubs */
|
|
|
|
ve.FactoryObjectStub = function VeFactoryObjectStub( a, b, c ) {
|
|
this.a = a;
|
|
this.b = b;
|
|
this.c = c;
|
|
};
|
|
|
|
/* Tests */
|
|
|
|
QUnit.test( 'register', 1, function ( assert ) {
|
|
var factory = new ve.Factory();
|
|
assert.throws(
|
|
function () {
|
|
factory.register( 'factory-object-stub', 'not-a-function' );
|
|
},
|
|
Error,
|
|
'throws an exception when trying to register a non-function value as a constructor'
|
|
);
|
|
} );
|
|
|
|
QUnit.test( 'create', 2, function ( assert ) {
|
|
var factory = new ve.Factory();
|
|
assert.throws(
|
|
function () {
|
|
factory.create( 'factory-object-stub', 23, 'foo', { 'bar': 'baz' } );
|
|
},
|
|
Error,
|
|
'throws an exception when trying to create a object of an unregistered type'
|
|
);
|
|
factory.register( 'factory-object-stub', ve.FactoryObjectStub );
|
|
assert.deepEqual(
|
|
factory.create( 'factory-object-stub', 16, 'foo', { 'baz': 'quux' } ),
|
|
new ve.FactoryObjectStub( 16, 'foo', { 'baz': 'quux' } ),
|
|
'creates objects of a registered type and passes through arguments'
|
|
);
|
|
} );
|
|
|
|
QUnit.test( 'lookup', 1, function ( assert ) {
|
|
var factory = new ve.Factory();
|
|
factory.register( 'factory-object-stub', ve.FactoryObjectStub );
|
|
assert.strictEqual( factory.lookup( 'factory-object-stub' ), ve.FactoryObjectStub );
|
|
} );
|