mediawiki-extensions-Visual.../modules/ve-mw/dm
Bartosz Dziewoński 86f2057c81 Always generate empty wrapper paragraph inside image captions (slugs begone!)
While all of the following are valid in the model:

1. <mwBlockImage></mwBlockImage>
   Image with no caption. Must use the media dialog to insert one.
2. <mwBlockImage><mwImageCaption></mwImageCaption></mwBlockImage>
   Image with empty caption. There is a slug to insert a paragraph.
3. <mwBlockImage><mwImageCaption><paragraph></paragraph></mwImageCaption></mwBlockImage>
   Image with caption with empty paragraph. Nice and intuitive!

(Same for <mwGalleryImage> / <mwGalleryImageCaption>.)

The third option is the most convenient for the user. We should always
generate that when converting documents from HTML and from the editing
tools (MWGalleryDialog, MWMediaDialog/MWImageModel).

Previously, the editing tools generated option 2 if no caption text
was entered, and the converter generated option 2 if there was no
caption node or if it was empty. Curiously, option 1 was never used.

Wikitext for manual testing:

```
[[File:Foo.png|thumb]]
[[File:Foo.png|thumb|]]
[[File:Foo.png|thumb|Caption]]

<gallery mode="packed">
File:Foo.png
File:Foo.png|
File:Foo.png|Caption
</gallery>
```

Bug: T200387
Change-Id: Ie82fb339f6bd8ae1b289235bf5402490722d9a7c
2018-08-01 05:40:57 +02:00
..
annotations Make link annotations more flexible 2018-07-26 15:12:19 +02:00
metaitems Update VE core submodule to master (a1fd90540) 2018-06-20 12:53:43 +02:00
models Always generate empty wrapper paragraph inside image captions (slugs begone!) 2018-08-01 05:40:57 +02:00
nodes Always generate empty wrapper paragraph inside image captions (slugs begone!) 2018-08-01 05:40:57 +02:00
ve.dm.MWWikitextSurface.js Always set sourceMode=true on dm.MWWikitextSurface 2018-02-27 12:19:06 +00:00
ve.dm.MWWikitextSurfaceFragment.js Only resolve wikitext promise when progress dialog has closed 2018-04-17 16:33:14 +00:00