mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-09-29 05:06:46 +00:00
bb45d984ca
<a href="Foo%3F"> would dirty-diff to <a href="Foo?"> and also render as such, pointing to the wrong page. We also called decodeURIComponent() on the href twice, which can't have been good. Move URI decoding and underscore normalization into getTargetDataFromHref(), and add rawTitle for callers that need it. Put rawTitle in the origTitle attribute, so that equivalence comparisons (decode(origTitle) === title) work as intended. Bug: T145978 Change-Id: I29331a4ab0f8f7ef059c109f6813fa670a2c7390
64 lines
1.9 KiB
JavaScript
64 lines
1.9 KiB
JavaScript
/*!
|
|
* VisualEditor DataModel MWInternalLinkAnnotation tests.
|
|
*
|
|
* @copyright 2011-2016 VisualEditor Team and others; see http://ve.mit-license.org
|
|
*/
|
|
|
|
QUnit.module( 've.dm.MWInternalLinkAnnotation' );
|
|
|
|
QUnit.test( 'toDataElement', function ( assert ) {
|
|
var i, l,
|
|
doc = ve.dm.example.createExampleDocument(),
|
|
internalLink = function ( pageTitle ) {
|
|
var link = document.createElement( 'a' );
|
|
link.setAttribute( 'href', location.origin + mw.Title.newFromText( pageTitle ).getUrl() );
|
|
return link;
|
|
},
|
|
cases = [
|
|
{
|
|
msg: 'Simple',
|
|
element: internalLink( 'Foo' ),
|
|
expected: {
|
|
type: 'link/mwInternal',
|
|
attributes: {
|
|
hrefPrefix: '',
|
|
lookupTitle: 'Foo',
|
|
normalizedTitle: 'Foo',
|
|
origTitle: 'Foo',
|
|
title: 'Foo'
|
|
}
|
|
}
|
|
},
|
|
{
|
|
// Because percent-encoded URLs aren't valid titles, but what they decode to might be
|
|
msg: 'Percent encoded characters',
|
|
element: internalLink( 'Foo?' ),
|
|
expected: {
|
|
type: 'link/mwInternal',
|
|
attributes: {
|
|
hrefPrefix: '',
|
|
lookupTitle: 'Foo?',
|
|
normalizedTitle: 'Foo?',
|
|
origTitle: 'Foo%3F',
|
|
title: 'Foo?'
|
|
}
|
|
}
|
|
}
|
|
],
|
|
converter = new ve.dm.Converter( ve.dm.modelRegistry, ve.dm.nodeFactory, ve.dm.annotationFactory, ve.dm.metaItemFactory );
|
|
|
|
// toDataElement is called during a converter run, so we need to fake up a bit of state to test it.
|
|
// This would normally be done by ve.dm.converter.getModelFromDom.
|
|
converter.doc = doc.getHtmlDocument();
|
|
converter.targetDoc = doc.getHtmlDocument();
|
|
converter.store = doc.getStore();
|
|
converter.internalList = doc.getInternalList();
|
|
converter.contextStack = [];
|
|
|
|
QUnit.expect( cases.length );
|
|
|
|
for ( i = 0, l = cases.length; i < l; i++ ) {
|
|
assert.deepEqual( ve.dm.MWInternalLinkAnnotation.static.toDataElement( [ cases[ i ].element ], converter ), cases[ i ].expected, cases[ i ].msg );
|
|
}
|
|
} );
|