mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-16 19:09:29 +00:00
97486b2b3d
I found this while working on T274551, which is all about the definition of "empty". In the old sidebar a parameter's name is dimmed (gray) as long as the parameter's value is empty. This stops working entirely when there is a default value. My first impulse was "this is a bug". When there is a default value, both the empty string and the default value (when the user enters it exactly) typically trigger the same behavior: The template uses the default value, just as if the user entered it. But this code is correct because of the way it is used. Only parameters that are "truly" empty should be visually marked as such. The moment there is a default value it is either impossible to change this back to an empty string – meaning the parameter can never be truly empty – or the empty string is meaningful user input. Bug: T274551 Change-Id: I90657bfe83e56afd3942428c0dd8a47b444e39c9 |
||
---|---|---|
.. | ||
actions | ||
commands | ||
contextitems | ||
datatransferhandlers | ||
dialogs | ||
elements | ||
inspectors | ||
pages | ||
styles | ||
tools | ||
widgets | ||
ve.ui.MWCommandRegistry.js | ||
ve.ui.MWExtensionWindow.js | ||
ve.ui.MWSequenceRegistry.js | ||
ve.ui.MWSurface.js | ||
ve.ui.MWTransclusionsBooklet.js | ||
ve.ui.MWWikitextCommandRegistry.js | ||
ve.ui.MWWikitextDataTransferHandlerFactory.js | ||
ve.ui.MWWikitextSequenceRegistry.js | ||
ve.ui.MWWikitextSurface.js | ||
ve.ui.MWWikitextTransferRegistry.js |