mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-15 18:39:52 +00:00
9ff6737f4c
Rather than using namespaced linmod attributes, store the preserved HTML attributes in the .htmlAttributes property of the linear model element, in a nested structure to allow for easier treatment of child nodes. Also added attribute order preservation by storing attributes as an object plus an array of keys. ve.ce.Node.js: * Remove html/* attribute synchronization. Doesn't make sense any more because these things aren't in the attributes object any more. I don't think it ever made sense because these attributes were never supposed to be changed anyway. ve.ce.View.js: * Replace renderAttributes() with a simple wrapper around renderHtmlAttributeList() ve.dm.Converter.js: * Add buildHtmlAttributeList() and renderHtmlAttributes() for building and rendering HTML attribute lists ve.dm.Model.js: * Add getter for .htmlAttributes ve.dm.Node.js: * Drop .htmlAttributes on clone, and remove logic dropping html/* ve.ui.MWCategoryWidget.js: * Remove html/0/about hack, was already unnecessary and now doesn't work any more tests/: * UPDATE ALL THE TESTS Change-Id: I620573afd70d36ade6b80413075b6e1f4a435abe
163 lines
3.9 KiB
JavaScript
163 lines
3.9 KiB
JavaScript
/*!
|
|
* VisualEditor ContentEditable View class.
|
|
*
|
|
* @copyright 2011-2013 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
/**
|
|
* Generic base class for CE views.
|
|
*
|
|
* @abstract
|
|
* @extends ve.Element
|
|
* @mixins ve.EventEmitter
|
|
*
|
|
* @constructor
|
|
* @param {ve.dm.Model} model Model to observe
|
|
* @param {Object} [config] Config options
|
|
*/
|
|
ve.ce.View = function VeCeView( model, config ) {
|
|
// Setting this property before calling the parent constructor allows overriden #getTagName
|
|
// methods in view classes to have access to the model when they are called for the first time
|
|
// inside of ve.Element
|
|
this.model = model;
|
|
|
|
// Parent constructor
|
|
ve.Element.call( this, config );
|
|
|
|
// Mixin constructors
|
|
ve.EventEmitter.call( this );
|
|
|
|
// Properties
|
|
this.live = false;
|
|
|
|
// Events
|
|
this.connect( this, {
|
|
'setup': 'onSetup',
|
|
'teardown': 'onTeardown'
|
|
} );
|
|
|
|
// Initialization
|
|
this.renderAttributes();
|
|
};
|
|
|
|
/* Inheritance */
|
|
|
|
ve.inheritClass( ve.ce.View, ve.Element );
|
|
|
|
ve.mixinClass( ve.ce.View, ve.EventEmitter );
|
|
|
|
/* Events */
|
|
|
|
/**
|
|
* @event live
|
|
*/
|
|
|
|
/* Static Members */
|
|
|
|
/**
|
|
* Allowed attributes for DOM elements.
|
|
*
|
|
* This list includes attributes that are generally safe to include in HTML loaded from a
|
|
* foreign source and displaying it inside the browser. It doesn't include any event attributes,
|
|
* for instance, which would allow arbitrary JavaScript execution. This alone is not enough to
|
|
* make HTML safe to display, but it helps.
|
|
*
|
|
* TODO: Rather than use a single global list, set these on a per-view basis to something that makes
|
|
* sense for that view in particular.
|
|
*
|
|
* @static
|
|
* @property static.domAttributeWhitelist
|
|
* @inheritable
|
|
*/
|
|
ve.ce.View.static.domAttributeWhitelist = [
|
|
'abbr', 'about', 'align', 'alt', 'axis', 'bgcolor', 'border', 'cellpadding', 'cellspacing',
|
|
'char', 'charoff', 'cite', 'class', 'clear', 'color', 'colspan', 'datatype', 'datetime',
|
|
'dir', 'face', 'frame', 'headers', 'height', 'href', 'id', 'itemid', 'itemprop', 'itemref',
|
|
'itemscope', 'itemtype', 'lang', 'noshade', 'nowrap', 'property', 'rbspan', 'rel',
|
|
'resource', 'rev', 'rowspan', 'rules', 'scope', 'size', 'span', 'src', 'start', 'style',
|
|
'summary', 'title', 'type', 'typeof', 'valign', 'value', 'width'
|
|
];
|
|
|
|
/**
|
|
* Whether or not HTML attributes listed in domAttributeWhitelist and present in HTMLDOM should be
|
|
* added to node anchor (this.$).
|
|
*
|
|
* @static
|
|
* @property static.renderHtmlAttributes
|
|
* @inheritable
|
|
*/
|
|
ve.ce.View.static.renderHtmlAttributes = true;
|
|
|
|
/* Methods */
|
|
|
|
/**
|
|
* Handle setup event.
|
|
*
|
|
* @method
|
|
*/
|
|
ve.ce.View.prototype.onSetup = function () {
|
|
this.$.data( 'view', this );
|
|
};
|
|
|
|
/**
|
|
* Handle teardown event.
|
|
*
|
|
* @method
|
|
*/
|
|
ve.ce.View.prototype.onTeardown = function () {
|
|
this.$.removeData( 'view' );
|
|
};
|
|
|
|
/**
|
|
* Get the model the view observes.
|
|
*
|
|
* @method
|
|
* @returns {ve.dm.Node} Model the view observes
|
|
*/
|
|
ve.ce.View.prototype.getModel = function () {
|
|
return this.model;
|
|
};
|
|
|
|
/**
|
|
* Check if the view is attached to the live DOM.
|
|
*
|
|
* @method
|
|
* @returns {boolean} View is attached to the live DOM
|
|
*/
|
|
ve.ce.View.prototype.isLive = function () {
|
|
return this.live;
|
|
};
|
|
|
|
/**
|
|
* Set live state.
|
|
*
|
|
* @method
|
|
* @param {boolean} live The view has been attached to the live DOM (use false on detach)
|
|
* @emits live
|
|
*/
|
|
ve.ce.View.prototype.setLive = function ( live ) {
|
|
this.live = live;
|
|
this.emit( 'live' );
|
|
if ( this.live ) {
|
|
this.emit( 'setup' );
|
|
} else {
|
|
this.emit( 'teardown' );
|
|
}
|
|
};
|
|
|
|
/**
|
|
* Render an HTML attribute list onto this.$
|
|
*
|
|
* If no attributeList is given, the attribute list stored in the linear model will be used.
|
|
*
|
|
* @param {Object[]} [attributeList] HTML attribute list, see ve.dm.Converter#buildHtmlAttributeList
|
|
*/
|
|
ve.ce.View.prototype.renderAttributes = function ( attributeList ) {
|
|
ve.dm.Converter.renderHtmlAttributeList(
|
|
attributeList || this.model.getHtmlAttributes(),
|
|
this.$,
|
|
this.constructor.static.renderHtmlAttributes
|
|
);
|
|
};
|