mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-29 00:30:44 +00:00
88f6089952
'''Kranitor commits''' are commits by Krinkle with his janitor hat on. Must never contain functional changes mixed with miscellaneous changes. .gitignore: * Add .DS_Store to the ignore list so that browsing the directories on Mac OS X, will not add these files to the list of untracked files. * Fix missing newline at end of file .jshintrc * raises -> throws * +module (QUnit.module) * remove 'Node' (as of node-jshint 1.7.2 this is now part of 'browser:true', as it should be) Authors: * Adding myself MWExtension/VisualEditor.php * Fix default value of wgVisualEditorParsoidURL to not point to the experimental instance in WMF Labs. Issues: * ve.ce.TextNode: - Fix TODO: Don't perform a useless clone of an already-jQuerified object. - Use .html() to set html content instead of encapsulating between two strings. This is slightly faster but more importantly safer, and prevents situations where the resulting jQuery collection actually contains 2 elements instead of 1, thus messing up what .contents() is iterating over. * ve.ce.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Transaction.test.js - Fix: ReferenceError: assert is not defined * ve.dm.TransactionProcessor.test.js - Fix: ReferenceError: assert is not defined * ext.visualEditor.viewPageTarget - Missing dependency on 'mediawiki.Title' Code conventions / Misc cleanup * Various JSHint warnings. * Whitespace * jQuery(): Use '<tag>' for element creation, use '<valid><xml/></valid>' for parsing * Use the default operator instead of ternary when the condition and first value are the same. x = foo ? foo : bar; -> x = foo || bar; Because contrary to some programming language (PHP...), in JS the default operator does not enforce a boolean result but returns the original value, hence it being called the 'default' operator, as opposed to the 'or' operator. * No need to call addClass() twice, it takes a space-separated list (jQuery splits by space and adds if needed) * Use .on( event[, selector], fn ) instead of the deprecated routers to it such as .bind(), .delegate() and .live(). All these three are now built-in and fully compatible with .on() * Add 'XXX:' comments for suspicious code that I don't want to change as part of a clean up commit. * Remove unused variables (several var x = this; where x was not used anywhere, possibly from boilerplate copy/paste) * Follows-up Trevor's commit that converts test suites to the new QUnit format. Also removed the globals since we no longer use those any more. Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f
138 lines
3.2 KiB
JavaScript
138 lines
3.2 KiB
JavaScript
/**
|
|
* VisualEditor user interface Menu class.
|
|
*
|
|
* @copyright 2011-2012 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
/**
|
|
* Creates an ve.ui.Menu object.
|
|
*
|
|
* @class
|
|
* @constructor
|
|
* @param {Object[]} items List of items to append initially
|
|
* @param {Function} callback Function to call if an item doesn't have its own callback
|
|
* @param {jQuery} [$overlay=$( 'body' )] DOM selection to add nodes to
|
|
*/
|
|
ve.ui.Menu = function ( items, callback, $overlay ) {
|
|
var i, menu;
|
|
|
|
// Properties
|
|
this.$ = $( '<div class="es-menuView"></div>' ).appendTo( $overlay || $( 'body' ) );
|
|
this.items = [];
|
|
this.autoNamedBreaks = 0;
|
|
this.callback = callback;
|
|
|
|
// Items
|
|
if ( ve.isArray( items ) ) {
|
|
for ( i = 0; i < items.length; i++ ) {
|
|
this.addItem( items[i] );
|
|
}
|
|
}
|
|
|
|
// Events
|
|
menu = this;
|
|
menu.$.on( {
|
|
'mousedown': function ( e ) {
|
|
if ( e.which === 1 ) {
|
|
e.preventDefault();
|
|
return false;
|
|
}
|
|
},
|
|
'mouseup': function ( e ) {
|
|
if ( e.which === 1 ) {
|
|
var name, i,
|
|
$item = $( e.target ).closest( '.es-menuView-item' );
|
|
if ( $item.length ) {
|
|
name = $item.attr( 'rel' );
|
|
for ( i = 0; i < menu.items.length; i++ ) {
|
|
if ( menu.items[i].name === name ) {
|
|
menu.onSelect( menu.items[i], e );
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
} );
|
|
};
|
|
|
|
/* Methods */
|
|
|
|
ve.ui.Menu.prototype.addItem = function ( item, before ) {
|
|
if ( item === '-' ) {
|
|
item = {
|
|
'name': 'break-' + this.autoNamedBreaks++
|
|
};
|
|
}
|
|
// Items that don't have custom DOM elements will be auto-created
|
|
if ( !item.$ ) {
|
|
if ( !item.name ) {
|
|
throw 'Invalid menu item error. Items must have a name property.';
|
|
}
|
|
if ( item.label ) {
|
|
item.$ = $( '<div class="es-menuView-item"></div>' )
|
|
.attr( 'rel', item.name )
|
|
// TODO: this should take a labelmsg instead and call ve.msg()
|
|
.append( $( '<span>' ).text( item.label ) );
|
|
} else {
|
|
// No label, must be a break
|
|
item.$ = $( '<div class="es-menuView-break"></div>' )
|
|
.attr( 'rel', item.name );
|
|
}
|
|
// TODO: Keyboard shortcut (and icons for them), support for keyboard accelerators, etc.
|
|
}
|
|
if ( before ) {
|
|
for ( var i = 0; i < this.items.length; i++ ) {
|
|
if ( this.items[i].name === before ) {
|
|
this.items.splice( i, 0, item );
|
|
this.items[i].$.before( item.$ );
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
this.items.push( item );
|
|
this.$.append( item.$ );
|
|
};
|
|
|
|
ve.ui.Menu.prototype.removeItem = function ( name ) {
|
|
for ( var i = 0; i < this.items.length; i++ ) {
|
|
if ( this.items[i].name === name ) {
|
|
this.items.splice( i, 1 );
|
|
i--;
|
|
}
|
|
}
|
|
};
|
|
|
|
ve.ui.Menu.prototype.getItems = function () {
|
|
return this.items;
|
|
};
|
|
|
|
ve.ui.Menu.prototype.setPosition = function ( position ) {
|
|
return this.$.css( {
|
|
'top': position.top,
|
|
'left': position.left
|
|
} );
|
|
};
|
|
|
|
ve.ui.Menu.prototype.open = function () {
|
|
this.$.show();
|
|
};
|
|
|
|
ve.ui.Menu.prototype.close = function () {
|
|
this.$.hide();
|
|
};
|
|
|
|
ve.ui.Menu.prototype.isOpen = function () {
|
|
return this.$.is( ':visible' );
|
|
};
|
|
|
|
ve.ui.Menu.prototype.onSelect = function ( item, event ) {
|
|
if ( typeof item.callback === 'function' ) {
|
|
item.callback( item );
|
|
} else if ( typeof this.callback === 'function' ) {
|
|
this.callback( item );
|
|
}
|
|
this.close();
|
|
};
|