mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-29 08:34:54 +00:00
88f6089952
'''Kranitor commits''' are commits by Krinkle with his janitor hat on.
Must never contain functional changes mixed with miscellaneous changes.
.gitignore:
* Add .DS_Store to the ignore list so that browsing the directories
on Mac OS X, will not add these files to the list of untracked
files.
* Fix missing newline at end of file
.jshintrc
* raises -> throws
* +module (QUnit.module)
* remove 'Node' (as of node-jshint 1.7.2 this is now part of
'browser:true', as it should be)
Authors:
* Adding myself
MWExtension/VisualEditor.php
* Fix default value of wgVisualEditorParsoidURL to not
point to the experimental instance in WMF Labs.
Issues:
* ve.ce.TextNode:
- Fix TODO: Don't perform a useless clone of an already-jQuerified object.
- Use .html() to set html content instead of encapsulating between
two strings. This is slightly faster but more importantly safer,
and prevents situations where the resulting jQuery collection
actually contains 2 elements instead of 1, thus messing up
what .contents() is iterating over.
* ve.ce.Document.test.js
- Fix: ReferenceError: assert is not defined
* ve.dm.Document.test.js
- Fix: ReferenceError: assert is not defined
* ve.dm.Transaction.test.js
- Fix: ReferenceError: assert is not defined
* ve.dm.TransactionProcessor.test.js
- Fix: ReferenceError: assert is not defined
* ext.visualEditor.viewPageTarget
- Missing dependency on 'mediawiki.Title'
Code conventions / Misc cleanup
* Various JSHint warnings.
* Whitespace
* jQuery(): Use '<tag>' for element creation,
use '<valid><xml/></valid>' for parsing
* Use the default operator instead of ternary when the condition and
first value are the same.
x = foo ? foo : bar; -> x = foo || bar;
Because contrary to some programming language (PHP...), in JS the
default operator does not enforce a boolean result but returns the
original value, hence it being called the 'default' operator, as
opposed to the 'or' operator.
* No need to call addClass() twice, it takes a space-separated list
(jQuery splits by space and adds if needed)
* Use .on( event[, selector], fn ) instead of the deprecated
routers to it such as .bind(), .delegate() and .live().
All these three are now built-in and fully compatible with .on()
* Add 'XXX:' comments for suspicious code that I don't want to change
as part of a clean up commit.
* Remove unused variables (several var x = this; where x was not
used anywhere, possibly from boilerplate copy/paste)
* Follows-up Trevor's commit that converts test suites to the new
QUnit format. Also removed the globals since we no longer use those
any more.
Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f
122 lines
2.7 KiB
JavaScript
122 lines
2.7 KiB
JavaScript
/**
|
|
* VisualEditor data model Surface tests.
|
|
*
|
|
* @copyright 2011-2012 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
QUnit.module( 've.dm.Surface' );
|
|
|
|
ve.dm.SurfaceStub = function ( data ) {
|
|
// Inheritance
|
|
|
|
if ( data !== undefined ) {
|
|
this.dm = new ve.dm.Document ( data );
|
|
} else {
|
|
this.dm = new ve.dm.Document ( [{ 'type': 'paragraph' }, 'h', 'i', { 'type': '/paragraph' }] );
|
|
}
|
|
ve.dm.Surface.call( this, this.dm );
|
|
};
|
|
|
|
// Inheritance
|
|
|
|
ve.extendClass( ve.dm.SurfaceStub, ve.dm.Surface );
|
|
|
|
// Tests
|
|
|
|
QUnit.test( 'getDocument', 1, function ( assert ) {
|
|
var surface = new ve.dm.SurfaceStub();
|
|
assert.strictEqual( surface.getDocument(), surface.documentModel );
|
|
} );
|
|
|
|
QUnit.test( 'getSelection', 1, function ( assert ) {
|
|
var surface = new ve.dm.SurfaceStub();
|
|
assert.strictEqual( surface.getSelection(), surface.selection );
|
|
} );
|
|
|
|
QUnit.test( 'change', 3, function ( assert ) {
|
|
var surface = new ve.dm.SurfaceStub(),
|
|
tx = new ve.dm.Transaction(),
|
|
events = {
|
|
'transact': 0,
|
|
'select': 0,
|
|
'change': 0
|
|
};
|
|
|
|
surface.on( 'transact', function () {
|
|
events.transact++;
|
|
} );
|
|
surface.on( 'select', function () {
|
|
events.select++;
|
|
} );
|
|
surface.on( 'change', function () {
|
|
events.change++;
|
|
} );
|
|
surface.change( tx );
|
|
assert.deepEqual( events, { 'transact': 1, 'select': 0, 'change': 1 } );
|
|
surface.change( null, new ve.Range( 1, 1 ) );
|
|
assert.deepEqual( events, { 'transact': 1, 'select': 1, 'change': 2 } );
|
|
surface.change( tx, new ve.Range( 2, 2 ) );
|
|
assert.deepEqual( events, { 'transact': 2, 'select': 2, 'change': 3 } );
|
|
} );
|
|
|
|
QUnit.test( 'annotate', 1, function ( assert ) {
|
|
var i,
|
|
surface,
|
|
cases = [
|
|
{
|
|
'msg': 'Set Bold',
|
|
'data': [
|
|
'b', 'o', 'l', 'd'
|
|
],
|
|
'expected':
|
|
[
|
|
[
|
|
"b",
|
|
{
|
|
"{\"type\":\"textStyle/bold\"}": {
|
|
"type": "textStyle/bold"
|
|
}
|
|
}
|
|
],
|
|
[
|
|
"o",
|
|
{
|
|
"{\"type\":\"textStyle/bold\"}": {
|
|
"type": "textStyle/bold"
|
|
}
|
|
}
|
|
],
|
|
[
|
|
"l",
|
|
{
|
|
"{\"type\":\"textStyle/bold\"}": {
|
|
"type": "textStyle/bold"
|
|
}
|
|
}
|
|
],
|
|
[
|
|
"d",
|
|
{
|
|
"{\"type\":\"textStyle/bold\"}": {
|
|
"type": "textStyle/bold"
|
|
}
|
|
}
|
|
]
|
|
],
|
|
'annotate': {
|
|
'method': 'set',
|
|
'annotation': { 'type': 'textStyle/bold' }
|
|
}
|
|
}
|
|
];
|
|
|
|
QUnit.expect( cases.length );
|
|
for ( i = 0; i < cases.length; i++ ) {
|
|
surface = new ve.dm.SurfaceStub( cases[i].data );
|
|
surface.change( null, new ve.Range( 0, surface.getDocument().getData().length ) );
|
|
surface.annotate( cases[i].annotate.method, cases[i].annotate.annotation );
|
|
assert.deepEqual( surface.getDocument().getData(), cases[i].expected, cases[i].msg );
|
|
}
|
|
} );
|