mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-25 14:56:20 +00:00
9372ca60ad
The way it operated was evil. It did a depth-first search from the root, finding the node using reference equality. For documents with deep structures, this could take a long time. Inez did some profiling and found it was called tens of millions of times on a complex document. Kill getOffsetFromNode() and move its functionality to getOffset(). The logic has been completely rewritten: getOffset() now traverses up from the node rather than down from the root, and pretty much does the reverse of what getNodeFromOffset() does. This should be much more efficient even without offset caching in the node objects (which we may still implement later). Change-Id: I125f9fa423c40db6472e2c4a7c94214218ba3bc7
126 lines
4 KiB
JavaScript
126 lines
4 KiB
JavaScript
/*!
|
|
* VisualEditor DataModel BranchNode tests.
|
|
*
|
|
* @copyright 2011-2013 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
QUnit.module( 've.dm.BranchNode' );
|
|
|
|
/* Stubs */
|
|
|
|
ve.dm.BranchNodeStub = function VeDmBranchNodeStub( children, element ) {
|
|
// Parent constructor
|
|
ve.dm.BranchNode.call( this, children, element );
|
|
};
|
|
|
|
ve.inheritClass( ve.dm.BranchNodeStub, ve.dm.BranchNode );
|
|
|
|
ve.dm.BranchNodeStub.static.name = 'branch-stub';
|
|
|
|
ve.dm.BranchNodeStub.static.matchTagNames = [];
|
|
|
|
ve.dm.nodeFactory.register( ve.dm.BranchNodeStub );
|
|
|
|
/* Tests */
|
|
|
|
QUnit.test( 'canHaveChildren', 1, function ( assert ) {
|
|
var node = new ve.dm.BranchNodeStub();
|
|
assert.equal( node.canHaveChildren(), true );
|
|
} );
|
|
|
|
QUnit.test( 'canHaveChildrenNotContent', 1, function ( assert ) {
|
|
var node = new ve.dm.BranchNodeStub();
|
|
assert.equal( node.canHaveChildrenNotContent(), true );
|
|
} );
|
|
|
|
QUnit.test( 'setRoot', 3, function ( assert ) {
|
|
var node1 = new ve.dm.BranchNodeStub(),
|
|
node2 = new ve.dm.BranchNodeStub( [node1] ),
|
|
node3 = new ve.dm.BranchNodeStub( [node2] ),
|
|
node4 = new ve.dm.BranchNodeStub();
|
|
node3.setRoot( node4 );
|
|
assert.strictEqual( node3.getRoot(), node4 );
|
|
assert.strictEqual( node2.getRoot(), node4 );
|
|
assert.strictEqual( node1.getRoot(), node4 );
|
|
} );
|
|
|
|
QUnit.test( 'setDocument', 3, function ( assert ) {
|
|
var node1 = new ve.dm.BranchNodeStub(),
|
|
node2 = new ve.dm.BranchNodeStub( [node1] ),
|
|
node3 = new ve.dm.BranchNodeStub( [node2] ),
|
|
node4 = new ve.dm.BranchNodeStub();
|
|
node3.setDocument( node4 );
|
|
assert.strictEqual( node3.getDocument(), node4 );
|
|
assert.strictEqual( node2.getDocument(), node4 );
|
|
assert.strictEqual( node1.getDocument(), node4 );
|
|
} );
|
|
|
|
QUnit.test( 'push', 3, function ( assert ) {
|
|
var node1 = new ve.dm.BranchNodeStub(),
|
|
node2 = new ve.dm.BranchNodeStub(),
|
|
node3 = new ve.dm.BranchNodeStub( [node1] );
|
|
node3.on( 'splice', function () {
|
|
// Will be called 1 time
|
|
assert.ok( true, 'splice was emitted' );
|
|
} );
|
|
assert.strictEqual( node3.push( node2 ), 2 );
|
|
assert.deepEqual( node3.getChildren(), [node1, node2] );
|
|
} );
|
|
|
|
QUnit.test( 'pop', 3, function ( assert ) {
|
|
var node1 = new ve.dm.BranchNodeStub(),
|
|
node2 = new ve.dm.BranchNodeStub(),
|
|
node3 = new ve.dm.BranchNodeStub( [node1, node2] );
|
|
node3.on( 'splice', function () {
|
|
// Will be called 1 time
|
|
assert.ok( true, 'splice was emitted' );
|
|
} );
|
|
assert.strictEqual( node3.pop(), node2 );
|
|
assert.deepEqual( node3.getChildren(), [node1] );
|
|
} );
|
|
|
|
QUnit.test( 'unshift', 3, function ( assert ) {
|
|
var node1 = new ve.dm.BranchNodeStub(),
|
|
node2 = new ve.dm.BranchNodeStub(),
|
|
node3 = new ve.dm.BranchNodeStub( [node1] );
|
|
node3.on( 'splice', function () {
|
|
// Will be called 1 time
|
|
assert.ok( true, 'splice was emitted' );
|
|
} );
|
|
assert.strictEqual( node3.unshift( node2 ), 2 );
|
|
assert.deepEqual( node3.getChildren(), [node2, node1] );
|
|
} );
|
|
|
|
QUnit.test( 'shift', 3, function ( assert ) {
|
|
var node1 = new ve.dm.BranchNodeStub(),
|
|
node2 = new ve.dm.BranchNodeStub(),
|
|
node3 = new ve.dm.BranchNodeStub( [node1, node2] );
|
|
node3.on( 'splice', function () {
|
|
// Will be called 1 time
|
|
assert.ok( true, 'splice was emitted' );
|
|
} );
|
|
assert.strictEqual( node3.shift(), node1 );
|
|
assert.deepEqual( node3.getChildren(), [node2] );
|
|
} );
|
|
|
|
QUnit.test( 'splice', 9, function ( assert ) {
|
|
var node1 = new ve.dm.BranchNodeStub(),
|
|
node2 = new ve.dm.BranchNodeStub(),
|
|
node3 = new ve.dm.BranchNodeStub(),
|
|
node4 = new ve.dm.BranchNodeStub( [node1, node2] );
|
|
node4.on( 'splice', function () {
|
|
// Will be called 3 times
|
|
assert.ok( true, 'splice was emitted' );
|
|
} );
|
|
// Insert branch
|
|
assert.deepEqual( node4.splice( 1, 0, node3 ), [] );
|
|
assert.deepEqual( node4.getChildren(), [node1, node3, node2] );
|
|
// Remove branch
|
|
assert.deepEqual( node4.splice( 1, 1 ), [node3] );
|
|
assert.deepEqual( node4.getChildren(), [node1, node2] );
|
|
// Remove branch and insert branch
|
|
assert.deepEqual( node4.splice( 1, 1, node3 ), [node2] );
|
|
assert.deepEqual( node4.getChildren(), [node1, node3] );
|
|
} );
|