mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-15 18:39:52 +00:00
9ff6737f4c
Rather than using namespaced linmod attributes, store the preserved HTML attributes in the .htmlAttributes property of the linear model element, in a nested structure to allow for easier treatment of child nodes. Also added attribute order preservation by storing attributes as an object plus an array of keys. ve.ce.Node.js: * Remove html/* attribute synchronization. Doesn't make sense any more because these things aren't in the attributes object any more. I don't think it ever made sense because these attributes were never supposed to be changed anyway. ve.ce.View.js: * Replace renderAttributes() with a simple wrapper around renderHtmlAttributeList() ve.dm.Converter.js: * Add buildHtmlAttributeList() and renderHtmlAttributes() for building and rendering HTML attribute lists ve.dm.Model.js: * Add getter for .htmlAttributes ve.dm.Node.js: * Drop .htmlAttributes on clone, and remove logic dropping html/* ve.ui.MWCategoryWidget.js: * Remove html/0/about hack, was already unnecessary and now doesn't work any more tests/: * UPDATE ALL THE TESTS Change-Id: I620573afd70d36ade6b80413075b6e1f4a435abe
253 lines
5.8 KiB
JavaScript
253 lines
5.8 KiB
JavaScript
/*!
|
|
* VisualEditor DataModel Node tests.
|
|
*
|
|
* @copyright 2011-2013 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
QUnit.module( 've.dm.Node' );
|
|
|
|
/* Stubs */
|
|
|
|
ve.dm.NodeStub = function VeDmNodeStub( length, element ) {
|
|
// Parent constructor
|
|
ve.dm.Node.call( this, length, element );
|
|
};
|
|
|
|
ve.inheritClass( ve.dm.NodeStub, ve.dm.LeafNode );
|
|
|
|
ve.dm.NodeStub.static.name = 'stub';
|
|
|
|
ve.dm.NodeStub.static.matchTagNames = [];
|
|
|
|
ve.dm.nodeFactory.register( ve.dm.NodeStub );
|
|
|
|
/* Tests */
|
|
|
|
QUnit.test( 'canHaveChildren', 1, function ( assert ) {
|
|
var node = new ve.dm.NodeStub();
|
|
assert.equal( node.canHaveChildren(), false );
|
|
} );
|
|
|
|
QUnit.test( 'canHaveChildrenNotContent', 1, function ( assert ) {
|
|
var node = new ve.dm.NodeStub();
|
|
assert.equal( node.canHaveChildrenNotContent(), false );
|
|
} );
|
|
|
|
QUnit.test( 'getLength', 2, function ( assert ) {
|
|
var node1 = new ve.dm.NodeStub(),
|
|
node2 = new ve.dm.NodeStub( 1234 );
|
|
assert.strictEqual( node1.getLength(), 0 );
|
|
assert.strictEqual( node2.getLength(), 1234 );
|
|
} );
|
|
|
|
QUnit.test( 'getOuterLength', 2, function ( assert ) {
|
|
var node1 = new ve.dm.NodeStub(),
|
|
node2 = new ve.dm.NodeStub( 1234 );
|
|
assert.strictEqual( node1.getOuterLength(), 2 );
|
|
assert.strictEqual( node2.getOuterLength(), 1236 );
|
|
} );
|
|
|
|
QUnit.test( 'setLength', 2, function ( assert ) {
|
|
var node = new ve.dm.NodeStub();
|
|
node.setLength( 1234 );
|
|
assert.strictEqual( node.getLength(), 1234 );
|
|
assert.throws(
|
|
function () {
|
|
// Length cannot be negative
|
|
node.setLength( -1 );
|
|
},
|
|
Error,
|
|
'throws exception if length is negative'
|
|
);
|
|
} );
|
|
|
|
QUnit.test( 'adjustLength', 1, function ( assert ) {
|
|
var node = new ve.dm.NodeStub( 1234 );
|
|
node.adjustLength( 5678 );
|
|
assert.strictEqual( node.getLength(), 6912 );
|
|
} );
|
|
|
|
QUnit.test( 'getAttribute', 2, function ( assert ) {
|
|
var node = new ve.dm.NodeStub( 0, { 'type': 'stub', 'attributes': { 'a': 1, 'b': 2 } } );
|
|
assert.strictEqual( node.getAttribute( 'a' ), 1 );
|
|
assert.strictEqual( node.getAttribute( 'b' ), 2 );
|
|
} );
|
|
|
|
QUnit.test( 'setRoot', 1, function ( assert ) {
|
|
var node1 = new ve.dm.NodeStub(),
|
|
node2 = new ve.dm.NodeStub();
|
|
node1.setRoot( node2 );
|
|
assert.strictEqual( node1.getRoot(), node2 );
|
|
} );
|
|
|
|
QUnit.test( 'attach', 2, function ( assert ) {
|
|
var node1 = new ve.dm.NodeStub(),
|
|
node2 = new ve.dm.NodeStub();
|
|
node1.attach( node2 );
|
|
assert.strictEqual( node1.getParent(), node2 );
|
|
assert.strictEqual( node1.getRoot(), node2 );
|
|
} );
|
|
|
|
QUnit.test( 'detach', 2, function ( assert ) {
|
|
var node1 = new ve.dm.NodeStub(),
|
|
node2 = new ve.dm.NodeStub();
|
|
node1.attach( node2 );
|
|
node1.detach();
|
|
assert.strictEqual( node1.getParent(), null );
|
|
assert.strictEqual( node1.getRoot(), node1 );
|
|
} );
|
|
|
|
QUnit.test( 'canBeMergedWith', 4, function ( assert ) {
|
|
var node1 = new ve.dm.LeafNodeStub(),
|
|
node2 = new ve.dm.BranchNodeStub( [node1] ),
|
|
node3 = new ve.dm.BranchNodeStub( [node2] ),
|
|
node4 = new ve.dm.LeafNodeStub(),
|
|
node5 = new ve.dm.BranchNodeStub( [node4] );
|
|
|
|
assert.strictEqual( node3.canBeMergedWith( node5 ), true, 'same level, same type' );
|
|
assert.strictEqual( node2.canBeMergedWith( node5 ), false, 'different level, same type' );
|
|
assert.strictEqual( node2.canBeMergedWith( node1 ), false, 'different level, different type' );
|
|
assert.strictEqual( node2.canBeMergedWith( node4 ), false, 'same level, different type' );
|
|
} );
|
|
|
|
QUnit.test( 'getClonedElement', function ( assert ) {
|
|
var i, node,
|
|
cases = [
|
|
{
|
|
'original': {
|
|
'type': 'foo'
|
|
},
|
|
'clone': {
|
|
'type': 'foo'
|
|
},
|
|
'msg': 'Simple element is cloned verbatim'
|
|
},
|
|
{
|
|
'original': {
|
|
'type': 'foo',
|
|
'attributes': {
|
|
'bar': 'baz'
|
|
}
|
|
},
|
|
'clone': {
|
|
'type': 'foo',
|
|
'attributes': {
|
|
'bar': 'baz'
|
|
}
|
|
},
|
|
'msg': 'Element with simple attributes is cloned verbatim'
|
|
},
|
|
{
|
|
'original': {
|
|
'type': 'foo',
|
|
'attributes': {
|
|
'bar': 'baz'
|
|
},
|
|
'htmlAttributes': [
|
|
{
|
|
'keys': [ 'typeof', 'href' ],
|
|
'values': {
|
|
'typeof': 'Foo',
|
|
'href': 'Bar'
|
|
}
|
|
}
|
|
]
|
|
},
|
|
'clone': {
|
|
'type': 'foo',
|
|
'attributes': {
|
|
'bar': 'baz'
|
|
}
|
|
},
|
|
'msg': 'htmlAttributes is removed from clone'
|
|
},
|
|
{
|
|
'original': {
|
|
'type': 'foo',
|
|
'internal': {
|
|
'generated': 'wrapper',
|
|
'whitespace': [ undefined, ' ' ]
|
|
}
|
|
},
|
|
'clone': {
|
|
'type': 'foo',
|
|
'internal': {
|
|
'whitespace': [ undefined, ' ' ]
|
|
}
|
|
},
|
|
'msg': 'internal.generated property is removed from clone'
|
|
},
|
|
{
|
|
'original': {
|
|
'type': 'foo',
|
|
'internal': {
|
|
'generated': 'wrapper'
|
|
}
|
|
},
|
|
'clone': {
|
|
'type': 'foo'
|
|
},
|
|
'msg': 'internal property is removed if it only contained .generated'
|
|
},
|
|
{
|
|
'original': {
|
|
'type': 'foo',
|
|
'internal': {
|
|
'generated': 'wrapper'
|
|
},
|
|
'htmlAttributes': [
|
|
{
|
|
'keys': [ 'typeof', 'href' ],
|
|
'values': {
|
|
'typeof': 'Foo',
|
|
'href': 'Bar'
|
|
}
|
|
}
|
|
]
|
|
},
|
|
'clone': {
|
|
'type': 'foo'
|
|
},
|
|
'msg': 'internal and htmlAttributes properties are both removed'
|
|
},
|
|
{
|
|
'original': {
|
|
'type': 'foo',
|
|
'internal': {
|
|
'generated': 'wrapper',
|
|
'whitespace': [ undefined, ' ' ],
|
|
},
|
|
'attributes': {
|
|
'bar': 'baz'
|
|
},
|
|
'htmlAttributes': [
|
|
{
|
|
'keys': [ 'typeof', 'href' ],
|
|
'values': {
|
|
'typeof': 'Foo',
|
|
'href': 'Bar'
|
|
}
|
|
}
|
|
]
|
|
},
|
|
'clone': {
|
|
'type': 'foo',
|
|
'internal': {
|
|
'whitespace': [ undefined, ' ' ],
|
|
},
|
|
'attributes': {
|
|
'bar': 'baz'
|
|
}
|
|
},
|
|
'msg': 'internal.generated and htmlAttributes are both removed'
|
|
}
|
|
];
|
|
QUnit.expect( cases.length );
|
|
|
|
for ( i = 0; i < cases.length; i++ ) {
|
|
node = new ve.dm.NodeStub( 0, cases[i].original );
|
|
assert.deepEqual( node.getClonedElement(), cases[i].clone, cases[i].msg );
|
|
}
|
|
} );
|