mediawiki-extensions-Visual.../modules/ve-mw/ce/nodes/ve.ce.MWImageCaptionNode.js
Ed Sanders 76defa7ce2 MWBlockImage new DOM fixes
MWBlockImage
* Remove properties which just cache model properties. We can get
  fresh values from the model whenever needed and this just causes
  problems keeping them in sync.
* Tidy up DOM documentation indentation
* Merge setupCaption and setCaptionVisible into updateCaption. The
  caption's visibility can be calculated inside the method from
  model attributes.
* No need to generate figcaption on init, updateCaption  will do
  this for us
* Storing full view and model in this.caption is unnecessary,
  just store this.$caption (view.$element) and this.captionVisible
* Append the caption directly to the figure now there is no container
* Simplify setCaptionVisible
* Add in fix to account for border to figure width
* updateSize can get values from the model if they are not provided
* Remove unnecessary styles being set on this.$element.

MWImageCaption
* Generate as a figcaption instead of a div for direct attachment

MWImage
* Missing docs

CSS
* Cleanup reset styles, remove redundant add in required
* Fix margins for left/right floats to match .tleft/.tright
* Use more specific selector for inner border (thumbimage) to avoid
  matching shields.
* Remove unnecessary frameless styles, it has no border by default.

Change-Id: I52e0e10b465bb9761c2e4be28c98bec37b0dd2ca
2013-12-18 22:53:13 +00:00

83 lines
2 KiB
JavaScript

/*!
* VisualEditor ContentEditable ListItemNode class.
*
* @copyright 2011-2013 VisualEditor Team and others; see AUTHORS.txt
* @license The MIT License (MIT); see LICENSE.txt
*/
/*global mw */
/**
* ContentEditable image caption item node.
*
* @class
* @extends ve.ce.BranchNode
* @constructor
* @param {ve.dm.MWImageCaptionNode} model Model to observe
* @param {Object} [config] Configuration options
*/
ve.ce.MWImageCaptionNode = function VeCeMWImageCaptionNode( model, config ) {
// Parent constructor
ve.ce.BranchNode.call( this, model, config );
// DOM changes
this.$element.addClass( 'thumbcaption' );
};
/* Inheritance */
OO.inheritClass( ve.ce.MWImageCaptionNode, ve.ce.BranchNode );
/* Static Properties */
ve.ce.MWImageCaptionNode.static.name = 'mwImageCaption';
ve.ce.MWImageCaptionNode.static.tagName = 'figcaption';
/* Methods */
/**
* TODO: Magnify should appear/disappear based on the changes/updates to the parent (switching to
* and from thumb or frame).
*/
ve.ce.MWImageCaptionNode.prototype.onSplice = function () {
var parentType = this.model.getParent().getAttribute( 'type' );
if ( parentType === 'thumb' ) {
if ( this.$magnify ) {
this.$magnify.detach();
} else {
this.buildMagnify();
}
}
// Parent method
ve.ce.BranchNode.prototype.onSplice.apply( this, arguments );
if ( parentType === 'thumb' ) {
this.$magnify.prependTo( this.$element );
}
};
/** */
ve.ce.MWImageCaptionNode.prototype.buildMagnify = function () {
this.$magnify = this.$( '<div>' )
.addClass( 'magnify' );
this.$a = this.$( '<a>' )
.addClass( 'internal' )
// It's inside a protected node, so user can't see href/title anyways.
//.attr( 'href', '/wiki/File:Wiki.png' )
//.attr( 'title', 'Enlarge' )
.appendTo( this.$magnify );
this.$img = this.$( '<img>' )
.attr( 'src', mw.config.get( 'wgVisualEditor' ).magnifyClipIconURL )
.attr( 'width', 15 )
.attr( 'height', 11 )
//.attr( 'alt', '' )
.appendTo( this.$a );
};
/* Registration */
ve.ce.nodeFactory.register( ve.ce.MWImageCaptionNode );