mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-25 06:46:26 +00:00
7233ea8f1b
The EventEmitter API we inherited from Node.js and then bastardized was getting awkward and cumbersome. The number of uses of ve.bind was getting out of control, and removing events meant caching the bound method in a property. Many of the "features" of EventEmitter wasn't even being used, some causing overhead, others just causing bloat. This change cleans up how EventEmitter is used throughout the codebase. The new event emitter API includes: * emit - identical to the previous API, no longer throws an error if you emit error without a handler * once - identical to the previous API, still introduces a wrapper* on - compatible with the previous API but has some new features * off - identical to removeListener in the previous API * connect - very similar to addListenerMethods but doesn't wrap callbacks in closures anymore * disconnect - new, basically the opposite of addListenerMethods Another change that is made in this commit is mixing in rather than inheriting from EventEmitter. Finally, there are changes throughout the codebase anywhere connect/disconnect could be used. Change-Id: Ic3085d39172a8a719ce7f036690f673e59848d3a
61 lines
1.3 KiB
JavaScript
61 lines
1.3 KiB
JavaScript
/*!
|
|
* VisualEditor ContentEditable DefinitionListItemNode class.
|
|
*
|
|
* @copyright 2011-2013 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
/**
|
|
* ContentEditable definition list item node.
|
|
*
|
|
* @class
|
|
* @extends ve.ce.BranchNode
|
|
* @constructor
|
|
* @param {ve.dm.DefinitionListItemNode} model Model to observe
|
|
*/
|
|
ve.ce.DefinitionListItemNode = function VeCeDefinitionListItemNode( model ) {
|
|
// Parent constructor
|
|
ve.ce.BranchNode.call(
|
|
this, model, ve.ce.BranchNode.getDomWrapper( model, 'style' )
|
|
);
|
|
|
|
// Events
|
|
this.model.connect( this, { 'update': 'onUpdate' } );
|
|
};
|
|
|
|
/* Inheritance */
|
|
|
|
ve.inheritClass( ve.ce.DefinitionListItemNode, ve.ce.BranchNode );
|
|
|
|
/* Static Properties */
|
|
|
|
ve.ce.DefinitionListItemNode.static.name = 'definitionListItem';
|
|
|
|
/**
|
|
* Mapping of list item style values and DOM wrapper element types.
|
|
*
|
|
* @static
|
|
* @property
|
|
*/
|
|
ve.ce.DefinitionListItemNode.domWrapperElementTypes = {
|
|
'definition': 'dd',
|
|
'term': 'dt'
|
|
};
|
|
|
|
/* Methods */
|
|
|
|
/**
|
|
* Handle model update events.
|
|
*
|
|
* If the style changed since last update the DOM wrapper will be replaced with an appropriate one.
|
|
*
|
|
* @method
|
|
*/
|
|
ve.ce.DefinitionListItemNode.prototype.onUpdate = function () {
|
|
this.updateDomWrapper( 'style' );
|
|
};
|
|
|
|
/* Registration */
|
|
|
|
ve.ce.nodeFactory.register( ve.ce.DefinitionListItemNode );
|