mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-16 19:09:29 +00:00
2966b69609
There is a codepath where `modelPromise` is undefined and calling `modelPromise.then()` fails. This codepath implies that the dialog is empty and there is nothing to update. We can just close the dialog then. I found this while debugging the actions in this dialog. This happens when the dialog is empty (except for a placeholder) but you submit it anyway. This is typically not possible as the button is supposed to be disabled. Still I think it's a good idea to make this code less fragile. The relevant code was introduced in Ibc2fc66 (2016). Change-Id: Ia6b723548456c211b944a2320949bfc23b0afa16 |
||
---|---|---|
.. | ||
actions | ||
commands | ||
contextitems | ||
datatransferhandlers | ||
dialogs | ||
elements | ||
inspectors | ||
pages | ||
styles | ||
tools | ||
widgets | ||
ve.ui.MWCommandRegistry.js | ||
ve.ui.MWExtensionWindow.js | ||
ve.ui.MWSequenceRegistry.js | ||
ve.ui.MWSurface.js | ||
ve.ui.MWTransclusionsBooklet.js | ||
ve.ui.MWWikitextCommandRegistry.js | ||
ve.ui.MWWikitextDataTransferHandlerFactory.js | ||
ve.ui.MWWikitextSequenceRegistry.js | ||
ve.ui.MWWikitextSurface.js | ||
ve.ui.MWWikitextTransferRegistry.js |