mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-25 14:56:20 +00:00
293609e5d8
We weren't unbinding these handlers at all, and so the 'ok' or 'cancel' handlers could run multiple times for one button click, and even worse, you could get in a situation where clicking 'ok' in one confirm dialog would also run the 'ok' handler for the other one. This happens because the ConfirmDialog instance is recycled by the WindowSet. The way the unbinding is done is ugly; we should either consolidate the 'ok' and 'cancel' events so we can use .once(), or come up with some other way to automatically unbind the handlers. Bug: 65557 Change-Id: Iabf0c0d0229add09cc775358fc5a4e5ae783db04 |
||
---|---|---|
.. | ||
ve-mw | ||
ve-wmf/i18n |