mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-29 08:34:54 +00:00
fda2e6c1b5
MWInternalLinkAnnotation was normalizing spaces to underscores. This is bad. Instead, we now do the following: * Normalize underscores to spaces for display purposes * Store the original title without underscore/space mangling * If the user didn't change the title (display title === original title with s/_/ /g), use the original title. Otherwise use the user's title verbatim, without normalizing either underscores or spaces. Also, per a conversation with Gabriel, we now only restore hrefPrefix when we're also restoring origTitle, otherwise Parsoid will barf. Change-Id: Ia74a493b2bce96c9345b60ed692eeb2e43ebceff
87 lines
2.4 KiB
JavaScript
87 lines
2.4 KiB
JavaScript
/**
|
|
* VisualEditor data model MWInternalLinkAnnotation class.
|
|
*
|
|
* @copyright 2011-2012 VisualEditor Team and others; see AUTHORS.txt
|
|
* @license The MIT License (MIT); see LICENSE.txt
|
|
*/
|
|
|
|
/**
|
|
* MediaWiki internal link annotation.
|
|
*
|
|
* Example HTML sources:
|
|
* <a rel="mw:WikiLink">
|
|
*
|
|
* @class
|
|
* @constructor
|
|
* @extends {ve.dm.LinkAnnotation}
|
|
* @param {HTMLElement} element
|
|
*/
|
|
ve.dm.MWInternalLinkAnnotation = function VeDmMWInternalLinkAnnotation( element ) {
|
|
// Parent constructor
|
|
ve.dm.LinkAnnotation.call( this, element );
|
|
};
|
|
|
|
/* Inheritance */
|
|
|
|
ve.inheritClass( ve.dm.MWInternalLinkAnnotation, ve.dm.LinkAnnotation );
|
|
|
|
/* Static Members */
|
|
|
|
ve.dm.MWInternalLinkAnnotation.static.name = 'link/MWinternal';
|
|
|
|
ve.dm.MWInternalLinkAnnotation.static.matchRdfaTypes = ['mw:WikiLink'];
|
|
|
|
/* Methods */
|
|
|
|
/**
|
|
* Get annotation data, especially the href of the link.
|
|
*
|
|
* @method
|
|
* @param {HTMLElement} element
|
|
* @returns {Object} Annotation data, containing 'hrefPrefix' and 'title' properties
|
|
*/
|
|
ve.dm.MWInternalLinkAnnotation.prototype.getAnnotationData = function( element ) {
|
|
// Get title from href
|
|
// The href is simply the title, unless we're dealing with a page that has slashes in its name
|
|
// in which case it's preceded by one or more instances of "./" or "../", so strip those
|
|
/*jshint regexp:false */
|
|
var matches = element.getAttribute( 'href' ).match( /^((?:\.\.?\/)*)(.*)$/ );
|
|
return {
|
|
// Store the ./ and ../ prefixes so we can restore them on the way out
|
|
'hrefPrefix': matches[1],
|
|
'title': matches[2].replace( /_/g, ' ' ),
|
|
'origTitle': matches[2]
|
|
};
|
|
};
|
|
|
|
/**
|
|
* Convert to an object with HTML element information.
|
|
*
|
|
* @method
|
|
* @returns {Object} HTML element information, including tag and attributes properties
|
|
*/
|
|
ve.dm.MWInternalLinkAnnotation.prototype.toHTML = function () {
|
|
var href,
|
|
parentResult = ve.dm.LinkAnnotation.prototype.toHTML.call( this );
|
|
if (
|
|
this.data.origTitle &&
|
|
this.data.origTitle.replace( /_/g, ' ' ) === this.data.title
|
|
) {
|
|
// Restore href from origTitle
|
|
href = this.data.origTitle;
|
|
// Only use hrefPrefix if restoring from origTitle
|
|
if ( this.data.hrefPrefix ) {
|
|
href = this.data.hrefPrefix + href;
|
|
}
|
|
} else {
|
|
href = this.data.title;
|
|
}
|
|
parentResult.attributes.href = href;
|
|
parentResult.attributes.rel = 'mw:WikiLink';
|
|
return parentResult;
|
|
};
|
|
|
|
/* Registration */
|
|
|
|
ve.dm.annotationFactory.register( 'link/MWinternal', ve.dm.MWInternalLinkAnnotation );
|